Re: [PATCH v2 4/4] ASoC: rsnd: use regmap instead of original register mapping method

2013-09-17 Thread Mark Brown
On Tue, Sep 17, 2013 at 10:23:58PM +0900, Kuninori Morimoto wrote: > For example, SSI device have many ports (0-8), > but ADG is only 1 device. > On this driver, all devices are using rsnd_write/read() to > access register. OK, this sounds like the module should have this information - ie check s

Re: [PATCH v2 4/4] ASoC: rsnd: use regmap instead of original register mapping method

2013-09-17 Thread Kuninori Morimoto
Dear Mark > > +void rsnd_write(struct rsnd_priv *priv, > > + struct rsnd_mod *mod, > > + enum rsnd_reg reg, u32 data) > > +{ > > + struct rsnd_gen *gen = rsnd_priv_to_gen(priv); > > + > > + if (regmap_fields_enable(gen->regs[reg])) > > + regmap_fields_write(gen->

Re: [PATCH v2 4/4] ASoC: rsnd: use regmap instead of original register mapping method

2013-09-17 Thread Mark Brown
On Sun, Sep 01, 2013 at 08:32:45PM -0700, Kuninori Morimoto wrote: > +void rsnd_write(struct rsnd_priv *priv, > + struct rsnd_mod *mod, > + enum rsnd_reg reg, u32 data) > +{ > + struct rsnd_gen *gen = rsnd_priv_to_gen(priv); > + > + if (regmap_fields_enable(gen->reg

[PATCH v2 4/4] ASoC: rsnd: use regmap instead of original register mapping method

2013-09-01 Thread Kuninori Morimoto
Current Linux kernel is supporting regmap/regmap_field, and, it is good match for Renesas Sound Gen1/Gen2 register mapping. This patch uses regmap instead of original method for register access Signed-off-by: Kuninori Morimoto --- v1 -> v2 - exchange macro naming (RSND_GEN1_S_REG/RSND_GEN1_M_RE