Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Fri, Oct 23, 2015 at 2:04 AM, Dan Carpenter wrote: > First fetch the changes, then check them out. > > $ git fetch git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-next > $ git checkout FETCH_HEAD > > regards, > dan carpenter > Thank you very much Dan. Problem is solved :-) @Greg I haven't found any warnings in your tree .You might applied this patch before. So I am forward to create other patches -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Fri, Oct 23, 2015 at 2:04 AM, Dan Carpenterwrote: > First fetch the changes, then check them out. > > $ git fetch git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-next > $ git checkout FETCH_HEAD > > regards, > dan carpenter > Thank you very much Dan. Problem is solved :-) @Greg I haven't found any warnings in your tree .You might applied this patch before. So I am forward to create other patches -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
First fetch the changes, then check them out. $ git fetch git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next $ git checkout FETCH_HEAD regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Fri, Oct 23, 2015 at 12:52 AM, Dan Carpenter wrote: > On Fri, Oct 23, 2015 at 12:34:36AM +0530, punit vara wrote: >> I am working on linux-next .I have tried to rebase my local branch on >> your staging tree but I am getting too many conflict .and I have tried >> to clone your staging tree separately but due slow internet I am >> unable to clone it fully . Is there any other way I can get your >> staging tree by downloading ? > > For a while, I had the worst internet of any kernel dev. I can help. :) > > Do you have any complete kernel git repository? If you download it one > time then you just do a `git fetch` and `git checkout` after that. > Never do a `git pull`. > > Downloading the linux kernel git repository the first time over bad > internet is a huge headache because if you lose the connection then you > have to restart. See if someone can post a .tar.gz of the kernel .git > directory on a webpage for you then you can download it bit by bit using > wget. Unpack it and do a `git reset --hard`. > > regards, > dan carpenter >>git branch -a master * my_local_branch old-local-1 remotes/gregkh/master remotes/gregkh/staging-linus remotes/gregkh/staging-next remotes/gregkh/staging-testing remotes/gregkh/test remotes/linux-next/akpm remotes/linux-next/akpm-base remotes/linux-next/master remotes/linux-next/stable remotes/origin/HEAD -> origin/master remotes/origin/master >>git remote -v gregkhhttp://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git (fetch) gregkhhttp://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git (push) linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git (fetch) linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git (push) originhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git (fetch) originhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git (push) Above is my situation I have performed >> commands in terminal. >>git checkout origin/master >>git checkout -b experimental origin/master >>git fetch gregkh Am I doing the right thing to get staging changes in my experimental branch ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Fri, Oct 23, 2015 at 12:34:36AM +0530, punit vara wrote: > I am working on linux-next .I have tried to rebase my local branch on > your staging tree but I am getting too many conflict .and I have tried > to clone your staging tree separately but due slow internet I am > unable to clone it fully . Is there any other way I can get your > staging tree by downloading ? For a while, I had the worst internet of any kernel dev. I can help. :) Do you have any complete kernel git repository? If you download it one time then you just do a `git fetch` and `git checkout` after that. Never do a `git pull`. Downloading the linux kernel git repository the first time over bad internet is a huge headache because if you lose the connection then you have to restart. See if someone can post a .tar.gz of the kernel .git directory on a webpage for you then you can download it bit by bit using wget. Unpack it and do a `git reset --hard`. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Fri, Oct 23, 2015 at 12:34:36AM +0530, punit vara wrote: > On Mon, Oct 19, 2015 at 8:51 PM, punit vara wrote: > > On Mon, Oct 19, 2015 at 8:14 AM, Larry Finger > > wrote: > >> On 10/18/2015 09:00 PM, Greg KH wrote: > >>> > >>> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: > > One more thing I would like suggestion how can start switching this > driver to LIB80211 ,MAC80211 ? Which is the first file I should focus > ? Simultaneously I am trying to understand the flow of driver . I > would like to know the start point from where I can start doing small > changes. > >>> > >>> > >>> If you don't understand the wireless stack, I suggest you do some > >>> research on it first, converting a driver to the in-kernel stack is a > >>> _very_ difficult thing and not something that someone without any > >>> experience in this area is going to be able to do easily. > >> > >> > >> I second this suggestion. Your skill level is not nearly sufficient for > >> this > >> sort of task. Note that there is a group working on driver rtl8192su, which > >> should be able to replace rtl8712u. The participants are very highly > >> skilled > >> wireless developers; however, they are having trouble. The internals of the > >> Realtek chips are not revealed to anyone in any form other than the code > >> they release. > >> > >> Larry > >> > >> > > > > > > Thank you Larry ,Tillman , Greg for your valuable suggestions. I am > > interested to learn wireless stack .I have already read wireless wiki > > documentation , sort of rtl8712 code , cfg80112 APIs . Yeah I agree > > with you Greg and Larry that its _very_ difficult to thing to convert > > driver in kernel and also rtl8712 has more files compare to others. > > Anyway however difficult or tough it may be but I have to go through > > it once to become highly skilled or good engineer . I would give it a > > try even if I will fail I believe at least 1% of my knowledge will be > > improved . More suggestions are welcome. > > > > I have did > > > > git remote add gregkh > > http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > > > git pull gregkh > > > > git rebase my_local_branch > > > > I have got some conflicts .I can solve them but they are too many . I > > am trying to solve it . After that I will soon resend this patch. > > > > Thanks > > @Greg KH > I am working on linux-next .I have tried to rebase my local branch on > your staging tree but I am getting too many conflict .and I have tried > to clone your staging tree separately but due slow internet I am > unable to clone it fully . Is there any other way I can get your > staging tree by downloading ? git.kernel.org is the only location, sorry. Try starting with a "clean" version of Linus's tree and just add a branch for my tree, it should be quite a small download. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Mon, Oct 19, 2015 at 8:51 PM, punit vara wrote: > On Mon, Oct 19, 2015 at 8:14 AM, Larry Finger > wrote: >> On 10/18/2015 09:00 PM, Greg KH wrote: >>> >>> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: One more thing I would like suggestion how can start switching this driver to LIB80211 ,MAC80211 ? Which is the first file I should focus ? Simultaneously I am trying to understand the flow of driver . I would like to know the start point from where I can start doing small changes. >>> >>> >>> If you don't understand the wireless stack, I suggest you do some >>> research on it first, converting a driver to the in-kernel stack is a >>> _very_ difficult thing and not something that someone without any >>> experience in this area is going to be able to do easily. >> >> >> I second this suggestion. Your skill level is not nearly sufficient for this >> sort of task. Note that there is a group working on driver rtl8192su, which >> should be able to replace rtl8712u. The participants are very highly skilled >> wireless developers; however, they are having trouble. The internals of the >> Realtek chips are not revealed to anyone in any form other than the code >> they release. >> >> Larry >> >> > > > Thank you Larry ,Tillman , Greg for your valuable suggestions. I am > interested to learn wireless stack .I have already read wireless wiki > documentation , sort of rtl8712 code , cfg80112 APIs . Yeah I agree > with you Greg and Larry that its _very_ difficult to thing to convert > driver in kernel and also rtl8712 has more files compare to others. > Anyway however difficult or tough it may be but I have to go through > it once to become highly skilled or good engineer . I would give it a > try even if I will fail I believe at least 1% of my knowledge will be > improved . More suggestions are welcome. > > I have did > > git remote add gregkh > http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > git pull gregkh > > git rebase my_local_branch > > I have got some conflicts .I can solve them but they are too many . I > am trying to solve it . After that I will soon resend this patch. > > Thanks @Greg KH I am working on linux-next .I have tried to rebase my local branch on your staging tree but I am getting too many conflict .and I have tried to clone your staging tree separately but due slow internet I am unable to clone it fully . Is there any other way I can get your staging tree by downloading ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Fri, Oct 23, 2015 at 12:34:36AM +0530, punit vara wrote: > I am working on linux-next .I have tried to rebase my local branch on > your staging tree but I am getting too many conflict .and I have tried > to clone your staging tree separately but due slow internet I am > unable to clone it fully . Is there any other way I can get your > staging tree by downloading ? For a while, I had the worst internet of any kernel dev. I can help. :) Do you have any complete kernel git repository? If you download it one time then you just do a `git fetch` and `git checkout` after that. Never do a `git pull`. Downloading the linux kernel git repository the first time over bad internet is a huge headache because if you lose the connection then you have to restart. See if someone can post a .tar.gz of the kernel .git directory on a webpage for you then you can download it bit by bit using wget. Unpack it and do a `git reset --hard`. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Fri, Oct 23, 2015 at 12:34:36AM +0530, punit vara wrote: > On Mon, Oct 19, 2015 at 8:51 PM, punit varawrote: > > On Mon, Oct 19, 2015 at 8:14 AM, Larry Finger > > wrote: > >> On 10/18/2015 09:00 PM, Greg KH wrote: > >>> > >>> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: > > One more thing I would like suggestion how can start switching this > driver to LIB80211 ,MAC80211 ? Which is the first file I should focus > ? Simultaneously I am trying to understand the flow of driver . I > would like to know the start point from where I can start doing small > changes. > >>> > >>> > >>> If you don't understand the wireless stack, I suggest you do some > >>> research on it first, converting a driver to the in-kernel stack is a > >>> _very_ difficult thing and not something that someone without any > >>> experience in this area is going to be able to do easily. > >> > >> > >> I second this suggestion. Your skill level is not nearly sufficient for > >> this > >> sort of task. Note that there is a group working on driver rtl8192su, which > >> should be able to replace rtl8712u. The participants are very highly > >> skilled > >> wireless developers; however, they are having trouble. The internals of the > >> Realtek chips are not revealed to anyone in any form other than the code > >> they release. > >> > >> Larry > >> > >> > > > > > > Thank you Larry ,Tillman , Greg for your valuable suggestions. I am > > interested to learn wireless stack .I have already read wireless wiki > > documentation , sort of rtl8712 code , cfg80112 APIs . Yeah I agree > > with you Greg and Larry that its _very_ difficult to thing to convert > > driver in kernel and also rtl8712 has more files compare to others. > > Anyway however difficult or tough it may be but I have to go through > > it once to become highly skilled or good engineer . I would give it a > > try even if I will fail I believe at least 1% of my knowledge will be > > improved . More suggestions are welcome. > > > > I have did > > > > git remote add gregkh > > http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > > > git pull gregkh > > > > git rebase my_local_branch > > > > I have got some conflicts .I can solve them but they are too many . I > > am trying to solve it . After that I will soon resend this patch. > > > > Thanks > > @Greg KH > I am working on linux-next .I have tried to rebase my local branch on > your staging tree but I am getting too many conflict .and I have tried > to clone your staging tree separately but due slow internet I am > unable to clone it fully . Is there any other way I can get your > staging tree by downloading ? git.kernel.org is the only location, sorry. Try starting with a "clean" version of Linus's tree and just add a branch for my tree, it should be quite a small download. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Mon, Oct 19, 2015 at 8:51 PM, punit varawrote: > On Mon, Oct 19, 2015 at 8:14 AM, Larry Finger > wrote: >> On 10/18/2015 09:00 PM, Greg KH wrote: >>> >>> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: One more thing I would like suggestion how can start switching this driver to LIB80211 ,MAC80211 ? Which is the first file I should focus ? Simultaneously I am trying to understand the flow of driver . I would like to know the start point from where I can start doing small changes. >>> >>> >>> If you don't understand the wireless stack, I suggest you do some >>> research on it first, converting a driver to the in-kernel stack is a >>> _very_ difficult thing and not something that someone without any >>> experience in this area is going to be able to do easily. >> >> >> I second this suggestion. Your skill level is not nearly sufficient for this >> sort of task. Note that there is a group working on driver rtl8192su, which >> should be able to replace rtl8712u. The participants are very highly skilled >> wireless developers; however, they are having trouble. The internals of the >> Realtek chips are not revealed to anyone in any form other than the code >> they release. >> >> Larry >> >> > > > Thank you Larry ,Tillman , Greg for your valuable suggestions. I am > interested to learn wireless stack .I have already read wireless wiki > documentation , sort of rtl8712 code , cfg80112 APIs . Yeah I agree > with you Greg and Larry that its _very_ difficult to thing to convert > driver in kernel and also rtl8712 has more files compare to others. > Anyway however difficult or tough it may be but I have to go through > it once to become highly skilled or good engineer . I would give it a > try even if I will fail I believe at least 1% of my knowledge will be > improved . More suggestions are welcome. > > I have did > > git remote add gregkh > http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > git pull gregkh > > git rebase my_local_branch > > I have got some conflicts .I can solve them but they are too many . I > am trying to solve it . After that I will soon resend this patch. > > Thanks @Greg KH I am working on linux-next .I have tried to rebase my local branch on your staging tree but I am getting too many conflict .and I have tried to clone your staging tree separately but due slow internet I am unable to clone it fully . Is there any other way I can get your staging tree by downloading ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Fri, Oct 23, 2015 at 12:52 AM, Dan Carpenterwrote: > On Fri, Oct 23, 2015 at 12:34:36AM +0530, punit vara wrote: >> I am working on linux-next .I have tried to rebase my local branch on >> your staging tree but I am getting too many conflict .and I have tried >> to clone your staging tree separately but due slow internet I am >> unable to clone it fully . Is there any other way I can get your >> staging tree by downloading ? > > For a while, I had the worst internet of any kernel dev. I can help. :) > > Do you have any complete kernel git repository? If you download it one > time then you just do a `git fetch` and `git checkout` after that. > Never do a `git pull`. > > Downloading the linux kernel git repository the first time over bad > internet is a huge headache because if you lose the connection then you > have to restart. See if someone can post a .tar.gz of the kernel .git > directory on a webpage for you then you can download it bit by bit using > wget. Unpack it and do a `git reset --hard`. > > regards, > dan carpenter >>git branch -a master * my_local_branch old-local-1 remotes/gregkh/master remotes/gregkh/staging-linus remotes/gregkh/staging-next remotes/gregkh/staging-testing remotes/gregkh/test remotes/linux-next/akpm remotes/linux-next/akpm-base remotes/linux-next/master remotes/linux-next/stable remotes/origin/HEAD -> origin/master remotes/origin/master >>git remote -v gregkhhttp://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git (fetch) gregkhhttp://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git (push) linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git (fetch) linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git (push) originhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git (fetch) originhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git (push) Above is my situation I have performed >> commands in terminal. >>git checkout origin/master >>git checkout -b experimental origin/master >>git fetch gregkh Am I doing the right thing to get staging changes in my experimental branch ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
First fetch the changes, then check them out. $ git fetch git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next $ git checkout FETCH_HEAD regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Mon, Oct 19, 2015 at 8:14 AM, Larry Finger wrote: > On 10/18/2015 09:00 PM, Greg KH wrote: >> >> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: >>> >>> One more thing I would like suggestion how can start switching this >>> driver to LIB80211 ,MAC80211 ? Which is the first file I should focus >>> ? Simultaneously I am trying to understand the flow of driver . I >>> would like to know the start point from where I can start doing small >>> changes. >> >> >> If you don't understand the wireless stack, I suggest you do some >> research on it first, converting a driver to the in-kernel stack is a >> _very_ difficult thing and not something that someone without any >> experience in this area is going to be able to do easily. > > > I second this suggestion. Your skill level is not nearly sufficient for this > sort of task. Note that there is a group working on driver rtl8192su, which > should be able to replace rtl8712u. The participants are very highly skilled > wireless developers; however, they are having trouble. The internals of the > Realtek chips are not revealed to anyone in any form other than the code > they release. > > Larry > > Thank you Larry ,Tillman , Greg for your valuable suggestions. I am interested to learn wireless stack .I have already read wireless wiki documentation , sort of rtl8712 code , cfg80112 APIs . Yeah I agree with you Greg and Larry that its _very_ difficult to thing to convert driver in kernel and also rtl8712 has more files compare to others. Anyway however difficult or tough it may be but I have to go through it once to become highly skilled or good engineer . I would give it a try even if I will fail I believe at least 1% of my knowledge will be improved . More suggestions are welcome. I have did git remote add gregkh http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git git pull gregkh git rebase my_local_branch I have got some conflicts .I can solve them but they are too many . I am trying to solve it . After that I will soon resend this patch. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Mon, Oct 19, 2015 at 8:14 AM, Larry Fingerwrote: > On 10/18/2015 09:00 PM, Greg KH wrote: >> >> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: >>> >>> One more thing I would like suggestion how can start switching this >>> driver to LIB80211 ,MAC80211 ? Which is the first file I should focus >>> ? Simultaneously I am trying to understand the flow of driver . I >>> would like to know the start point from where I can start doing small >>> changes. >> >> >> If you don't understand the wireless stack, I suggest you do some >> research on it first, converting a driver to the in-kernel stack is a >> _very_ difficult thing and not something that someone without any >> experience in this area is going to be able to do easily. > > > I second this suggestion. Your skill level is not nearly sufficient for this > sort of task. Note that there is a group working on driver rtl8192su, which > should be able to replace rtl8712u. The participants are very highly skilled > wireless developers; however, they are having trouble. The internals of the > Realtek chips are not revealed to anyone in any form other than the code > they release. > > Larry > > Thank you Larry ,Tillman , Greg for your valuable suggestions. I am interested to learn wireless stack .I have already read wireless wiki documentation , sort of rtl8712 code , cfg80112 APIs . Yeah I agree with you Greg and Larry that its _very_ difficult to thing to convert driver in kernel and also rtl8712 has more files compare to others. Anyway however difficult or tough it may be but I have to go through it once to become highly skilled or good engineer . I would give it a try even if I will fail I believe at least 1% of my knowledge will be improved . More suggestions are welcome. I have did git remote add gregkh http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git git pull gregkh git rebase my_local_branch I have got some conflicts .I can solve them but they are too many . I am trying to solve it . After that I will soon resend this patch. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On 10/18/2015 09:00 PM, Greg KH wrote: On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: One more thing I would like suggestion how can start switching this driver to LIB80211 ,MAC80211 ? Which is the first file I should focus ? Simultaneously I am trying to understand the flow of driver . I would like to know the start point from where I can start doing small changes. If you don't understand the wireless stack, I suggest you do some research on it first, converting a driver to the in-kernel stack is a _very_ difficult thing and not something that someone without any experience in this area is going to be able to do easily. I second this suggestion. Your skill level is not nearly sufficient for this sort of task. Note that there is a group working on driver rtl8192su, which should be able to replace rtl8712u. The participants are very highly skilled wireless developers; however, they are having trouble. The internals of the Realtek chips are not revealed to anyone in any form other than the code they release. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: > On Sat, Oct 17, 2015 at 10:46 AM, Greg KH wrote: > > On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: > >> Put constant on the right side of a test.Problem found using checkpatch: > >> > >> Warning:Comparisons should place the constant on the right side of the test > >> > >> Signed-off-by: Punit Vara > >> --- > >> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 > >> 1 file changed, 8 insertions(+), 8 deletions(-) > > > > Didn't apply to my tree :( > In this case what should I do ? Should I do git reset , git pull and > then do changes on latest tree ? That depends on your workflow, how about pulling and then rebase your branch on mine? That's the easiest workflow to use. > One more thing I would like suggestion how can start switching this > driver to LIB80211 ,MAC80211 ? Which is the first file I should focus > ? Simultaneously I am trying to understand the flow of driver . I > would like to know the start point from where I can start doing small > changes. If you don't understand the wireless stack, I suggest you do some research on it first, converting a driver to the in-kernel stack is a _very_ difficult thing and not something that someone without any experience in this area is going to be able to do easily. good luck! greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Sun, Oct 18, 2015 at 08:54:57PM +0200, Tillmann Heidsieck wrote: > Hi, [...] > Greg is probably trying to apply this series to the staging-next branch of > his staging tree[0] > so you need to clone that one, or add it as an additional remote[1] to your > clone of the kernel tree (much better option IMHO). After this you need to > rebase[2] your changes onto the stating-next branch, fix up all conflicts in > your code, and resend the patch. > > I hope this helps > > Tillmann > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > [1] https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes > [2] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git ups, got bitten by my missing c'n'p prowess [2] https://www.kernel.org/pub/software/scm/git/docs/git-rebase.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
Hi, On 2015-10-18 08:32, punit vara wrote: On Sat, Oct 17, 2015 at 10:46 AM, Greg KH wrote: On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: Put constant on the right side of a test.Problem found using checkpatch: Warning:Comparisons should place the constant on the right side of the test Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Didn't apply to my tree :( In this case what should I do ? Should I do git reset , git pull and then do changes on latest tree ? Greg is probably trying to apply this series to the staging-next branch of his staging tree[0] so you need to clone that one, or add it as an additional remote[1] to your clone of the kernel tree (much better option IMHO). After this you need to rebase[2] your changes onto the stating-next branch, fix up all conflicts in your code, and resend the patch. I hope this helps Tillmann [0] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git [1] https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes [2] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Sat, Oct 17, 2015 at 10:46 AM, Greg KH wrote: > On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: >> Put constant on the right side of a test.Problem found using checkpatch: >> >> Warning:Comparisons should place the constant on the right side of the test >> >> Signed-off-by: Punit Vara >> --- >> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 >> 1 file changed, 8 insertions(+), 8 deletions(-) > > Didn't apply to my tree :( In this case what should I do ? Should I do git reset , git pull and then do changes on latest tree ? One more thing I would like suggestion how can start switching this driver to LIB80211 ,MAC80211 ? Which is the first file I should focus ? Simultaneously I am trying to understand the flow of driver . I would like to know the start point from where I can start doing small changes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On 10/18/2015 09:00 PM, Greg KH wrote: On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: One more thing I would like suggestion how can start switching this driver to LIB80211 ,MAC80211 ? Which is the first file I should focus ? Simultaneously I am trying to understand the flow of driver . I would like to know the start point from where I can start doing small changes. If you don't understand the wireless stack, I suggest you do some research on it first, converting a driver to the in-kernel stack is a _very_ difficult thing and not something that someone without any experience in this area is going to be able to do easily. I second this suggestion. Your skill level is not nearly sufficient for this sort of task. Note that there is a group working on driver rtl8192su, which should be able to replace rtl8712u. The participants are very highly skilled wireless developers; however, they are having trouble. The internals of the Realtek chips are not revealed to anyone in any form other than the code they release. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: > On Sat, Oct 17, 2015 at 10:46 AM, Greg KHwrote: > > On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: > >> Put constant on the right side of a test.Problem found using checkpatch: > >> > >> Warning:Comparisons should place the constant on the right side of the test > >> > >> Signed-off-by: Punit Vara > >> --- > >> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 > >> 1 file changed, 8 insertions(+), 8 deletions(-) > > > > Didn't apply to my tree :( > In this case what should I do ? Should I do git reset , git pull and > then do changes on latest tree ? That depends on your workflow, how about pulling and then rebase your branch on mine? That's the easiest workflow to use. > One more thing I would like suggestion how can start switching this > driver to LIB80211 ,MAC80211 ? Which is the first file I should focus > ? Simultaneously I am trying to understand the flow of driver . I > would like to know the start point from where I can start doing small > changes. If you don't understand the wireless stack, I suggest you do some research on it first, converting a driver to the in-kernel stack is a _very_ difficult thing and not something that someone without any experience in this area is going to be able to do easily. good luck! greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
Hi, On 2015-10-18 08:32, punit vara wrote: On Sat, Oct 17, 2015 at 10:46 AM, Greg KHwrote: On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: Put constant on the right side of a test.Problem found using checkpatch: Warning:Comparisons should place the constant on the right side of the test Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Didn't apply to my tree :( In this case what should I do ? Should I do git reset , git pull and then do changes on latest tree ? Greg is probably trying to apply this series to the staging-next branch of his staging tree[0] so you need to clone that one, or add it as an additional remote[1] to your clone of the kernel tree (much better option IMHO). After this you need to rebase[2] your changes onto the stating-next branch, fix up all conflicts in your code, and resend the patch. I hope this helps Tillmann [0] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git [1] https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes [2] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Sun, Oct 18, 2015 at 08:54:57PM +0200, Tillmann Heidsieck wrote: > Hi, [...] > Greg is probably trying to apply this series to the staging-next branch of > his staging tree[0] > so you need to clone that one, or add it as an additional remote[1] to your > clone of the kernel tree (much better option IMHO). After this you need to > rebase[2] your changes onto the stating-next branch, fix up all conflicts in > your code, and resend the patch. > > I hope this helps > > Tillmann > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > [1] https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes > [2] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git ups, got bitten by my missing c'n'p prowess [2] https://www.kernel.org/pub/software/scm/git/docs/git-rebase.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Sat, Oct 17, 2015 at 10:46 AM, Greg KHwrote: > On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: >> Put constant on the right side of a test.Problem found using checkpatch: >> >> Warning:Comparisons should place the constant on the right side of the test >> >> Signed-off-by: Punit Vara >> --- >> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 >> 1 file changed, 8 insertions(+), 8 deletions(-) > > Didn't apply to my tree :( In this case what should I do ? Should I do git reset , git pull and then do changes on latest tree ? One more thing I would like suggestion how can start switching this driver to LIB80211 ,MAC80211 ? Which is the first file I should focus ? Simultaneously I am trying to understand the flow of driver . I would like to know the start point from where I can start doing small changes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: > Put constant on the right side of a test.Problem found using checkpatch: > > Warning:Comparisons should place the constant on the right side of the test > > Signed-off-by: Punit Vara > --- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Didn't apply to my tree :( -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: > Put constant on the right side of a test.Problem found using checkpatch: > > Warning:Comparisons should place the constant on the right side of the test > > Signed-off-by: Punit Vara> --- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Didn't apply to my tree :( -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
Put constant on the right side of a test.Problem found using checkpatch: Warning:Comparisons should place the constant on the right side of the test Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c index fc1028a..e9852ae 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c @@ -959,7 +959,7 @@ static int r871x_wx_set_priv(struct net_device *dev, if (IS_ERR(ext)) return PTR_ERR(ext); - if (0 == strcasecmp(ext, "RSSI")) { + if (strcasecmp(ext, "RSSI") == 0) { /*Return received signal strength indicator in -db for */ /* current AP */ /* Rssi xx */ @@ -976,7 +976,7 @@ static int r871x_wx_set_priv(struct net_device *dev, } else { sprintf(ext, "OK"); } - } else if (0 == strcasecmp(ext, "LINKSPEED")) { + } else if (strcasecmp(ext, "LINKSPEED") == 0) { /*Return link speed in MBPS */ /*LinkSpeed xx */ union iwreq_data wrqd; @@ -984,30 +984,30 @@ static int r871x_wx_set_priv(struct net_device *dev, int mbps; ret_inner = r8711_wx_get_rate(dev, info, , extra); - if (0 != ret_inner) + if (ret_inner != 0) mbps = 0; else mbps = wrqd.bitrate.value / 100; sprintf(ext, "LINKSPEED %d", mbps); - } else if (0 == strcasecmp(ext, "MACADDR")) { + } else if (strcasecmp(ext, "MACADDR") == 0) { /*Return mac address of the station */ /* Macaddr = xx:xx:xx:xx:xx:xx */ sprintf(ext, "MACADDR = %pM", dev->dev_addr); - } else if (0 == strcasecmp(ext, "SCAN-ACTIVE")) { + } else if (strcasecmp(ext, "SCAN-ACTIVE") == 0) { /*Set scan type to active */ /*OK if successful */ struct mlme_priv *pmlmepriv = >mlmepriv; pmlmepriv->passive_mode = 1; sprintf(ext, "OK"); - } else if (0 == strcasecmp(ext, "SCAN-PASSIVE")) { + } else if (strcasecmp(ext, "SCAN-PASSIVE") == 0) { /*Set scan type to passive */ /*OK if successful */ struct mlme_priv *pmlmepriv = >mlmepriv; pmlmepriv->passive_mode = 0; sprintf(ext, "OK"); - } else if (0 == strncmp(ext, "DCE-E", 5)) { + } else if (strncmp(ext, "DCE-E", 5) == 0) { /*Set scan type to passive */ /*OK if successful */ r8712_disconnectCtrlEx_cmd(padapter @@ -1017,7 +1017,7 @@ static int r871x_wx_set_priv(struct net_device *dev, , 5000 /*u32 firstStageTO */ ); sprintf(ext, "OK"); - } else if (0 == strncmp(ext, "DCE-D", 5)) { + } else if (strncmp(ext, "DCE-D", 5) == 0) { /*Set scan type to passive */ /*OK if successfu */ r8712_disconnectCtrlEx_cmd(padapter -- 2.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
Put constant on the right side of a test.Problem found using checkpatch: Warning:Comparisons should place the constant on the right side of the test Signed-off-by: Punit Vara--- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c index fc1028a..e9852ae 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c @@ -959,7 +959,7 @@ static int r871x_wx_set_priv(struct net_device *dev, if (IS_ERR(ext)) return PTR_ERR(ext); - if (0 == strcasecmp(ext, "RSSI")) { + if (strcasecmp(ext, "RSSI") == 0) { /*Return received signal strength indicator in -db for */ /* current AP */ /* Rssi xx */ @@ -976,7 +976,7 @@ static int r871x_wx_set_priv(struct net_device *dev, } else { sprintf(ext, "OK"); } - } else if (0 == strcasecmp(ext, "LINKSPEED")) { + } else if (strcasecmp(ext, "LINKSPEED") == 0) { /*Return link speed in MBPS */ /*LinkSpeed xx */ union iwreq_data wrqd; @@ -984,30 +984,30 @@ static int r871x_wx_set_priv(struct net_device *dev, int mbps; ret_inner = r8711_wx_get_rate(dev, info, , extra); - if (0 != ret_inner) + if (ret_inner != 0) mbps = 0; else mbps = wrqd.bitrate.value / 100; sprintf(ext, "LINKSPEED %d", mbps); - } else if (0 == strcasecmp(ext, "MACADDR")) { + } else if (strcasecmp(ext, "MACADDR") == 0) { /*Return mac address of the station */ /* Macaddr = xx:xx:xx:xx:xx:xx */ sprintf(ext, "MACADDR = %pM", dev->dev_addr); - } else if (0 == strcasecmp(ext, "SCAN-ACTIVE")) { + } else if (strcasecmp(ext, "SCAN-ACTIVE") == 0) { /*Set scan type to active */ /*OK if successful */ struct mlme_priv *pmlmepriv = >mlmepriv; pmlmepriv->passive_mode = 1; sprintf(ext, "OK"); - } else if (0 == strcasecmp(ext, "SCAN-PASSIVE")) { + } else if (strcasecmp(ext, "SCAN-PASSIVE") == 0) { /*Set scan type to passive */ /*OK if successful */ struct mlme_priv *pmlmepriv = >mlmepriv; pmlmepriv->passive_mode = 0; sprintf(ext, "OK"); - } else if (0 == strncmp(ext, "DCE-E", 5)) { + } else if (strncmp(ext, "DCE-E", 5) == 0) { /*Set scan type to passive */ /*OK if successful */ r8712_disconnectCtrlEx_cmd(padapter @@ -1017,7 +1017,7 @@ static int r871x_wx_set_priv(struct net_device *dev, , 5000 /*u32 firstStageTO */ ); sprintf(ext, "OK"); - } else if (0 == strncmp(ext, "DCE-D", 5)) { + } else if (strncmp(ext, "DCE-D", 5) == 0) { /*Set scan type to passive */ /*OK if successfu */ r8712_disconnectCtrlEx_cmd(padapter -- 2.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/