Re: [PATCH v2 4/4] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-08-11 Thread Mike Kravetz
On 8/11/20 12:24 AM, Michal Hocko wrote: > > My opinion is that the warning is too late to add at this stage. It > would have been much better if the user interface has provided a > reasonable feedback on how much the request was sucessful. But this > is not the case (except for few error cases)

Re: [PATCH v2 4/4] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-08-11 Thread Michal Hocko
On Mon 10-08-20 20:35:25, Mike Kravetz wrote: > Cc: Michal > > On 8/10/20 7:11 PM, Baoquan He wrote: > > Hi Mike, > > > > On 07/23/20 at 11:21am, Mike Kravetz wrote: > >> On 7/23/20 2:11 AM, Baoquan He wrote: > > ... > But is kernel expected to warn for all such situations where the user >

Re: [PATCH v2 4/4] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-08-10 Thread Mike Kravetz
Cc: Michal On 8/10/20 7:11 PM, Baoquan He wrote: > Hi Mike, > > On 07/23/20 at 11:21am, Mike Kravetz wrote: >> On 7/23/20 2:11 AM, Baoquan He wrote: > ... But is kernel expected to warn for all such situations where the user requested resources could not be allocated completely ?

Re: [PATCH v2 4/4] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-08-10 Thread Baoquan He
Hi Mike, On 07/23/20 at 11:21am, Mike Kravetz wrote: > On 7/23/20 2:11 AM, Baoquan He wrote: ... > >> But is kernel expected to warn for all such situations where the user > >> requested resources could not be allocated completely ? Otherwise, it > >> does not make sense to add an warning for

Re: [PATCH v2 4/4] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-07-24 Thread Baoquan He
On 07/23/20 at 11:21am, Mike Kravetz wrote: > On 7/23/20 2:11 AM, Baoquan He wrote: > > On 07/23/20 at 11:46am, Anshuman Khandual wrote: > >> > >> > >> On 07/23/2020 08:52 AM, Baoquan He wrote: > >>> A customer complained that no message is logged when the number of > >>> persistent huge

Re: [PATCH v2 4/4] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-07-23 Thread Mike Kravetz
On 7/23/20 2:11 AM, Baoquan He wrote: > On 07/23/20 at 11:46am, Anshuman Khandual wrote: >> >> >> On 07/23/2020 08:52 AM, Baoquan He wrote: >>> A customer complained that no message is logged wh en the number of >>> persistent huge pages is not changed to the exact value written to >>> the sysfs

Re: [PATCH v2 4/4] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-07-23 Thread Baoquan He
On 07/23/20 at 11:46am, Anshuman Khandual wrote: > > > On 07/23/2020 08:52 AM, Baoquan He wrote: > > A customer complained that no message is logged wh en the number of > > persistent huge pages is not changed to the exact value written to > > the sysfs or proc nr_hugepages file. > > > > In

Re: [PATCH v2 4/4] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-07-23 Thread Anshuman Khandual
On 07/23/2020 08:52 AM, Baoquan He wrote: > A customer complained that no message is logged when the number of > persistent huge pages is not changed to the exact value written to > the sysfs or proc nr_hugepages file. > > In the current code, a best effort is made to satisfy requests made

[PATCH v2 4/4] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-07-22 Thread Baoquan He
A customer complained that no message is logged when the number of persistent huge pages is not changed to the exact value written to the sysfs or proc nr_hugepages file. In the current code, a best effort is made to satisfy requests made via the nr_hugepages file. However, requests may be only