Re: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-18 Thread Ananth N Mavinakayanahalli
On Tue, Dec 18, 2012 at 08:10:13PM +0100, Oleg Nesterov wrote: > On 12/18, Ananth N Mavinakayanahalli wrote: > > > > On Fri, Dec 14, 2012 at 09:02:41PM +0100, Oleg Nesterov wrote: > > > > > > > > - uprobe_restore_context_sstep(>autask); > > > > + uprobe_restore_context_sstep(>autask,

Re: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-18 Thread Oleg Nesterov
On 12/18, Ananth N Mavinakayanahalli wrote: > > On Fri, Dec 14, 2012 at 09:02:41PM +0100, Oleg Nesterov wrote: > > > > > > - uprobe_restore_context_sstep(>autask); > > > + uprobe_restore_context_sstep(>autask, regs); > > > > I am not sure ppc needs this, but note that x86 does a bit more. > > > >

Re: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-18 Thread Oleg Nesterov
On 12/18, Ananth N Mavinakayanahalli wrote: On Fri, Dec 14, 2012 at 09:02:41PM +0100, Oleg Nesterov wrote: - uprobe_restore_context_sstep(utask-autask); + uprobe_restore_context_sstep(utask-autask, regs); I am not sure ppc needs this, but note that x86 does a bit more. Not only

Re: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-18 Thread Ananth N Mavinakayanahalli
On Tue, Dec 18, 2012 at 08:10:13PM +0100, Oleg Nesterov wrote: On 12/18, Ananth N Mavinakayanahalli wrote: On Fri, Dec 14, 2012 at 09:02:41PM +0100, Oleg Nesterov wrote: - uprobe_restore_context_sstep(utask-autask); + uprobe_restore_context_sstep(utask-autask, regs);

Re: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-17 Thread Ananth N Mavinakayanahalli
On Fri, Dec 14, 2012 at 09:02:41PM +0100, Oleg Nesterov wrote: > On 12/03, Suzuki K. Poulose wrote: > > > > Replace the ptrace helpers with the powerpc generic routines to > > enable/disable single step. We save/restore the MSR (and DCBR for BookE) > > across for the operation. We don't have to

Re: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-17 Thread Suzuki K. Poulose
On 12/15/2012 01:32 AM, Oleg Nesterov wrote: On 12/03, Suzuki K. Poulose wrote: Replace the ptrace helpers with the powerpc generic routines to enable/disable single step. We save/restore the MSR (and DCBR for BookE) across for the operation. We don't have to disable the single step, as

Re: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-17 Thread Suzuki K. Poulose
On 12/15/2012 01:32 AM, Oleg Nesterov wrote: On 12/03, Suzuki K. Poulose wrote: Replace the ptrace helpers with the powerpc generic routines to enable/disable single step. We save/restore the MSR (and DCBR for BookE) across for the operation. We don't have to disable the single step, as

Re: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-17 Thread Ananth N Mavinakayanahalli
On Fri, Dec 14, 2012 at 09:02:41PM +0100, Oleg Nesterov wrote: On 12/03, Suzuki K. Poulose wrote: Replace the ptrace helpers with the powerpc generic routines to enable/disable single step. We save/restore the MSR (and DCBR for BookE) across for the operation. We don't have to disable the

Re: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-14 Thread Oleg Nesterov
On 12/03, Suzuki K. Poulose wrote: > > Replace the ptrace helpers with the powerpc generic routines to > enable/disable single step. We save/restore the MSR (and DCBR for BookE) > across for the operation. We don't have to disable the single step, > as restoring the MSR/DBCR would restore the

Re: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-14 Thread Oleg Nesterov
On 12/03, Suzuki K. Poulose wrote: Replace the ptrace helpers with the powerpc generic routines to enable/disable single step. We save/restore the MSR (and DCBR for BookE) across for the operation. We don't have to disable the single step, as restoring the MSR/DBCR would restore the previous

Re: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-10 Thread Ananth N Mavinakayanahalli
On Mon, Dec 03, 2012 at 08:40:32PM +0530, Suzuki K. Poulose wrote: > From: Suzuki K. Poulose > > Replace the ptrace helpers with the powerpc generic routines to > enable/disable single step. We save/restore the MSR (and DCBR for BookE) > across for the operation. We don't have to disable the

Re: [PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-10 Thread Ananth N Mavinakayanahalli
On Mon, Dec 03, 2012 at 08:40:32PM +0530, Suzuki K. Poulose wrote: From: Suzuki K. Poulose suz...@in.ibm.com Replace the ptrace helpers with the powerpc generic routines to enable/disable single step. We save/restore the MSR (and DCBR for BookE) across for the operation. We don't have to

[PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-03 Thread Suzuki K. Poulose
From: Suzuki K. Poulose Replace the ptrace helpers with the powerpc generic routines to enable/disable single step. We save/restore the MSR (and DCBR for BookE) across for the operation. We don't have to disable the single step, as restoring the MSR/DBCR would restore the previous state.

[PATCH v2 4/4] uprobes/powerpc: Make use of generic routines to enable single step

2012-12-03 Thread Suzuki K. Poulose
From: Suzuki K. Poulose suz...@in.ibm.com Replace the ptrace helpers with the powerpc generic routines to enable/disable single step. We save/restore the MSR (and DCBR for BookE) across for the operation. We don't have to disable the single step, as restoring the MSR/DBCR would restore the