Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-20 Thread kemi
On 2017年12月20日 23:58, Christopher Lameter wrote: > On Wed, 20 Dec 2017, kemi wrote: > >>> You are making numastats special and I yet haven't heard any sounds >>> arguments for that. But that should be discussed in the respective >>> patch. >>> >> >> That is because we have much larger threshold

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-20 Thread kemi
On 2017年12月20日 23:58, Christopher Lameter wrote: > On Wed, 20 Dec 2017, kemi wrote: > >>> You are making numastats special and I yet haven't heard any sounds >>> arguments for that. But that should be discussed in the respective >>> patch. >>> >> >> That is because we have much larger threshold

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-20 Thread Christopher Lameter
On Wed, 20 Dec 2017, kemi wrote: > > You are making numastats special and I yet haven't heard any sounds > > arguments for that. But that should be discussed in the respective > > patch. > > > > That is because we have much larger threshold size for NUMA counters, that > means larger >

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-20 Thread Christopher Lameter
On Wed, 20 Dec 2017, kemi wrote: > > You are making numastats special and I yet haven't heard any sounds > > arguments for that. But that should be discussed in the respective > > patch. > > > > That is because we have much larger threshold size for NUMA counters, that > means larger >

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-20 Thread kemi
On 2017年12月20日 18:06, Michal Hocko wrote: > On Wed 20-12-17 14:07:35, kemi wrote: >> >> >> On 2017年12月19日 20:43, Michal Hocko wrote: >>> On Tue 19-12-17 14:39:25, Kemi Wang wrote: To avoid deviation, this patch uses node_page_state_snapshot instead of node_page_state for node page

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-20 Thread kemi
On 2017年12月20日 18:06, Michal Hocko wrote: > On Wed 20-12-17 14:07:35, kemi wrote: >> >> >> On 2017年12月19日 20:43, Michal Hocko wrote: >>> On Tue 19-12-17 14:39:25, Kemi Wang wrote: To avoid deviation, this patch uses node_page_state_snapshot instead of node_page_state for node page

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-20 Thread Michal Hocko
On Wed 20-12-17 14:07:35, kemi wrote: > > > On 2017年12月19日 20:43, Michal Hocko wrote: > > On Tue 19-12-17 14:39:25, Kemi Wang wrote: > >> To avoid deviation, this patch uses node_page_state_snapshot instead of > >> node_page_state for node page stats query. > >> e.g. cat /proc/zoneinfo > >>

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-20 Thread Michal Hocko
On Wed 20-12-17 14:07:35, kemi wrote: > > > On 2017年12月19日 20:43, Michal Hocko wrote: > > On Tue 19-12-17 14:39:25, Kemi Wang wrote: > >> To avoid deviation, this patch uses node_page_state_snapshot instead of > >> node_page_state for node page stats query. > >> e.g. cat /proc/zoneinfo > >>

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-19 Thread kemi
On 2017年12月19日 20:43, Michal Hocko wrote: > On Tue 19-12-17 14:39:25, Kemi Wang wrote: >> To avoid deviation, this patch uses node_page_state_snapshot instead of >> node_page_state for node page stats query. >> e.g. cat /proc/zoneinfo >> cat /sys/devices/system/node/node*/vmstat >> cat

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-19 Thread kemi
On 2017年12月19日 20:43, Michal Hocko wrote: > On Tue 19-12-17 14:39:25, Kemi Wang wrote: >> To avoid deviation, this patch uses node_page_state_snapshot instead of >> node_page_state for node page stats query. >> e.g. cat /proc/zoneinfo >> cat /sys/devices/system/node/node*/vmstat >> cat

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-19 Thread Michal Hocko
On Tue 19-12-17 14:39:25, Kemi Wang wrote: > To avoid deviation, this patch uses node_page_state_snapshot instead of > node_page_state for node page stats query. > e.g. cat /proc/zoneinfo > cat /sys/devices/system/node/node*/vmstat > cat /sys/devices/system/node/node*/numastat > > As it

Re: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-19 Thread Michal Hocko
On Tue 19-12-17 14:39:25, Kemi Wang wrote: > To avoid deviation, this patch uses node_page_state_snapshot instead of > node_page_state for node page stats query. > e.g. cat /proc/zoneinfo > cat /sys/devices/system/node/node*/vmstat > cat /sys/devices/system/node/node*/numastat > > As it

[PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-18 Thread Kemi Wang
To avoid deviation, this patch uses node_page_state_snapshot instead of node_page_state for node page stats query. e.g. cat /proc/zoneinfo cat /sys/devices/system/node/node*/vmstat cat /sys/devices/system/node/node*/numastat As it is a slow path and would not be read frequently, I would

[PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation

2017-12-18 Thread Kemi Wang
To avoid deviation, this patch uses node_page_state_snapshot instead of node_page_state for node page stats query. e.g. cat /proc/zoneinfo cat /sys/devices/system/node/node*/vmstat cat /sys/devices/system/node/node*/numastat As it is a slow path and would not be read frequently, I would