Re: [PATCH v2 4/6] mm/page_ext: rename offset to index

[Vlastimil Babka]

On 08/16/2016 04:51 AM, js1...@gmail.com wrote:

From: Joonsoo Kim 

Here, 'offset' means entry index in page_ext array. Following patch
will use 'offset' for field offset in each entry so rename current
'offset' to prevent confusion.

Signed-off-by: Joonsoo Kim 


Acked-by: Vlastimil Babka 

Re: [PATCH v2 4/6] mm/page_ext: rename offset to index

[Vlastimil Babka]

On 08/16/2016 04:51 AM, js1...@gmail.com wrote:

From: Joonsoo Kim 

Here, 'offset' means entry index in page_ext array. Following patch
will use 'offset' for field offset in each entry so rename current
'offset' to prevent confusion.

Signed-off-by: Joonsoo Kim 


Acked-by: Vlastimil Babka 

[PATCH v2 4/6] mm/page_ext: rename offset to index

[js1304]

From: Joonsoo Kim 

Here, 'offset' means entry index in page_ext array. Following patch
will use 'offset' for field offset in each entry so rename current
'offset' to prevent confusion.

Signed-off-by: Joonsoo Kim 
---
 mm/page_ext.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/page_ext.c b/mm/page_ext.c
index 44a4c02..1629282 100644
--- a/mm/page_ext.c
+++ b/mm/page_ext.c
@@ -102,7 +102,7 @@ void __meminit pgdat_page_ext_init(struct pglist_data 
*pgdat)
 struct page_ext *lookup_page_ext(struct page *page)
 {
unsigned long pfn = page_to_pfn(page);
-   unsigned long offset;
+   unsigned long index;
struct page_ext *base;
 
base = NODE_DATA(page_to_nid(page))->node_page_ext;
@@ -119,9 +119,9 @@ struct page_ext *lookup_page_ext(struct page *page)
if (unlikely(!base))
return NULL;
 #endif
-   offset = pfn - round_down(node_start_pfn(page_to_nid(page)),
+   index = pfn - round_down(node_start_pfn(page_to_nid(page)),
MAX_ORDER_NR_PAGES);
-   return base + offset;
+   return base + index;
 }
 
 static int __init alloc_node_page_ext(int nid)
-- 
1.9.1

[PATCH v2 4/6] mm/page_ext: rename offset to index

[js1304]

From: Joonsoo Kim 

Here, 'offset' means entry index in page_ext array. Following patch
will use 'offset' for field offset in each entry so rename current
'offset' to prevent confusion.

Signed-off-by: Joonsoo Kim 
---
 mm/page_ext.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/page_ext.c b/mm/page_ext.c
index 44a4c02..1629282 100644
--- a/mm/page_ext.c
+++ b/mm/page_ext.c
@@ -102,7 +102,7 @@ void __meminit pgdat_page_ext_init(struct pglist_data 
*pgdat)
 struct page_ext *lookup_page_ext(struct page *page)
 {
unsigned long pfn = page_to_pfn(page);
-   unsigned long offset;
+   unsigned long index;
struct page_ext *base;
 
base = NODE_DATA(page_to_nid(page))->node_page_ext;
@@ -119,9 +119,9 @@ struct page_ext *lookup_page_ext(struct page *page)
if (unlikely(!base))
return NULL;
 #endif
-   offset = pfn - round_down(node_start_pfn(page_to_nid(page)),
+   index = pfn - round_down(node_start_pfn(page_to_nid(page)),
MAX_ORDER_NR_PAGES);
-   return base + offset;
+   return base + index;
 }
 
 static int __init alloc_node_page_ext(int nid)
-- 
1.9.1