Re: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Sascha Hauer
On Wed, Dec 06, 2017 at 10:17:06AM +, Patrick Brünn wrote: > >From: Sascha Hauer [mailto:s.ha...@pengutronix.de] > >Sent: Mittwoch, 6. Dezember 2017 09:36 > >On Tue, Dec 05, 2017 at 03:06:46PM +0100, linux-kernel-...@beckhoff.com > >wrote: > >> +static int mxc_rtc_wait_for_flag(void *__iomem

Re: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Sascha Hauer
On Wed, Dec 06, 2017 at 10:17:06AM +, Patrick Brünn wrote: > >From: Sascha Hauer [mailto:s.ha...@pengutronix.de] > >Sent: Mittwoch, 6. Dezember 2017 09:36 > >On Tue, Dec 05, 2017 at 03:06:46PM +0100, linux-kernel-...@beckhoff.com > >wrote: > >> +static int mxc_rtc_wait_for_flag(void *__iomem

Re: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Alexandre Belloni
On 05/12/2017 at 15:06:46 +0100, linux-kernel-...@beckhoff.com wrote: > +/* This function is the RTC interrupt service routine. */ > +static irqreturn_t mxc_rtc_interrupt(int irq, void *dev_id) > +{ > + struct platform_device *pdev = dev_id; > + struct mxc_rtc_data *pdata =

Re: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Alexandre Belloni
On 05/12/2017 at 15:06:46 +0100, linux-kernel-...@beckhoff.com wrote: > +/* This function is the RTC interrupt service routine. */ > +static irqreturn_t mxc_rtc_interrupt(int irq, void *dev_id) > +{ > + struct platform_device *pdev = dev_id; > + struct mxc_rtc_data *pdata =

RE: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Patrick Brünn
>From: Sascha Hauer [mailto:s.ha...@pengutronix.de] >Sent: Mittwoch, 6. Dezember 2017 09:36 >On Tue, Dec 05, 2017 at 03:06:46PM +0100, linux-kernel-...@beckhoff.com >wrote: >> +static int mxc_rtc_write_alarm_locked(struct mxc_rtc_data *const pdata, >> + struct

RE: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Patrick Brünn
>From: Sascha Hauer [mailto:s.ha...@pengutronix.de] >Sent: Mittwoch, 6. Dezember 2017 09:36 >On Tue, Dec 05, 2017 at 03:06:46PM +0100, linux-kernel-...@beckhoff.com >wrote: >> +static int mxc_rtc_write_alarm_locked(struct mxc_rtc_data *const pdata, >> + struct

RE: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Patrick Brünn
>From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] >Sent: Mittwoch, 6. Dezember 2017 09:58 >On 06/12/2017 at 09:36:18 +0100, Sascha Hauer wrote: >> > +/* >> > + * This function updates the RTC alarm registers and then clears all the >> > + * interrupt status bits. >> > + * The

RE: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Patrick Brünn
>From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] >Sent: Mittwoch, 6. Dezember 2017 09:58 >On 06/12/2017 at 09:36:18 +0100, Sascha Hauer wrote: >> > +/* >> > + * This function updates the RTC alarm registers and then clears all the >> > + * interrupt status bits. >> > + * The

Re: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Alexandre Belloni
On 06/12/2017 at 09:36:18 +0100, Sascha Hauer wrote: > > +/* > > + * This function updates the RTC alarm registers and then clears all the > > + * interrupt status bits. > > + * The caller should hold the pdata->lock > > + * > > + * @param alrm the new alarm value to be updated in the RTC

Re: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Alexandre Belloni
On 06/12/2017 at 09:36:18 +0100, Sascha Hauer wrote: > > +/* > > + * This function updates the RTC alarm registers and then clears all the > > + * interrupt status bits. > > + * The caller should hold the pdata->lock > > + * > > + * @param alrm the new alarm value to be updated in the RTC

Re: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Sascha Hauer
On Tue, Dec 05, 2017 at 03:06:46PM +0100, linux-kernel-...@beckhoff.com wrote: > From: Patrick Bruenn > > Neither rtc-imxdi, rtc-mxc nor rtc-snvs are compatible with i.MX53. > > This is driver enables support for the low power domain SRTC features: > - 32-bit MSB of

Re: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Sascha Hauer
On Tue, Dec 05, 2017 at 03:06:46PM +0100, linux-kernel-...@beckhoff.com wrote: > From: Patrick Bruenn > > Neither rtc-imxdi, rtc-mxc nor rtc-snvs are compatible with i.MX53. > > This is driver enables support for the low power domain SRTC features: > - 32-bit MSB of non-rollover time counter >

[PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-05 Thread linux-kernel-dev
From: Patrick Bruenn Neither rtc-imxdi, rtc-mxc nor rtc-snvs are compatible with i.MX53. This is driver enables support for the low power domain SRTC features: - 32-bit MSB of non-rollover time counter - 32-bit alarm register Based on:

[PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-05 Thread linux-kernel-dev
From: Patrick Bruenn Neither rtc-imxdi, rtc-mxc nor rtc-snvs are compatible with i.MX53. This is driver enables support for the low power domain SRTC features: - 32-bit MSB of non-rollover time counter - 32-bit alarm register Based on: