Re: [PATCH v2 5/5] spi: s3c64xx: use unsigned type for fifo handling variables

2016-07-05 Thread Andi Shyti
Hi Mark, > > The 'quirks' variable cannot ever be negative, therefore use u8 > > instead of int. The 8 bit size is given from the fact that > > currently the quirks variable has very few statuses. > > > > The rx_lvl_offset and tx_st_done store shift values, so that u8 > > is a proper size. > >

Re: [PATCH v2 5/5] spi: s3c64xx: use unsigned type for fifo handling variables

2016-07-05 Thread Andi Shyti
Hi Mark, > > The 'quirks' variable cannot ever be negative, therefore use u8 > > instead of int. The 8 bit size is given from the fact that > > currently the quirks variable has very few statuses. > > > > The rx_lvl_offset and tx_st_done store shift values, so that u8 > > is a proper size. > >

Re: [PATCH v2 5/5] spi: s3c64xx: use unsigned type for fifo handling variables

2016-07-05 Thread Mark Brown
On Tue, Jun 28, 2016 at 11:41:15AM +0900, Andi Shyti wrote: > The 'quirks' variable cannot ever be negative, therefore use u8 > instead of int. The 8 bit size is given from the fact that > currently the quirks variable has very few statuses. > > The rx_lvl_offset and tx_st_done store shift

Re: [PATCH v2 5/5] spi: s3c64xx: use unsigned type for fifo handling variables

2016-07-05 Thread Mark Brown
On Tue, Jun 28, 2016 at 11:41:15AM +0900, Andi Shyti wrote: > The 'quirks' variable cannot ever be negative, therefore use u8 > instead of int. The 8 bit size is given from the fact that > currently the quirks variable has very few statuses. > > The rx_lvl_offset and tx_st_done store shift

[PATCH v2 5/5] spi: s3c64xx: use unsigned type for fifo handling variables

2016-06-27 Thread Andi Shyti
The 'quirks' variable cannot ever be negative, therefore use u8 instead of int. The 8 bit size is given from the fact that currently the quirks variable has very few statuses. The rx_lvl_offset and tx_st_done store shift values, so that u8 is a proper size. fifo_lvl_mask stores a series of

[PATCH v2 5/5] spi: s3c64xx: use unsigned type for fifo handling variables

2016-06-27 Thread Andi Shyti
The 'quirks' variable cannot ever be negative, therefore use u8 instead of int. The 8 bit size is given from the fact that currently the quirks variable has very few statuses. The rx_lvl_offset and tx_st_done store shift values, so that u8 is a proper size. fifo_lvl_mask stores a series of