Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-30 Thread Dominique Martinet
Dominique Martinet wrote on Mon, Jul 23, 2018: > I'll try to get figures for various approaches before the merge window > for 4.19 starts, it's getting closer though... Here's some numbers; with v4.18-rc7 + current test tree (my 9p-next) as a base. For the context, I'm running on VMs that bind

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-30 Thread Dominique Martinet
Dominique Martinet wrote on Mon, Jul 23, 2018: > I'll try to get figures for various approaches before the merge window > for 4.19 starts, it's getting closer though... Here's some numbers; with v4.18-rc7 + current test tree (my 9p-next) as a base. For the context, I'm running on VMs that bind

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-23 Thread Greg Kurz
On Mon, 23 Jul 2018 14:25:31 +0200 Dominique Martinet wrote: > Greg Kurz wrote on Mon, Jul 23, 2018: > > The patch is quite big and I'm not sure I can find time to review it > > carefully, but I'll try to help anyway. > > No worry, thanks for this already. > > > > Sorry for coming back to

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-23 Thread Greg Kurz
On Mon, 23 Jul 2018 14:25:31 +0200 Dominique Martinet wrote: > Greg Kurz wrote on Mon, Jul 23, 2018: > > The patch is quite big and I'm not sure I can find time to review it > > carefully, but I'll try to help anyway. > > No worry, thanks for this already. > > > > Sorry for coming back to

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-23 Thread Dominique Martinet
Greg Kurz wrote on Mon, Jul 23, 2018: > The patch is quite big and I'm not sure I can find time to review it > carefully, but I'll try to help anyway. No worry, thanks for this already. > > Sorry for coming back to this patch now, I just noticed something that's > > actually probably a fairly

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-23 Thread Dominique Martinet
Greg Kurz wrote on Mon, Jul 23, 2018: > The patch is quite big and I'm not sure I can find time to review it > carefully, but I'll try to help anyway. No worry, thanks for this already. > > Sorry for coming back to this patch now, I just noticed something that's > > actually probably a fairly

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-23 Thread Greg Kurz
On Wed, 18 Jul 2018 12:05:54 +0200 Dominique Martinet wrote: > +Cc Greg, I could use your opinion on this if you have a moment. > Hi Dominique, The patch is quite big and I'm not sure I can find time to review it carefully, but I'll try to help anyway. > Matthew Wilcox wrote on Wed, Jul 11,

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-23 Thread Greg Kurz
On Wed, 18 Jul 2018 12:05:54 +0200 Dominique Martinet wrote: > +Cc Greg, I could use your opinion on this if you have a moment. > Hi Dominique, The patch is quite big and I'm not sure I can find time to review it carefully, but I'll try to help anyway. > Matthew Wilcox wrote on Wed, Jul 11,

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-18 Thread Dominique Martinet
Matthew Wilcox wrote on Wed, Jul 18, 2018: > I must admit to having not looked at the fcall aspect of this. kmalloc > is implemented in terms of slab, so it's not going to be much slower than > using a dedicatd slab (a few instructions to figure out which slab cache > to use). Yeah, kmalloc-8,

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-18 Thread Dominique Martinet
Matthew Wilcox wrote on Wed, Jul 18, 2018: > I must admit to having not looked at the fcall aspect of this. kmalloc > is implemented in terms of slab, so it's not going to be much slower than > using a dedicatd slab (a few instructions to figure out which slab cache > to use). Yeah, kmalloc-8,

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-18 Thread Matthew Wilcox
On Wed, Jul 18, 2018 at 12:05:54PM +0200, Dominique Martinet wrote: > +Cc Greg, I could use your opinion on this if you have a moment. > > Matthew Wilcox wrote on Wed, Jul 11, 2018: > > Replace the custom batch allocation with a slab. Use an IDR to store > > pointers to the active requests

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-18 Thread Matthew Wilcox
On Wed, Jul 18, 2018 at 12:05:54PM +0200, Dominique Martinet wrote: > +Cc Greg, I could use your opinion on this if you have a moment. > > Matthew Wilcox wrote on Wed, Jul 11, 2018: > > Replace the custom batch allocation with a slab. Use an IDR to store > > pointers to the active requests

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-18 Thread Dominique Martinet
+Cc Greg, I could use your opinion on this if you have a moment. Matthew Wilcox wrote on Wed, Jul 11, 2018: > Replace the custom batch allocation with a slab. Use an IDR to store > pointers to the active requests instead of an array. We don't try to > handle P9_NOTAG specially; the IDR will

Re: [PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-18 Thread Dominique Martinet
+Cc Greg, I could use your opinion on this if you have a moment. Matthew Wilcox wrote on Wed, Jul 11, 2018: > Replace the custom batch allocation with a slab. Use an IDR to store > pointers to the active requests instead of an array. We don't try to > handle P9_NOTAG specially; the IDR will

[PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-11 Thread Matthew Wilcox
Replace the custom batch allocation with a slab. Use an IDR to store pointers to the active requests instead of an array. We don't try to handle P9_NOTAG specially; the IDR will happily shrink all the way back once the TVERSION call has completed. Signed-off-by: Matthew Wilcox ---

[PATCH v2 5/6] 9p: Use a slab for allocating requests

2018-07-11 Thread Matthew Wilcox
Replace the custom batch allocation with a slab. Use an IDR to store pointers to the active requests instead of an array. We don't try to handle P9_NOTAG specially; the IDR will happily shrink all the way back once the TVERSION call has completed. Signed-off-by: Matthew Wilcox ---