Re: [PATCH v2 5/6] i2c: Add Actions Semi OWL family S900 I2C driver

2018-06-30 Thread Manivannan Sadhasivam
Hi Andy, On Sat, Jun 30, 2018 at 04:04:20PM +0300, Andy Shevchenko wrote: > On Sat, Jun 30, 2018 at 3:44 PM, Manivannan Sadhasivam > wrote: > > On Sat, Jun 30, 2018 at 03:14:37PM +0300, Andy Shevchenko wrote: > >> On Thu, Jun 28, 2018 at 9:10 PM, Manivannan Sadhasivam > >> wrote: > > >> > +stat

Re: [PATCH v2 5/6] i2c: Add Actions Semi OWL family S900 I2C driver

2018-06-30 Thread Andy Shevchenko
On Sat, Jun 30, 2018 at 3:44 PM, Manivannan Sadhasivam wrote: > On Sat, Jun 30, 2018 at 03:14:37PM +0300, Andy Shevchenko wrote: >> On Thu, Jun 28, 2018 at 9:10 PM, Manivannan Sadhasivam >> wrote: >> > +static int owl_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg >> > *msgs, >> > +

Re: [PATCH v2 5/6] i2c: Add Actions Semi OWL family S900 I2C driver

2018-06-30 Thread Manivannan Sadhasivam
Hi Andy, On Sat, Jun 30, 2018 at 03:14:37PM +0300, Andy Shevchenko wrote: > On Thu, Jun 28, 2018 at 9:10 PM, Manivannan Sadhasivam > wrote: > > Add Actions Semi OWL family S900 I2C driver. > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > > +#includ

Re: [PATCH v2 5/6] i2c: Add Actions Semi OWL family S900 I2C driver

2018-06-30 Thread Andy Shevchenko
On Thu, Jun 28, 2018 at 9:10 PM, Manivannan Sadhasivam wrote: > Add Actions Semi OWL family S900 I2C driver. > +#include > +#include > +#include > +#include > +#include > +#include > +#include Perhaps keep in order? > +#define OWL_I2C_DEFAULT_SPEED 10 > +#define OWL_I2C_MAX_SPEED

Re: [PATCH v2 5/6] i2c: Add Actions Semi OWL family S900 I2C driver

2018-06-30 Thread Manivannan Sadhasivam
Hi Peter, Thanks for the review! On Fri, Jun 29, 2018 at 06:45:19AM +0200, Peter Rosin wrote: > On June 28, 2018 8:10:41 PM GMT+02:00, Manivannan Sadhasivam > wrote: > >Add Actions Semi OWL family S900 I2C driver. > > > >Signed-off-by: Manivannan Sadhasivam > >--- > > drivers/i2c/busses/Kconfi

Re: [PATCH v2 5/6] i2c: Add Actions Semi OWL family S900 I2C driver

2018-06-28 Thread Peter Rosin
On June 28, 2018 8:10:41 PM GMT+02:00, Manivannan Sadhasivam wrote: >Add Actions Semi OWL family S900 I2C driver. > >Signed-off-by: Manivannan Sadhasivam >--- > drivers/i2c/busses/Kconfig | 7 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-owl.c | 471 ++

[PATCH v2 5/6] i2c: Add Actions Semi OWL family S900 I2C driver

2018-06-28 Thread Manivannan Sadhasivam
Add Actions Semi OWL family S900 I2C driver. Signed-off-by: Manivannan Sadhasivam --- drivers/i2c/busses/Kconfig | 7 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-owl.c | 471 +++ 3 files changed, 479 insertions(+) create mode 100644 drivers