Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-06-13 Thread Lina Iyer
On Fri, May 25 2018 at 19:08 -0600, David Collins wrote: Hello Rajendra, On 05/25/2018 03:01 AM, Rajendra Nayak wrote: + + to_active_sleep(pd, pd->corner, _corner, _sleep_corner); + + if (peer && peer->enabled) + to_active_sleep(peer, peer->corner, _corner, +

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-06-01 Thread David Collins
Hello Rajendra, On 06/01/2018 01:48 AM, Rajendra Nayak wrote: > On 05/26/2018 06:38 AM, David Collins wrote: >> >>> + [1] = _mx, >>> + [2] = _mx_ao, >>> + [3] = _cx, >>> + [4] = _cx_ao, >>> + [5] = _lmx, >>> + [6] = _lcx, >>> + [7] = _gfx, >>> + [8] = _mss, >>> +}; >>> + >>>

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-06-01 Thread Rajendra Nayak
Hi David, On 05/26/2018 06:38 AM, David Collins wrote: > >> +[1] = _mx, >> +[2] = _mx_ao, >> +[3] = _cx, >> +[4] = _cx_ao, >> +[5] = _lmx, >> +[6] = _lcx, >> +[7] = _gfx, >> +[8] = _mss, >> +}; >> + >> +static const struct rpmhpd_desc sdm845_desc = { >> +

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-30 Thread Rajendra Nayak
On 05/31/2018 09:01 AM, Rob Herring wrote: > On Fri, May 25, 2018 at 03:31:20PM +0530, Rajendra Nayak wrote: >> The RPMh powerdomain driver aggregates the corner votes from various >> consumers for the ARC resources and communicates it to RPMh. >> >> We also add data for all powerdomains on

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-30 Thread Rob Herring
On Fri, May 25, 2018 at 03:31:20PM +0530, Rajendra Nayak wrote: > The RPMh powerdomain driver aggregates the corner votes from various > consumers for the ARC resources and communicates it to RPMh. > > We also add data for all powerdomains on sdm845 as part of the patch. > The driver can be

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-30 Thread Rajendra Nayak
On 05/30/2018 03:14 PM, Viresh Kumar wrote: > On 30-05-18, 14:25, Rajendra Nayak wrote: >> []... >> > +Required Properties: > + - compatible: Should be one of the following > + * qcom,sdm845-rpmhpd: RPMh powerdomain for the sdm845 family of SoC > + - power-domain-cells: number

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-30 Thread Viresh Kumar
On 30-05-18, 14:25, Rajendra Nayak wrote: > []... > > >>> +Required Properties: > >>> + - compatible: Should be one of the following > >>> + * qcom,sdm845-rpmhpd: RPMh powerdomain for the sdm845 family of SoC > >>> + - power-domain-cells: number of cells in power domain specifier > >>> + must be

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-30 Thread Rajendra Nayak
[]... >>> +Required Properties: >>> + - compatible: Should be one of the following >>> + * qcom,sdm845-rpmhpd: RPMh powerdomain for the sdm845 family of SoC >>> + - power-domain-cells: number of cells in power domain specifier >>> + must be 1 >>> + - operating-points-v2: Phandle to the OPP

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-29 Thread David Collins
Hello Rajendra, On 05/29/2018 03:19 AM, Rajendra Nayak wrote: > On 05/26/2018 06:38 AM, David Collins wrote: >> On 05/25/2018 03:01 AM, Rajendra Nayak wrote: >>> The RPMh powerdomain driver aggregates the corner votes from various ... >>> diff --git a/drivers/soc/qcom/Kconfig

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-29 Thread Rajendra Nayak
Hi David, On 05/26/2018 06:38 AM, David Collins wrote: > Hello Rajendra, > > On 05/25/2018 03:01 AM, Rajendra Nayak wrote: >> The RPMh powerdomain driver aggregates the corner votes from various > > s/powerdomain/power domain/ > > This applies to all instances in this patch. "Power domain"

Re: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-25 Thread David Collins
Hello Rajendra, On 05/25/2018 03:01 AM, Rajendra Nayak wrote: > The RPMh powerdomain driver aggregates the corner votes from various s/powerdomain/power domain/ This applies to all instances in this patch. "Power domain" seems to be the preferred spelling in the kernel. > consumers for the

[PATCH v2 5/6] soc: qcom: rpmh powerdomain driver

2018-05-25 Thread Rajendra Nayak
The RPMh powerdomain driver aggregates the corner votes from various consumers for the ARC resources and communicates it to RPMh. We also add data for all powerdomains on sdm845 as part of the patch. The driver can be extended to support other SoCs which support RPMh Signed-off-by: Rajendra