Re: [PATCH v2 8/8] p54: convert to sysdata API

On Fri, Jun 17, 2016 at 08:35:03PM +0200, Luis R. Rodriguez wrote: > On Thu, Jun 16, 2016 at 05:09:30PM -1000, Linus Torvalds wrote: > > On Thu, Jun 16, 2016 at 3:36 PM, Luis R. Rodriguez > > wrote: > > > > > > Reason this could not wait is folks seem to want to keep extending

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Fri, Jun 17, 2016 at 08:35:03PM +0200, Luis R. Rodriguez wrote: > On Thu, Jun 16, 2016 at 05:09:30PM -1000, Linus Torvalds wrote: > > On Thu, Jun 16, 2016 at 3:36 PM, Luis R. Rodriguez > > wrote: > > > > > > Reason this could not wait is folks seem to want to keep extending the > > > API, >

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Wed, Aug 10, 2016 at 08:17:08PM +0100, Mark Brown wrote: > On Wed, Aug 10, 2016 at 09:04:38PM +0200, Arend Van Spriel wrote: > > > So why would drivers want the devm solution anyway. Once firmware is > > loaded in the device it can be freed or do you expect device drivers to > > keep the

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Wed, Aug 10, 2016 at 08:17:08PM +0100, Mark Brown wrote: > On Wed, Aug 10, 2016 at 09:04:38PM +0200, Arend Van Spriel wrote: > > > So why would drivers want the devm solution anyway. Once firmware is > > loaded in the device it can be freed or do you expect device drivers to > > keep the

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Wed, Aug 10, 2016 at 09:04:38PM +0200, Arend Van Spriel wrote: > On 10-8-2016 20:32, Luis R. Rodriguez wrote: > > On Fri, Jun 17, 2016 at 08:35:03PM +0200, Luis R. Rodriguez wrote: > >> On Thu, Jun 16, 2016 at 05:09:30PM -1000, Linus Torvalds wrote: > >>> On Thu, Jun 16, 2016 at 3:36 PM, Luis

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Wed, Aug 10, 2016 at 09:04:38PM +0200, Arend Van Spriel wrote: > On 10-8-2016 20:32, Luis R. Rodriguez wrote: > > On Fri, Jun 17, 2016 at 08:35:03PM +0200, Luis R. Rodriguez wrote: > >> On Thu, Jun 16, 2016 at 05:09:30PM -1000, Linus Torvalds wrote: > >>> On Thu, Jun 16, 2016 at 3:36 PM, Luis

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Wed, Aug 10, 2016 at 09:04:38PM +0200, Arend Van Spriel wrote: > So why would drivers want the devm solution anyway. Once firmware is > loaded in the device it can be freed or do you expect device drivers to > keep the firmware/sysdata for suspend/resume scenario as some do because > of

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Wed, Aug 10, 2016 at 09:04:38PM +0200, Arend Van Spriel wrote: > So why would drivers want the devm solution anyway. Once firmware is > loaded in the device it can be freed or do you expect device drivers to > keep the firmware/sysdata for suspend/resume scenario as some do because > of

Re: [PATCH v2 8/8] p54: convert to sysdata API

On 10-8-2016 20:32, Luis R. Rodriguez wrote: > On Fri, Jun 17, 2016 at 08:35:03PM +0200, Luis R. Rodriguez wrote: >> On Thu, Jun 16, 2016 at 05:09:30PM -1000, Linus Torvalds wrote: >>> On Thu, Jun 16, 2016 at 3:36 PM, Luis R. Rodriguez >>> wrote: Reason this could

Re: [PATCH v2 8/8] p54: convert to sysdata API

On 10-8-2016 20:32, Luis R. Rodriguez wrote: > On Fri, Jun 17, 2016 at 08:35:03PM +0200, Luis R. Rodriguez wrote: >> On Thu, Jun 16, 2016 at 05:09:30PM -1000, Linus Torvalds wrote: >>> On Thu, Jun 16, 2016 at 3:36 PM, Luis R. Rodriguez >>> wrote: Reason this could not wait is folks

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Thu, Jun 16, 2016 at 05:09:30PM -1000, Linus Torvalds wrote: > On Thu, Jun 16, 2016 at 3:36 PM, Luis R. Rodriguez wrote: > > > > Reason this could not wait is folks seem to want to keep extending the API, > > which is another reason for this, do we want to put an end to an

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Thu, Jun 16, 2016 at 05:09:30PM -1000, Linus Torvalds wrote: > On Thu, Jun 16, 2016 at 3:36 PM, Luis R. Rodriguez wrote: > > > > Reason this could not wait is folks seem to want to keep extending the API, > > which is another reason for this, do we want to put an end to an unflexible > > API

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Thu, Jun 16, 2016 at 3:36 PM, Luis R. Rodriguez wrote: > > Reason this could not wait is folks seem to want to keep extending the API, > which is another reason for this, do we want to put an end to an unflexible > API now or should we wait ? So I absolutely abhor "changes

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Thu, Jun 16, 2016 at 3:36 PM, Luis R. Rodriguez wrote: > > Reason this could not wait is folks seem to want to keep extending the API, > which is another reason for this, do we want to put an end to an unflexible > API now or should we wait ? So I absolutely abhor "changes for changes sake".

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Thu, Jun 16, 2016 at 02:21:02PM -1000, Linus Torvalds wrote: > So what is the advantage of this, since it needs to add more lines of code > than it removes? > > It doesn't seem to be a simplification. Quite the reverse. > > Your diffstat of the whole automated conversion did that too. A lot

Re: [PATCH v2 8/8] p54: convert to sysdata API

On Thu, Jun 16, 2016 at 02:21:02PM -1000, Linus Torvalds wrote: > So what is the advantage of this, since it needs to add more lines of code > than it removes? > > It doesn't seem to be a simplification. Quite the reverse. > > Your diffstat of the whole automated conversion did that too. A lot

[PATCH v2 8/8] p54: convert to sysdata API

The Coccinelle sysdata patches were used to help with this transition. The changes have been carefully manually vetted for. With the conversion we modify the cases that do not need the firmware to be kept so that the sysdata API can release it for us. Using the new sysdata API also means we can

[PATCH v2 8/8] p54: convert to sysdata API

The Coccinelle sysdata patches were used to help with this transition. The changes have been carefully manually vetted for. With the conversion we modify the cases that do not need the firmware to be kept so that the sysdata API can release it for us. Using the new sysdata API also means we can