Re: [PATCH v2 RFC] mm/vmscan: more restrictive condition for retry in do_try_to_free_pages

2017-03-16 Thread Shakeel Butt
On Thu, Mar 16, 2017 at 12:57 PM, Johannes Weiner wrote: > On Sat, Mar 11, 2017 at 09:52:15AM -0800, Shakeel Butt wrote: >> On Sat, Mar 11, 2017 at 5:51 AM, Yisheng Xie wrote: >> > @@ -2808,7 +2826,7 @@ static unsigned long do_try_to_free_pages(struct >> >

Re: [PATCH v2 RFC] mm/vmscan: more restrictive condition for retry in do_try_to_free_pages

2017-03-16 Thread Shakeel Butt
On Thu, Mar 16, 2017 at 12:57 PM, Johannes Weiner wrote: > On Sat, Mar 11, 2017 at 09:52:15AM -0800, Shakeel Butt wrote: >> On Sat, Mar 11, 2017 at 5:51 AM, Yisheng Xie wrote: >> > @@ -2808,7 +2826,7 @@ static unsigned long do_try_to_free_pages(struct >> > zonelist *zonelist, >> >

Re: [PATCH v2 RFC] mm/vmscan: more restrictive condition for retry in do_try_to_free_pages

2017-03-16 Thread Johannes Weiner
On Sat, Mar 11, 2017 at 09:52:15AM -0800, Shakeel Butt wrote: > On Sat, Mar 11, 2017 at 5:51 AM, Yisheng Xie wrote: > > @@ -2808,7 +2826,7 @@ static unsigned long do_try_to_free_pages(struct > > zonelist *zonelist, > > return 1; > > > > /* Untapped

Re: [PATCH v2 RFC] mm/vmscan: more restrictive condition for retry in do_try_to_free_pages

2017-03-16 Thread Johannes Weiner
On Sat, Mar 11, 2017 at 09:52:15AM -0800, Shakeel Butt wrote: > On Sat, Mar 11, 2017 at 5:51 AM, Yisheng Xie wrote: > > @@ -2808,7 +2826,7 @@ static unsigned long do_try_to_free_pages(struct > > zonelist *zonelist, > > return 1; > > > > /* Untapped cgroup reserves? Don't

Re: [PATCH v2 RFC] mm/vmscan: more restrictive condition for retry in do_try_to_free_pages

2017-03-12 Thread Yisheng Xie
hi, Shakeel, On 03/12/2017 01:52 AM, Shakeel Butt wrote: > On Sat, Mar 11, 2017 at 5:51 AM, Yisheng Xie wrote: >> From: Yisheng Xie >> >> When we enter do_try_to_free_pages, the may_thrash is always clear, and >> it will retry shrink zones to tap

Re: [PATCH v2 RFC] mm/vmscan: more restrictive condition for retry in do_try_to_free_pages

2017-03-12 Thread Yisheng Xie
hi, Shakeel, On 03/12/2017 01:52 AM, Shakeel Butt wrote: > On Sat, Mar 11, 2017 at 5:51 AM, Yisheng Xie wrote: >> From: Yisheng Xie >> >> When we enter do_try_to_free_pages, the may_thrash is always clear, and >> it will retry shrink zones to tap cgroup's reserves memory by setting >>

Re: [PATCH v2 RFC] mm/vmscan: more restrictive condition for retry in do_try_to_free_pages

2017-03-11 Thread Shakeel Butt
On Sat, Mar 11, 2017 at 5:51 AM, Yisheng Xie wrote: > From: Yisheng Xie > > When we enter do_try_to_free_pages, the may_thrash is always clear, and > it will retry shrink zones to tap cgroup's reserves memory by setting > may_thrash when the former

Re: [PATCH v2 RFC] mm/vmscan: more restrictive condition for retry in do_try_to_free_pages

2017-03-11 Thread Shakeel Butt
On Sat, Mar 11, 2017 at 5:51 AM, Yisheng Xie wrote: > From: Yisheng Xie > > When we enter do_try_to_free_pages, the may_thrash is always clear, and > it will retry shrink zones to tap cgroup's reserves memory by setting > may_thrash when the former shrink_zones reclaim nothing. > > However, when

[PATCH v2 RFC] mm/vmscan: more restrictive condition for retry in do_try_to_free_pages

2017-03-11 Thread Yisheng Xie
From: Yisheng Xie When we enter do_try_to_free_pages, the may_thrash is always clear, and it will retry shrink zones to tap cgroup's reserves memory by setting may_thrash when the former shrink_zones reclaim nothing. However, when memcg is disabled or on legacy

[PATCH v2 RFC] mm/vmscan: more restrictive condition for retry in do_try_to_free_pages

2017-03-11 Thread Yisheng Xie
From: Yisheng Xie When we enter do_try_to_free_pages, the may_thrash is always clear, and it will retry shrink zones to tap cgroup's reserves memory by setting may_thrash when the former shrink_zones reclaim nothing. However, when memcg is disabled or on legacy hierarchy, it should not do this

[PATCH v2 RFC] mm/vmscan: more restrictive condition for retry in do_try_to_free_pages

2017-03-11 Thread Yisheng Xie
From: Yisheng Xie When we enter do_try_to_free_pages, the may_thrash is always clear, and it will retry shrink zones to tap cgroup's reserves memory by setting may_thrash when the former shrink_zones reclaim nothing. However, when memcg is disabled or on legacy

[PATCH v2 RFC] mm/vmscan: more restrictive condition for retry in do_try_to_free_pages

2017-03-11 Thread Yisheng Xie
From: Yisheng Xie When we enter do_try_to_free_pages, the may_thrash is always clear, and it will retry shrink zones to tap cgroup's reserves memory by setting may_thrash when the former shrink_zones reclaim nothing. However, when memcg is disabled or on legacy hierarchy, it should not do this