Re: [PATCH v2 net 2/3] sctp: remove redundant assignment when call sctp_get_port_local

[Marcelo Ricardo Leitner]

On Thu, Sep 12, 2019 at 12:02:18PM +0800, Mao Wenan wrote:
> There are more parentheses in if clause when call sctp_get_port_local
> in sctp_do_bind, and redundant assignment to 'ret'. This patch is to
> do cleanup.
> 
> Signed-off-by: Mao Wenan 
> Acked-by: Neil Horman 

Acked-by: Marcelo Ricardo Leitner 

[PATCH v2 net 2/3] sctp: remove redundant assignment when call sctp_get_port_local

[Mao Wenan]

There are more parentheses in if clause when call sctp_get_port_local
in sctp_do_bind, and redundant assignment to 'ret'. This patch is to
do cleanup.

Signed-off-by: Mao Wenan 
Acked-by: Neil Horman 
---
 net/sctp/socket.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 5e1934c48709..2f810078c91d 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -399,9 +399,8 @@ static int sctp_do_bind(struct sock *sk, union sctp_addr 
*addr, int len)
 * detection.
 */
addr->v4.sin_port = htons(snum);
-   if ((ret = sctp_get_port_local(sk, addr))) {
+   if (sctp_get_port_local(sk, addr))
return -EADDRINUSE;
-   }
 
/* Refresh ephemeral port.  */
if (!bp->port)
-- 
2.20.1