Re: [PATCH v25 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-10-07 Thread houlong wei
On Sat, 2018-09-29 at 20:50 +0800, Matthias Brugger wrote: > > On 29/09/2018 11:21, Houlong Wei wrote: > [...] > > > +static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code > > code, > > + u32 arg_a, u32 arg_b) > > +{ > > + u64 *cmd_ptr; > > + > >

Re: [PATCH v25 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-10-07 Thread houlong wei
On Sat, 2018-09-29 at 20:50 +0800, Matthias Brugger wrote: > > On 29/09/2018 11:21, Houlong Wei wrote: > [...] > > > +static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code > > code, > > + u32 arg_a, u32 arg_b) > > +{ > > + u64 *cmd_ptr; > > + > >

Re: [PATCH v25 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-09-29 Thread Matthias Brugger
On 29/09/2018 11:21, Houlong Wei wrote: [...] > +static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code, > +u32 arg_a, u32 arg_b) > +{ > + u64 *cmd_ptr; > + > + if (unlikely(pkt->cmd_buf_size + CMDQ_INST_SIZE > pkt->buf_size)) { > +

Re: [PATCH v25 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-09-29 Thread Matthias Brugger
On 29/09/2018 11:21, Houlong Wei wrote: [...] > +static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code, > +u32 arg_a, u32 arg_b) > +{ > + u64 *cmd_ptr; > + > + if (unlikely(pkt->cmd_buf_size + CMDQ_INST_SIZE > pkt->buf_size)) { > +

[PATCH v25 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-09-29 Thread Houlong Wei
Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile |1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 291

[PATCH v25 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-09-29 Thread Houlong Wei
Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile |1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 291