Re: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-17 Thread Mathieu Poirier
On Wed, Feb 17, 2021 at 09:34:13PM +, Ben Levinsky wrote: > 1 more for the pnode_id comment > [...] > > > > > +static int parse_tcm_banks(struct rproc *rproc) > > > > > +{ > > > > > + int i, num_banks; > > > > > + struct zynqmp_r5_rproc *z_rproc = rproc->priv; > > > > > + struct

Re: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-17 Thread Mathieu Poirier
On Wed, Feb 17, 2021 at 07:11:37PM +, Ben Levinsky wrote: > Hi Mathieu, > > I worked on this further and had 1 more comment on the prepare/unprepare for > TCM banks below > [...] > > > > + */ > > > > +static int tcm_mem_release(struct rproc *rproc, struct rproc_mem_entry > > > *mem) > > >

RE: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-17 Thread Ben Levinsky
radead.org; Michal Simek > > Subject: RE: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc > driver > > Hi Mathieu, > > I worked on this further and had 1 more comment on the prepare/unprepare > for TCM banks below > > > -Original Message- >

RE: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-17 Thread Ben Levinsky
vger.kernel.org; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Michal Simek > > Subject: RE: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc > driver > > Hi Mathieu, > > Please see my replies to your questions inline > > Agai

RE: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-17 Thread Ben Levinsky
; linux-remotep...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Michal Simek > > Subject: Re: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc > driver > > On Sun, Jan 10, 2021 at 06:02:50PM -0800, Ben Levinsky wrote: > > R

Re: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-16 Thread Mathieu Poirier
On Sun, Jan 10, 2021 at 06:02:50PM -0800, Ben Levinsky wrote: > R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this > remotproc driver, we can boot the R5 sub-system in two different > configurations - > * Split > * Lockstep > > The Xilinx R5 Remoteproc Driver boots the

Re: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-15 Thread Mathieu Poirier
Good day, I have started to review this set - as with previous revisions comments will come over several days. On Sun, Jan 10, 2021 at 06:02:50PM -0800, Ben Levinsky wrote: > R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this > remotproc driver, we can boot the R5 sub-system in two

[PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-01-10 Thread Ben Levinsky
R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this remotproc driver, we can boot the R5 sub-system in two different configurations - * Split * Lockstep The Xilinx R5 Remoteproc Driver boots the R5's via calls to the Xilinx Platform Management Unit that handles the R5