Re: [PATCH v3] ANDROID: binder: change down_write to down_read

2018-03-29 Thread Fengguang Wu
On Fri, Mar 30, 2018 at 09:37:36AM +0900, Minchan Kim wrote: On Fri, Mar 30, 2018 at 07:42:37AM +0800, kbuild test robot wrote: Hi Minchan, I love your patch! Yet something to improve: Glad to hear. It's first time someone loves my patch. ;-) FYI, that message originates from Linus. :-) [

Re: [PATCH v3] ANDROID: binder: change down_write to down_read

2018-03-29 Thread Minchan Kim
On Fri, Mar 30, 2018 at 07:42:37AM +0800, kbuild test robot wrote: > Hi Minchan, > > I love your patch! Yet something to improve: Glad to hear. It's first time someone loves my patch. ;-) > > [auto build test ERROR on staging/staging-testing] > [also build test ERROR on v4.16-rc7 next-20180329]

Re: [PATCH v3] ANDROID: binder: change down_write to down_read

2018-03-29 Thread kbuild test robot
Hi Minchan, I love your patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.16-rc7 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/l

Re: [PATCH v3] ANDROID: binder: change down_write to down_read

2018-03-28 Thread Greg Kroah-Hartman
gt; Signed-off-by: Minchan Kim > > Sent wrong version. Sorry for that. Please ignore this and take it. > > >From 480e992d4a650fb98e1397114d75dea7af8e6d0c Mon Sep 17 00:00:00 2001 > From: Minchan Kim > Date: Wed, 28 Mar 2018 11:32:42 +0900 > Subject: [PATCH v3] ANDROID:

Re: [PATCH v3] ANDROID: binder: change down_write to down_read

2018-03-28 Thread Minchan Kim
0c Mon Sep 17 00:00:00 2001 From: Minchan Kim Date: Wed, 28 Mar 2018 11:32:42 +0900 Subject: [PATCH v3] ANDROID: binder: change down_write to down_read MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit binder_update_page_range needs down_write of mmap_sem be

[PATCH v3] ANDROID: binder: change down_write to down_read

2018-03-28 Thread Minchan Kim
binder_update_page_range needs down_write of mmap_sem because vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless it is set. However, when I profile binder working, it seems every binder buffers should be mapped in advance by binder_mmap. It means we could set VM_MIXEDMAP in bider_mma