Re: [PATCH v3] ARM: VDSO: put RO and RO after init objects into proper sections

2016-08-12 Thread Nathan Lynch
On 08/12/2016 01:06 PM, Kees Cook wrote: > On Fri, Aug 12, 2016 at 1:12 AM, Jisheng Zhang wrote: >> vdso_data_mapping is never modified, so mark it as const. >> >> vdso_total_pages, vdso_data_page, vdso_text_mapping and cntvct_ok are >> initialized by vdso_init(), thereafter

Re: [PATCH v3] ARM: VDSO: put RO and RO after init objects into proper sections

2016-08-12 Thread Nathan Lynch
On 08/12/2016 01:06 PM, Kees Cook wrote: > On Fri, Aug 12, 2016 at 1:12 AM, Jisheng Zhang wrote: >> vdso_data_mapping is never modified, so mark it as const. >> >> vdso_total_pages, vdso_data_page, vdso_text_mapping and cntvct_ok are >> initialized by vdso_init(), thereafter are read only. >> >>

Re: [PATCH v3] ARM: VDSO: put RO and RO after init objects into proper sections

2016-08-12 Thread Kees Cook
On Fri, Aug 12, 2016 at 1:12 AM, Jisheng Zhang wrote: > vdso_data_mapping is never modified, so mark it as const. > > vdso_total_pages, vdso_data_page, vdso_text_mapping and cntvct_ok are > initialized by vdso_init(), thereafter are read only. > > The fact that they are read

Re: [PATCH v3] ARM: VDSO: put RO and RO after init objects into proper sections

2016-08-12 Thread Kees Cook
On Fri, Aug 12, 2016 at 1:12 AM, Jisheng Zhang wrote: > vdso_data_mapping is never modified, so mark it as const. > > vdso_total_pages, vdso_data_page, vdso_text_mapping and cntvct_ok are > initialized by vdso_init(), thereafter are read only. > > The fact that they are read only after init makes

[PATCH v3] ARM: VDSO: put RO and RO after init objects into proper sections

2016-08-12 Thread Jisheng Zhang
vdso_data_mapping is never modified, so mark it as const. vdso_total_pages, vdso_data_page, vdso_text_mapping and cntvct_ok are initialized by vdso_init(), thereafter are read only. The fact that they are read only after init makes them candidates for __ro_after_init declarations.

[PATCH v3] ARM: VDSO: put RO and RO after init objects into proper sections

2016-08-12 Thread Jisheng Zhang
vdso_data_mapping is never modified, so mark it as const. vdso_total_pages, vdso_data_page, vdso_text_mapping and cntvct_ok are initialized by vdso_init(), thereafter are read only. The fact that they are read only after init makes them candidates for __ro_after_init declarations.