Re: [PATCH v3] Documentation: add Device tree bindings for hwmon/nct7802

2015-09-08 Thread Constantine Shulyupin
> Sure, but why do you need _raw_ register values? > > Why can you not encode this in the DT in a manner that describes what is > connected to this device, then have the kernel figure out any particular > values that need to be poked into registers? > > That'll be easier to read, and it's far more

Re: [PATCH v3] Documentation: add Device tree bindings for hwmon/nct7802

2015-09-08 Thread Mark Rutland
On Tue, Sep 08, 2015 at 01:07:30PM +0100, Constantine Shulyupin wrote: > >> Add add Device tree bindings for registers > >> which are not covered by hwmon ABI and are required to > >> configure specific HW. > > > > This doesn't really answer my question [1] of why you need these. > > > > We

Re: [PATCH v3] Documentation: add Device tree bindings for hwmon/nct7802

2015-09-08 Thread Constantine Shulyupin
>> Add add Device tree bindings for registers >> which are not covered by hwmon ABI and are required to >> configure specific HW. > > This doesn't really answer my question [1] of why you need these. > > We generally don't encode register values unless there's no other way to > describe the

Re: [PATCH v3] Documentation: add Device tree bindings for hwmon/nct7802

2015-09-08 Thread Mark Rutland
On Mon, Sep 07, 2015 at 11:27:47PM +0100, Constantine Shulyupin wrote: > Add add Device tree bindings for registers > which are not covered by hwmon ABI and are required to > configure specific HW. This doesn't really answer my question [1] of why you need these. We generally don't encode

Re: [PATCH v3] Documentation: add Device tree bindings for hwmon/nct7802

2015-09-08 Thread Mark Rutland
On Mon, Sep 07, 2015 at 11:27:47PM +0100, Constantine Shulyupin wrote: > Add add Device tree bindings for registers > which are not covered by hwmon ABI and are required to > configure specific HW. This doesn't really answer my question [1] of why you need these. We generally don't encode

Re: [PATCH v3] Documentation: add Device tree bindings for hwmon/nct7802

2015-09-08 Thread Mark Rutland
On Tue, Sep 08, 2015 at 01:07:30PM +0100, Constantine Shulyupin wrote: > >> Add add Device tree bindings for registers > >> which are not covered by hwmon ABI and are required to > >> configure specific HW. > > > > This doesn't really answer my question [1] of why you need these. > > > > We

Re: [PATCH v3] Documentation: add Device tree bindings for hwmon/nct7802

2015-09-08 Thread Constantine Shulyupin
>> Add add Device tree bindings for registers >> which are not covered by hwmon ABI and are required to >> configure specific HW. > > This doesn't really answer my question [1] of why you need these. > > We generally don't encode register values unless there's no other way to > describe the

Re: [PATCH v3] Documentation: add Device tree bindings for hwmon/nct7802

2015-09-08 Thread Constantine Shulyupin
> Sure, but why do you need _raw_ register values? > > Why can you not encode this in the DT in a manner that describes what is > connected to this device, then have the kernel figure out any particular > values that need to be poked into registers? > > That'll be easier to read, and it's far more

[PATCH v3] Documentation: add Device tree bindings for hwmon/nct7802

2015-09-07 Thread Constantine Shulyupin
Add add Device tree bindings for registers which are not covered by hwmon ABI and are required to configure specific HW. --- Changed in v3: - Fixed vendor prefix - Added short registers description, full registers description is available at

[PATCH v3] Documentation: add Device tree bindings for hwmon/nct7802

2015-09-07 Thread Constantine Shulyupin
Add add Device tree bindings for registers which are not covered by hwmon ABI and are required to configure specific HW. --- Changed in v3: - Fixed vendor prefix - Added short registers description, full registers description is available at