Re: [PATCH v3] HID: New hid-cp2112 driver

2014-01-20 Thread Oliver Neukum
On Thu, 2014-01-16 at 15:52 -0600, David Barksdale wrote: > +enum { > + STATUS1_TIMEOUT_NACK = 0x00, > + STATUS1_TIMEOUT_BUS = 0x01, > + STATUS1_ARBITRATION_LOST = 0x02, > + STATUS1_READ_INCOMPLETE = 0x03, > + STATUS1_WRITE_INCOMPLETE = 0x04, > + STATUS1_SUCCESS = 0x05, > +

Re: [PATCH v3] HID: New hid-cp2112 driver

2014-01-17 Thread David Herrmann
Hi This patch is in a much better state than before! I have a bunch of comments below, mostly nitpicks and coding-style issues. If you fix the coding style and minor issues below, I think we can merge it. Thanks David On Thu, Jan 16, 2014 at 10:52 PM, David Barksdale wrote: > This patch adds su

[PATCH v3] HID: New hid-cp2112 driver

2014-01-16 Thread David Barksdale
This patch adds support for the Silicon Labs CP2112 "Single-Chip HID USB to SMBus Master Bridge." This is a HID device driver which registers as an i2c adapter and gpiochip to expose these functions of the CP2112. The customizable USB descriptor fields are exposed as sysfs attributes. The SMBus by