Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-15 Thread J. Bruce Fields
On Thu, Nov 15, 2012 at 01:34:16PM +, Myklebust, Trond wrote: > On Wed, 2012-11-14 at 22:14 -0800, Eric W. Biederman wrote: > > "J. Bruce Fields" writes: > > > > > On Wed, Nov 14, 2012 at 09:51:33PM +, Myklebust, Trond wrote: > > >> On Wed, 2012-11-14 at 16:42 -0500, J. Bruce Fields

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-15 Thread Myklebust, Trond
On Wed, 2012-11-14 at 22:14 -0800, Eric W. Biederman wrote: > "J. Bruce Fields" writes: > > > On Wed, Nov 14, 2012 at 09:51:33PM +, Myklebust, Trond wrote: > >> On Wed, 2012-11-14 at 16:42 -0500, J. Bruce Fields wrote: > >> > Simo's patches use them for upcalls to svcgssd. Those will always

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-15 Thread Stanislav Kinsbursky
15.11.2012 01:01, J. Bruce Fields пишет: On Mon, Nov 12, 2012 at 12:37:54PM +0400, Stanislav Kinsbursky wrote: 07.11.2012 22:33, J. Bruce Fields пишет: On Tue, Nov 06, 2012 at 08:36:05AM -0500, J. Bruce Fields wrote: On Tue, Nov 06, 2012 at 08:10:18AM -0500, Christoph Hellwig wrote: On Tue,

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-15 Thread Stanislav Kinsbursky
15.11.2012 01:01, J. Bruce Fields пишет: On Mon, Nov 12, 2012 at 12:37:54PM +0400, Stanislav Kinsbursky wrote: 07.11.2012 22:33, J. Bruce Fields пишет: On Tue, Nov 06, 2012 at 08:36:05AM -0500, J. Bruce Fields wrote: On Tue, Nov 06, 2012 at 08:10:18AM -0500, Christoph Hellwig wrote: On Tue,

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-15 Thread Myklebust, Trond
On Wed, 2012-11-14 at 22:14 -0800, Eric W. Biederman wrote: J. Bruce Fields bfie...@fieldses.org writes: On Wed, Nov 14, 2012 at 09:51:33PM +, Myklebust, Trond wrote: On Wed, 2012-11-14 at 16:42 -0500, J. Bruce Fields wrote: Simo's patches use them for upcalls to svcgssd. Those will

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-15 Thread J. Bruce Fields
On Thu, Nov 15, 2012 at 01:34:16PM +, Myklebust, Trond wrote: On Wed, 2012-11-14 at 22:14 -0800, Eric W. Biederman wrote: J. Bruce Fields bfie...@fieldses.org writes: On Wed, Nov 14, 2012 at 09:51:33PM +, Myklebust, Trond wrote: On Wed, 2012-11-14 at 16:42 -0500, J. Bruce

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread Eric W. Biederman
"J. Bruce Fields" writes: > On Wed, Nov 14, 2012 at 09:51:33PM +, Myklebust, Trond wrote: >> On Wed, 2012-11-14 at 16:42 -0500, J. Bruce Fields wrote: >> > Simo's patches use them for upcalls to svcgssd. Those will always be >> > done from server threads. >> >> Any reason why you can't set

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2012 at 09:51:33PM +, Myklebust, Trond wrote: > On Wed, 2012-11-14 at 16:42 -0500, J. Bruce Fields wrote: > > Simo's patches use them for upcalls to svcgssd. Those will always be > > done from server threads. > > Any reason why you can't set that up when you start nfsd? Oh,

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread Myklebust, Trond
On Wed, 2012-11-14 at 16:42 -0500, J. Bruce Fields wrote: > On Wed, Nov 14, 2012 at 09:36:33PM +, Myklebust, Trond wrote: > > On Wed, 2012-11-14 at 16:01 -0500, J. Bruce Fields wrote: > > > On Mon, Nov 12, 2012 at 12:37:54PM +0400, Stanislav Kinsbursky wrote: > > > > 07.11.2012 22:33, J. Bruce

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2012 at 09:36:33PM +, Myklebust, Trond wrote: > On Wed, 2012-11-14 at 16:01 -0500, J. Bruce Fields wrote: > > On Mon, Nov 12, 2012 at 12:37:54PM +0400, Stanislav Kinsbursky wrote: > > > 07.11.2012 22:33, J. Bruce Fields пишет: > > > >On Tue, Nov 06, 2012 at 08:36:05AM -0500, J.

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread Myklebust, Trond
On Wed, 2012-11-14 at 16:01 -0500, J. Bruce Fields wrote: > On Mon, Nov 12, 2012 at 12:37:54PM +0400, Stanislav Kinsbursky wrote: > > 07.11.2012 22:33, J. Bruce Fields пишет: > > >On Tue, Nov 06, 2012 at 08:36:05AM -0500, J. Bruce Fields wrote: > > >>On Tue, Nov 06, 2012 at 08:10:18AM -0500,

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread J. Bruce Fields
On Mon, Nov 12, 2012 at 12:37:54PM +0400, Stanislav Kinsbursky wrote: > 07.11.2012 22:33, J. Bruce Fields пишет: > >On Tue, Nov 06, 2012 at 08:36:05AM -0500, J. Bruce Fields wrote: > >>On Tue, Nov 06, 2012 at 08:10:18AM -0500, Christoph Hellwig wrote: > >>>On Tue, Nov 06, 2012 at 08:07:06AM -0500,

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread J. Bruce Fields
On Mon, Nov 12, 2012 at 12:37:54PM +0400, Stanislav Kinsbursky wrote: 07.11.2012 22:33, J. Bruce Fields пишет: On Tue, Nov 06, 2012 at 08:36:05AM -0500, J. Bruce Fields wrote: On Tue, Nov 06, 2012 at 08:10:18AM -0500, Christoph Hellwig wrote: On Tue, Nov 06, 2012 at 08:07:06AM -0500, J. Bruce

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread Myklebust, Trond
On Wed, 2012-11-14 at 16:01 -0500, J. Bruce Fields wrote: On Mon, Nov 12, 2012 at 12:37:54PM +0400, Stanislav Kinsbursky wrote: 07.11.2012 22:33, J. Bruce Fields пишет: On Tue, Nov 06, 2012 at 08:36:05AM -0500, J. Bruce Fields wrote: On Tue, Nov 06, 2012 at 08:10:18AM -0500, Christoph

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2012 at 09:36:33PM +, Myklebust, Trond wrote: On Wed, 2012-11-14 at 16:01 -0500, J. Bruce Fields wrote: On Mon, Nov 12, 2012 at 12:37:54PM +0400, Stanislav Kinsbursky wrote: 07.11.2012 22:33, J. Bruce Fields пишет: On Tue, Nov 06, 2012 at 08:36:05AM -0500, J. Bruce

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread Myklebust, Trond
On Wed, 2012-11-14 at 16:42 -0500, J. Bruce Fields wrote: On Wed, Nov 14, 2012 at 09:36:33PM +, Myklebust, Trond wrote: On Wed, 2012-11-14 at 16:01 -0500, J. Bruce Fields wrote: On Mon, Nov 12, 2012 at 12:37:54PM +0400, Stanislav Kinsbursky wrote: 07.11.2012 22:33, J. Bruce Fields

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2012 at 09:51:33PM +, Myklebust, Trond wrote: On Wed, 2012-11-14 at 16:42 -0500, J. Bruce Fields wrote: Simo's patches use them for upcalls to svcgssd. Those will always be done from server threads. Any reason why you can't set that up when you start nfsd? Oh, right,

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread Eric W. Biederman
J. Bruce Fields bfie...@fieldses.org writes: On Wed, Nov 14, 2012 at 09:51:33PM +, Myklebust, Trond wrote: On Wed, 2012-11-14 at 16:42 -0500, J. Bruce Fields wrote: Simo's patches use them for upcalls to svcgssd. Those will always be done from server threads. Any reason why you

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-12 Thread Stanislav Kinsbursky
07.11.2012 22:33, J. Bruce Fields пишет: On Tue, Nov 06, 2012 at 08:36:05AM -0500, J. Bruce Fields wrote: On Tue, Nov 06, 2012 at 08:10:18AM -0500, Christoph Hellwig wrote: On Tue, Nov 06, 2012 at 08:07:06AM -0500, J. Bruce Fields wrote: So you're worried that a bug in the nfs code could

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-12 Thread Stanislav Kinsbursky
07.11.2012 22:33, J. Bruce Fields пишет: On Tue, Nov 06, 2012 at 08:36:05AM -0500, J. Bruce Fields wrote: On Tue, Nov 06, 2012 at 08:10:18AM -0500, Christoph Hellwig wrote: On Tue, Nov 06, 2012 at 08:07:06AM -0500, J. Bruce Fields wrote: So you're worried that a bug in the nfs code could

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-07 Thread J. Bruce Fields
On Tue, Nov 06, 2012 at 08:36:05AM -0500, J. Bruce Fields wrote: > On Tue, Nov 06, 2012 at 08:10:18AM -0500, Christoph Hellwig wrote: > > On Tue, Nov 06, 2012 at 08:07:06AM -0500, J. Bruce Fields wrote: > > > So you're worried that a bug in the nfs code could modify the root and > > > then not

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-07 Thread J. Bruce Fields
On Tue, Nov 06, 2012 at 08:36:05AM -0500, J. Bruce Fields wrote: On Tue, Nov 06, 2012 at 08:10:18AM -0500, Christoph Hellwig wrote: On Tue, Nov 06, 2012 at 08:07:06AM -0500, J. Bruce Fields wrote: So you're worried that a bug in the nfs code could modify the root and then not restore it?

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread J. Bruce Fields
On Tue, Nov 06, 2012 at 08:10:18AM -0500, Christoph Hellwig wrote: > On Tue, Nov 06, 2012 at 08:07:06AM -0500, J. Bruce Fields wrote: > > So you're worried that a bug in the nfs code could modify the root and > > then not restore it? > > At least the link you pointed to earlier never sets it

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread Christoph Hellwig
On Tue, Nov 06, 2012 at 08:07:06AM -0500, J. Bruce Fields wrote: > So you're worried that a bug in the nfs code could modify the root and > then not restore it? At least the link you pointed to earlier never sets it back. Instead of messing with it I'd rather have the sunrpc code use

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread J. Bruce Fields
On Tue, Nov 06, 2012 at 07:40:35AM -0500, Christoph Hellwig wrote: > On Tue, Nov 06, 2012 at 07:06:42AM -0500, J. Bruce Fields wrote: > > On Tue, Nov 06, 2012 at 02:14:50PM +0400, Stanislav Kinsbursky wrote: > > > 09.10.2012 23:35, J. Bruce Fields ??: > > > >Cc'ing Eric since I seem to

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread J. Bruce Fields
On Tue, Nov 06, 2012 at 04:11:11PM +0400, Stanislav Kinsbursky wrote: > 06.11.2012 16:06, J. Bruce Fields пишет: > >On Tue, Nov 06, 2012 at 02:14:50PM +0400, Stanislav Kinsbursky wrote: > >>09.10.2012 23:35, J. Bruce Fields пишет: > >>>Cc'ing Eric since I seem to recall he suggested doing it this

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread Christoph Hellwig
On Tue, Nov 06, 2012 at 07:06:42AM -0500, J. Bruce Fields wrote: > On Tue, Nov 06, 2012 at 02:14:50PM +0400, Stanislav Kinsbursky wrote: > > 09.10.2012 23:35, J. Bruce Fields ??: > > >Cc'ing Eric since I seem to recall he suggested doing it this way? > > > > > >Seems OK to me, but maybe

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread Stanislav Kinsbursky
06.11.2012 16:06, J. Bruce Fields пишет: On Tue, Nov 06, 2012 at 02:14:50PM +0400, Stanislav Kinsbursky wrote: 09.10.2012 23:35, J. Bruce Fields пишет: Cc'ing Eric since I seem to recall he suggested doing it this way? Seems OK to me, but maybe that swap_root should be in common code? (Or

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread J. Bruce Fields
On Tue, Nov 06, 2012 at 02:14:50PM +0400, Stanislav Kinsbursky wrote: > 09.10.2012 23:35, J. Bruce Fields пишет: > >Cc'ing Eric since I seem to recall he suggested doing it this way? > > > >Seems OK to me, but maybe that swap_root should be in common code? (Or > >maybe we could use

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread Stanislav Kinsbursky
09.10.2012 23:35, J. Bruce Fields пишет: Cc'ing Eric since I seem to recall he suggested doing it this way? Seems OK to me, but maybe that swap_root should be in common code? (Or maybe we could use set_fs_root()?) This patch is not good since, as Eric mentioned, all kernel threads share

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread Stanislav Kinsbursky
09.10.2012 23:35, J. Bruce Fields пишет: Cc'ing Eric since I seem to recall he suggested doing it this way? Seems OK to me, but maybe that swap_root should be in common code? (Or maybe we could use set_fs_root()?) This patch is not good since, as Eric mentioned, all kernel threads share

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread J. Bruce Fields
On Tue, Nov 06, 2012 at 02:14:50PM +0400, Stanislav Kinsbursky wrote: 09.10.2012 23:35, J. Bruce Fields пишет: Cc'ing Eric since I seem to recall he suggested doing it this way? Seems OK to me, but maybe that swap_root should be in common code? (Or maybe we could use set_fs_root()?)

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread Stanislav Kinsbursky
06.11.2012 16:06, J. Bruce Fields пишет: On Tue, Nov 06, 2012 at 02:14:50PM +0400, Stanislav Kinsbursky wrote: 09.10.2012 23:35, J. Bruce Fields пишет: Cc'ing Eric since I seem to recall he suggested doing it this way? Seems OK to me, but maybe that swap_root should be in common code? (Or

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread Christoph Hellwig
On Tue, Nov 06, 2012 at 07:06:42AM -0500, J. Bruce Fields wrote: On Tue, Nov 06, 2012 at 02:14:50PM +0400, Stanislav Kinsbursky wrote: 09.10.2012 23:35, J. Bruce Fields ??: Cc'ing Eric since I seem to recall he suggested doing it this way? Seems OK to me, but maybe that swap_root

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread J. Bruce Fields
On Tue, Nov 06, 2012 at 04:11:11PM +0400, Stanislav Kinsbursky wrote: 06.11.2012 16:06, J. Bruce Fields пишет: On Tue, Nov 06, 2012 at 02:14:50PM +0400, Stanislav Kinsbursky wrote: 09.10.2012 23:35, J. Bruce Fields пишет: Cc'ing Eric since I seem to recall he suggested doing it this way?

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread J. Bruce Fields
On Tue, Nov 06, 2012 at 07:40:35AM -0500, Christoph Hellwig wrote: On Tue, Nov 06, 2012 at 07:06:42AM -0500, J. Bruce Fields wrote: On Tue, Nov 06, 2012 at 02:14:50PM +0400, Stanislav Kinsbursky wrote: 09.10.2012 23:35, J. Bruce Fields ??: Cc'ing Eric since I seem to recall he

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread Christoph Hellwig
On Tue, Nov 06, 2012 at 08:07:06AM -0500, J. Bruce Fields wrote: So you're worried that a bug in the nfs code could modify the root and then not restore it? At least the link you pointed to earlier never sets it back. Instead of messing with it I'd rather have the sunrpc code use

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-06 Thread J. Bruce Fields
On Tue, Nov 06, 2012 at 08:10:18AM -0500, Christoph Hellwig wrote: On Tue, Nov 06, 2012 at 08:07:06AM -0500, J. Bruce Fields wrote: So you're worried that a bug in the nfs code could modify the root and then not restore it? At least the link you pointed to earlier never sets it back.

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-26 Thread J. Bruce Fields
On Wed, Oct 10, 2012 at 02:32:28PM +0400, Stanislav Kinsbursky wrote: > 10.10.2012 05:23, J. Bruce Fields пишет: > >On Tue, Oct 09, 2012 at 03:47:42PM -0700, Eric W. Biederman wrote: > >>"J. Bruce Fields" writes: > >> > >>>On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: >

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-26 Thread J. Bruce Fields
On Wed, Oct 10, 2012 at 02:32:28PM +0400, Stanislav Kinsbursky wrote: 10.10.2012 05:23, J. Bruce Fields пишет: On Tue, Oct 09, 2012 at 03:47:42PM -0700, Eric W. Biederman wrote: J. Bruce Fields bfie...@fieldses.org writes: On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote:

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-10 Thread Stanislav Kinsbursky
10.10.2012 05:23, J. Bruce Fields пишет: On Tue, Oct 09, 2012 at 03:47:42PM -0700, Eric W. Biederman wrote: "J. Bruce Fields" writes: On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: "Myklebust, Trond" writes: On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote:

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-10 Thread Stanislav Kinsbursky
10.10.2012 05:23, J. Bruce Fields пишет: On Tue, Oct 09, 2012 at 03:47:42PM -0700, Eric W. Biederman wrote: J. Bruce Fields bfie...@fieldses.org writes: On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: Myklebust, Trond trond.mykleb...@netapp.com writes: On Tue, 2012-10-09

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Stanislav Kinsbursky
10.10.2012 06:00, Eric W. Biederman пишет: ebied...@xmission.com (Eric W. Biederman) writes: "J. Bruce Fields" writes: On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: "Myklebust, Trond" writes: On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: Cc'ing Eric

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Stanislav Kinsbursky
10.10.2012 02:47, Eric W. Biederman пишет: "J. Bruce Fields" writes: On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: "Myklebust, Trond" writes: On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: Cc'ing Eric since I seem to recall he suggested doing it this way?

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > "J. Bruce Fields" writes: > >> On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: >>> "Myklebust, Trond" writes: >>> >>> > On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: >>> >> Cc'ing Eric since I seem to recall he

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread J. Bruce Fields
On Tue, Oct 09, 2012 at 03:47:42PM -0700, Eric W. Biederman wrote: > "J. Bruce Fields" writes: > > > On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: > >> "Myklebust, Trond" writes: > >> > >> > On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: > >> >> Cc'ing Eric

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Eric W. Biederman
"J. Bruce Fields" writes: > On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: >> "Myklebust, Trond" writes: >> >> > On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: >> >> Cc'ing Eric since I seem to recall he suggested doing it this way? >> >> Yes. On second look

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread J. Bruce Fields
On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: > "Myklebust, Trond" writes: > > > On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: > >> Cc'ing Eric since I seem to recall he suggested doing it this way? > > Yes. On second look setting fs->root won't work. We need

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Eric W. Biederman
"Myklebust, Trond" writes: > On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: >> Cc'ing Eric since I seem to recall he suggested doing it this way? Yes. On second look setting fs->root won't work. We need to change fs. The problem is that by default all kernel threads share fs so

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Myklebust, Trond
On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: > Cc'ing Eric since I seem to recall he suggested doing it this way? > > Seems OK to me, but maybe that swap_root should be in common code? (Or > maybe we could use set_fs_root()?) > > I'm assuming it's up to Trond to take this.--b. I'm

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread J. Bruce Fields
Cc'ing Eric since I seem to recall he suggested doing it this way? Seems OK to me, but maybe that swap_root should be in common code? (Or maybe we could use set_fs_root()?) I'm assuming it's up to Trond to take this.--b. On Mon, Oct 08, 2012 at 02:56:32PM +0400, Stanislav Kinsbursky wrote: >

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread J. Bruce Fields
Cc'ing Eric since I seem to recall he suggested doing it this way? Seems OK to me, but maybe that swap_root should be in common code? (Or maybe we could use set_fs_root()?) I'm assuming it's up to Trond to take this.--b. On Mon, Oct 08, 2012 at 02:56:32PM +0400, Stanislav Kinsbursky wrote:

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Myklebust, Trond
On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: Cc'ing Eric since I seem to recall he suggested doing it this way? Seems OK to me, but maybe that swap_root should be in common code? (Or maybe we could use set_fs_root()?) I'm assuming it's up to Trond to take this.--b. I'm

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Eric W. Biederman
Myklebust, Trond trond.mykleb...@netapp.com writes: On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: Cc'ing Eric since I seem to recall he suggested doing it this way? Yes. On second look setting fs-root won't work. We need to change fs. The problem is that by default all kernel

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread J. Bruce Fields
On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: Myklebust, Trond trond.mykleb...@netapp.com writes: On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: Cc'ing Eric since I seem to recall he suggested doing it this way? Yes. On second look setting fs-root won't

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Eric W. Biederman
J. Bruce Fields bfie...@fieldses.org writes: On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: Myklebust, Trond trond.mykleb...@netapp.com writes: On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: Cc'ing Eric since I seem to recall he suggested doing it this way?

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread J. Bruce Fields
On Tue, Oct 09, 2012 at 03:47:42PM -0700, Eric W. Biederman wrote: J. Bruce Fields bfie...@fieldses.org writes: On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: Myklebust, Trond trond.mykleb...@netapp.com writes: On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: J. Bruce Fields bfie...@fieldses.org writes: On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: Myklebust, Trond trond.mykleb...@netapp.com writes: On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: Cc'ing Eric

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Stanislav Kinsbursky
10.10.2012 02:47, Eric W. Biederman пишет: J. Bruce Fields bfie...@fieldses.org writes: On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: Myklebust, Trond trond.mykleb...@netapp.com writes: On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: Cc'ing Eric since I seem

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Stanislav Kinsbursky
10.10.2012 06:00, Eric W. Biederman пишет: ebied...@xmission.com (Eric W. Biederman) writes: J. Bruce Fields bfie...@fieldses.org writes: On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: Myklebust, Trond trond.mykleb...@netapp.com writes: On Tue, 2012-10-09 at 15:35

[PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-08 Thread Stanislav Kinsbursky
Today, there is a problem in connecting of local SUNRPC thansports. These transports uses UNIX sockets and connection itself is done by rpciod workqueue. But all local transports are connecting in rpciod context. I.e. UNIX sockets lookup is done in context of process file system root. This works

[PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-08 Thread Stanislav Kinsbursky
Today, there is a problem in connecting of local SUNRPC thansports. These transports uses UNIX sockets and connection itself is done by rpciod workqueue. But all local transports are connecting in rpciod context. I.e. UNIX sockets lookup is done in context of process file system root. This works