Re: [PATCH v3] Staging: iio: accel: Fixed NULL comparison style

2015-12-19 Thread Jonathan Cameron
On 13/12/15 15:15, Bhaktipriya Shridhar wrote: > The variable u8 **rx_p, is a pointer-to-pointer and hence the check > should > be "if (!*rx_p)" and not "if (!rx_p)". > In the earlier version, checkpatch.pl gave the following check, which > was incorrect: > CHECK: Comparison to NULL could be

Re: [PATCH v3] Staging: iio: accel: Fixed NULL comparison style

2015-12-19 Thread Jonathan Cameron
On 13/12/15 15:15, Bhaktipriya Shridhar wrote: > The variable u8 **rx_p, is a pointer-to-pointer and hence the check > should > be "if (!*rx_p)" and not "if (!rx_p)". > In the earlier version, checkpatch.pl gave the following check, which > was incorrect: > CHECK: Comparison to NULL could be

[PATCH v3] Staging: iio: accel: Fixed NULL comparison style

2015-12-13 Thread Bhaktipriya Shridhar
The variable u8 **rx_p, is a pointer-to-pointer and hence the check should be "if (!*rx_p)" and not "if (!rx_p)". In the earlier version, checkpatch.pl gave the following check, which was incorrect: CHECK: Comparison to NULL could be written "!rx_p" + if (*rx_p == NULL) { Signed-off-by:

[PATCH v3] Staging: iio: accel: Fixed NULL comparison style

2015-12-13 Thread Bhaktipriya Shridhar
The variable u8 **rx_p, is a pointer-to-pointer and hence the check should be "if (!*rx_p)" and not "if (!rx_p)". In the earlier version, checkpatch.pl gave the following check, which was incorrect: CHECK: Comparison to NULL could be written "!rx_p" + if (*rx_p == NULL) { Signed-off-by: