Re: [PATCH v3] cpufreq: kryo: Add module remove and exit
On Monday, June 18, 2018 6:55:50 AM CEST Viresh Kumar wrote:
> On 17-06-18, 22:01, ilia@gmail.com wrote:
> > From: Ilia Lin
> >
> > Add device remove and module exit code to make the driver
> > functioning as a loadable module.
> >
> > Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
> > Signed-off-by: Ilia Lin
> > ---
> > drivers/cpufreq/qcom-cpufreq-kryo.c | 22 +++---
> > 1 file changed, 19 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c
> > b/drivers/cpufreq/qcom-cpufreq-kryo.c
> > index 74b9b93d511b..01bddacf5c3b 100644
> > --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> > +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> > @@ -42,6 +42,8 @@ enum _msm8996_version {
> > NUM_OF_MSM8996_VERSIONS,
> > };
> >
> > +struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
> > +
> > static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> > {
> > size_t len;
> > @@ -74,7 +76,6 @@ static enum _msm8996_version __init
> > qcom_cpufreq_kryo_get_msm_id(void)
> > static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> > {
> > struct opp_table *opp_tables[NR_CPUS] = {0};
> > - struct platform_device *cpufreq_dt_pdev;
> > enum _msm8996_version msm8996_version;
> > struct nvmem_cell *speedbin_nvmem;
> > struct device_node *np;
> > @@ -165,8 +166,15 @@ static int qcom_cpufreq_kryo_probe(struct
> > platform_device *pdev)
> > return ret;
> > }
> >
> > +static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
> > +{
> > + platform_device_unregister(cpufreq_dt_pdev);
> > + return 0;
> > +}
> > +
> > static struct platform_driver qcom_cpufreq_kryo_driver = {
> > .probe = qcom_cpufreq_kryo_probe,
> > + .remove = qcom_cpufreq_kryo_remove,
> > .driver = {
> > .name = "qcom-cpufreq-kryo",
> > },
> > @@ -201,8 +209,9 @@ static int __init qcom_cpufreq_kryo_init(void)
> > if (unlikely(ret < 0))
> > return ret;
> >
> > - ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
> > - "qcom-cpufreq-kryo", -1, NULL, 0));
> > + kryo_cpufreq_pdev = platform_device_register_simple(
> > + "qcom-cpufreq-kryo", -1, NULL, 0);
> > + ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
> > if (0 == ret)
> > return 0;
> >
> > @@ -211,5 +220,12 @@ static int __init qcom_cpufreq_kryo_init(void)
> > }
> > module_init(qcom_cpufreq_kryo_init);
> >
> > +static void __init qcom_cpufreq_kryo_exit(void)
> > +{
> > + platform_device_unregister(kryo_cpufreq_pdev);
> > + platform_driver_unregister(_cpufreq_kryo_driver);
> > +}
> > +module_exit(qcom_cpufreq_kryo_exit);
> > +
> > MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
> > MODULE_LICENSE("GPL v2");
>
> Acked-by: Viresh Kumar
Patch applied, thanks!
Re: [PATCH v3] cpufreq: kryo: Add module remove and exit
On Monday, June 18, 2018 6:55:50 AM CEST Viresh Kumar wrote:
> On 17-06-18, 22:01, ilia@gmail.com wrote:
> > From: Ilia Lin
> >
> > Add device remove and module exit code to make the driver
> > functioning as a loadable module.
> >
> > Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
> > Signed-off-by: Ilia Lin
> > ---
> > drivers/cpufreq/qcom-cpufreq-kryo.c | 22 +++---
> > 1 file changed, 19 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c
> > b/drivers/cpufreq/qcom-cpufreq-kryo.c
> > index 74b9b93d511b..01bddacf5c3b 100644
> > --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> > +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> > @@ -42,6 +42,8 @@ enum _msm8996_version {
> > NUM_OF_MSM8996_VERSIONS,
> > };
> >
> > +struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
> > +
> > static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> > {
> > size_t len;
> > @@ -74,7 +76,6 @@ static enum _msm8996_version __init
> > qcom_cpufreq_kryo_get_msm_id(void)
> > static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> > {
> > struct opp_table *opp_tables[NR_CPUS] = {0};
> > - struct platform_device *cpufreq_dt_pdev;
> > enum _msm8996_version msm8996_version;
> > struct nvmem_cell *speedbin_nvmem;
> > struct device_node *np;
> > @@ -165,8 +166,15 @@ static int qcom_cpufreq_kryo_probe(struct
> > platform_device *pdev)
> > return ret;
> > }
> >
> > +static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
> > +{
> > + platform_device_unregister(cpufreq_dt_pdev);
> > + return 0;
> > +}
> > +
> > static struct platform_driver qcom_cpufreq_kryo_driver = {
> > .probe = qcom_cpufreq_kryo_probe,
> > + .remove = qcom_cpufreq_kryo_remove,
> > .driver = {
> > .name = "qcom-cpufreq-kryo",
> > },
> > @@ -201,8 +209,9 @@ static int __init qcom_cpufreq_kryo_init(void)
> > if (unlikely(ret < 0))
> > return ret;
> >
> > - ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
> > - "qcom-cpufreq-kryo", -1, NULL, 0));
> > + kryo_cpufreq_pdev = platform_device_register_simple(
> > + "qcom-cpufreq-kryo", -1, NULL, 0);
> > + ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
> > if (0 == ret)
> > return 0;
> >
> > @@ -211,5 +220,12 @@ static int __init qcom_cpufreq_kryo_init(void)
> > }
> > module_init(qcom_cpufreq_kryo_init);
> >
> > +static void __init qcom_cpufreq_kryo_exit(void)
> > +{
> > + platform_device_unregister(kryo_cpufreq_pdev);
> > + platform_driver_unregister(_cpufreq_kryo_driver);
> > +}
> > +module_exit(qcom_cpufreq_kryo_exit);
> > +
> > MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
> > MODULE_LICENSE("GPL v2");
>
> Acked-by: Viresh Kumar
Patch applied, thanks!
Re: [PATCH v3] cpufreq: kryo: Add module remove and exit
On 17-06-18, 22:01, ilia@gmail.com wrote:
> From: Ilia Lin
>
> Add device remove and module exit code to make the driver
> functioning as a loadable module.
>
> Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
> Signed-off-by: Ilia Lin
> ---
> drivers/cpufreq/qcom-cpufreq-kryo.c | 22 +++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c
> b/drivers/cpufreq/qcom-cpufreq-kryo.c
> index 74b9b93d511b..01bddacf5c3b 100644
> --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> @@ -42,6 +42,8 @@ enum _msm8996_version {
> NUM_OF_MSM8996_VERSIONS,
> };
>
> +struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
> +
> static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> {
> size_t len;
> @@ -74,7 +76,6 @@ static enum _msm8996_version __init
> qcom_cpufreq_kryo_get_msm_id(void)
> static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> {
> struct opp_table *opp_tables[NR_CPUS] = {0};
> - struct platform_device *cpufreq_dt_pdev;
> enum _msm8996_version msm8996_version;
> struct nvmem_cell *speedbin_nvmem;
> struct device_node *np;
> @@ -165,8 +166,15 @@ static int qcom_cpufreq_kryo_probe(struct
> platform_device *pdev)
> return ret;
> }
>
> +static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
> +{
> + platform_device_unregister(cpufreq_dt_pdev);
> + return 0;
> +}
> +
> static struct platform_driver qcom_cpufreq_kryo_driver = {
> .probe = qcom_cpufreq_kryo_probe,
> + .remove = qcom_cpufreq_kryo_remove,
> .driver = {
> .name = "qcom-cpufreq-kryo",
> },
> @@ -201,8 +209,9 @@ static int __init qcom_cpufreq_kryo_init(void)
> if (unlikely(ret < 0))
> return ret;
>
> - ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
> - "qcom-cpufreq-kryo", -1, NULL, 0));
> + kryo_cpufreq_pdev = platform_device_register_simple(
> + "qcom-cpufreq-kryo", -1, NULL, 0);
> + ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
> if (0 == ret)
> return 0;
>
> @@ -211,5 +220,12 @@ static int __init qcom_cpufreq_kryo_init(void)
> }
> module_init(qcom_cpufreq_kryo_init);
>
> +static void __init qcom_cpufreq_kryo_exit(void)
> +{
> + platform_device_unregister(kryo_cpufreq_pdev);
> + platform_driver_unregister(_cpufreq_kryo_driver);
> +}
> +module_exit(qcom_cpufreq_kryo_exit);
> +
> MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
> MODULE_LICENSE("GPL v2");
Acked-by: Viresh Kumar
--
viresh
Re: [PATCH v3] cpufreq: kryo: Add module remove and exit
On 17-06-18, 22:01, ilia@gmail.com wrote:
> From: Ilia Lin
>
> Add device remove and module exit code to make the driver
> functioning as a loadable module.
>
> Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
> Signed-off-by: Ilia Lin
> ---
> drivers/cpufreq/qcom-cpufreq-kryo.c | 22 +++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c
> b/drivers/cpufreq/qcom-cpufreq-kryo.c
> index 74b9b93d511b..01bddacf5c3b 100644
> --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> @@ -42,6 +42,8 @@ enum _msm8996_version {
> NUM_OF_MSM8996_VERSIONS,
> };
>
> +struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
> +
> static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> {
> size_t len;
> @@ -74,7 +76,6 @@ static enum _msm8996_version __init
> qcom_cpufreq_kryo_get_msm_id(void)
> static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> {
> struct opp_table *opp_tables[NR_CPUS] = {0};
> - struct platform_device *cpufreq_dt_pdev;
> enum _msm8996_version msm8996_version;
> struct nvmem_cell *speedbin_nvmem;
> struct device_node *np;
> @@ -165,8 +166,15 @@ static int qcom_cpufreq_kryo_probe(struct
> platform_device *pdev)
> return ret;
> }
>
> +static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
> +{
> + platform_device_unregister(cpufreq_dt_pdev);
> + return 0;
> +}
> +
> static struct platform_driver qcom_cpufreq_kryo_driver = {
> .probe = qcom_cpufreq_kryo_probe,
> + .remove = qcom_cpufreq_kryo_remove,
> .driver = {
> .name = "qcom-cpufreq-kryo",
> },
> @@ -201,8 +209,9 @@ static int __init qcom_cpufreq_kryo_init(void)
> if (unlikely(ret < 0))
> return ret;
>
> - ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
> - "qcom-cpufreq-kryo", -1, NULL, 0));
> + kryo_cpufreq_pdev = platform_device_register_simple(
> + "qcom-cpufreq-kryo", -1, NULL, 0);
> + ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
> if (0 == ret)
> return 0;
>
> @@ -211,5 +220,12 @@ static int __init qcom_cpufreq_kryo_init(void)
> }
> module_init(qcom_cpufreq_kryo_init);
>
> +static void __init qcom_cpufreq_kryo_exit(void)
> +{
> + platform_device_unregister(kryo_cpufreq_pdev);
> + platform_driver_unregister(_cpufreq_kryo_driver);
> +}
> +module_exit(qcom_cpufreq_kryo_exit);
> +
> MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
> MODULE_LICENSE("GPL v2");
Acked-by: Viresh Kumar
--
viresh
[PATCH v3] cpufreq: kryo: Add module remove and exit
From: Ilia Lin
Add device remove and module exit code to make the driver
functioning as a loadable module.
Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
Signed-off-by: Ilia Lin
---
drivers/cpufreq/qcom-cpufreq-kryo.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c
b/drivers/cpufreq/qcom-cpufreq-kryo.c
index 74b9b93d511b..01bddacf5c3b 100644
--- a/drivers/cpufreq/qcom-cpufreq-kryo.c
+++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
@@ -42,6 +42,8 @@ enum _msm8996_version {
NUM_OF_MSM8996_VERSIONS,
};
+struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
+
static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
{
size_t len;
@@ -74,7 +76,6 @@ static enum _msm8996_version __init
qcom_cpufreq_kryo_get_msm_id(void)
static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
{
struct opp_table *opp_tables[NR_CPUS] = {0};
- struct platform_device *cpufreq_dt_pdev;
enum _msm8996_version msm8996_version;
struct nvmem_cell *speedbin_nvmem;
struct device_node *np;
@@ -165,8 +166,15 @@ static int qcom_cpufreq_kryo_probe(struct platform_device
*pdev)
return ret;
}
+static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
+{
+ platform_device_unregister(cpufreq_dt_pdev);
+ return 0;
+}
+
static struct platform_driver qcom_cpufreq_kryo_driver = {
.probe = qcom_cpufreq_kryo_probe,
+ .remove = qcom_cpufreq_kryo_remove,
.driver = {
.name = "qcom-cpufreq-kryo",
},
@@ -201,8 +209,9 @@ static int __init qcom_cpufreq_kryo_init(void)
if (unlikely(ret < 0))
return ret;
- ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
- "qcom-cpufreq-kryo", -1, NULL, 0));
+ kryo_cpufreq_pdev = platform_device_register_simple(
+ "qcom-cpufreq-kryo", -1, NULL, 0);
+ ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
if (0 == ret)
return 0;
@@ -211,5 +220,12 @@ static int __init qcom_cpufreq_kryo_init(void)
}
module_init(qcom_cpufreq_kryo_init);
+static void __init qcom_cpufreq_kryo_exit(void)
+{
+ platform_device_unregister(kryo_cpufreq_pdev);
+ platform_driver_unregister(_cpufreq_kryo_driver);
+}
+module_exit(qcom_cpufreq_kryo_exit);
+
MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
MODULE_LICENSE("GPL v2");
--
2.11.0
[PATCH v3] cpufreq: kryo: Add module remove and exit
From: Ilia Lin
Add device remove and module exit code to make the driver
functioning as a loadable module.
Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
Signed-off-by: Ilia Lin
---
drivers/cpufreq/qcom-cpufreq-kryo.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c
b/drivers/cpufreq/qcom-cpufreq-kryo.c
index 74b9b93d511b..01bddacf5c3b 100644
--- a/drivers/cpufreq/qcom-cpufreq-kryo.c
+++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
@@ -42,6 +42,8 @@ enum _msm8996_version {
NUM_OF_MSM8996_VERSIONS,
};
+struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
+
static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
{
size_t len;
@@ -74,7 +76,6 @@ static enum _msm8996_version __init
qcom_cpufreq_kryo_get_msm_id(void)
static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
{
struct opp_table *opp_tables[NR_CPUS] = {0};
- struct platform_device *cpufreq_dt_pdev;
enum _msm8996_version msm8996_version;
struct nvmem_cell *speedbin_nvmem;
struct device_node *np;
@@ -165,8 +166,15 @@ static int qcom_cpufreq_kryo_probe(struct platform_device
*pdev)
return ret;
}
+static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
+{
+ platform_device_unregister(cpufreq_dt_pdev);
+ return 0;
+}
+
static struct platform_driver qcom_cpufreq_kryo_driver = {
.probe = qcom_cpufreq_kryo_probe,
+ .remove = qcom_cpufreq_kryo_remove,
.driver = {
.name = "qcom-cpufreq-kryo",
},
@@ -201,8 +209,9 @@ static int __init qcom_cpufreq_kryo_init(void)
if (unlikely(ret < 0))
return ret;
- ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
- "qcom-cpufreq-kryo", -1, NULL, 0));
+ kryo_cpufreq_pdev = platform_device_register_simple(
+ "qcom-cpufreq-kryo", -1, NULL, 0);
+ ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
if (0 == ret)
return 0;
@@ -211,5 +220,12 @@ static int __init qcom_cpufreq_kryo_init(void)
}
module_init(qcom_cpufreq_kryo_init);
+static void __init qcom_cpufreq_kryo_exit(void)
+{
+ platform_device_unregister(kryo_cpufreq_pdev);
+ platform_driver_unregister(_cpufreq_kryo_driver);
+}
+module_exit(qcom_cpufreq_kryo_exit);
+
MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
MODULE_LICENSE("GPL v2");
--
2.11.0
