Re: [PATCH v3] dmaengine: fsl-edma: add PM suspend/resume support

2015-10-28 Thread Vinod Koul
On Tue, Oct 27, 2015 at 03:58:31AM +, Yao Yuan wrote: > Hi Vinod, > Please do not top post > Thanks for your review. > I did the test and it seems that it should be ok when CONFIG_PM is not > defined. > So I removed the protection code to make it more readable. > Do you think is it ok?

Re: [PATCH v3] dmaengine: fsl-edma: add PM suspend/resume support

2015-10-28 Thread Vinod Koul
On Tue, Oct 27, 2015 at 03:58:31AM +, Yao Yuan wrote: > Hi Vinod, > Please do not top post > Thanks for your review. > I did the test and it seems that it should be ok when CONFIG_PM is not > defined. > So I removed the protection code to make it more readable. > Do you think is it ok?

RE: [PATCH v3] dmaengine: fsl-edma: add PM suspend/resume support

2015-10-26 Thread Yao Yuan
el.com] > Sent: Tuesday, October 27, 2015 10:01 AM > To: Yuan Yao-B46683 > Cc: ste...@agner.ch; a...@arndb.de; dan.j.willi...@intel.com; > dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v3] dmaengine: fsl-edm

Re: [PATCH v3] dmaengine: fsl-edma: add PM suspend/resume support

2015-10-26 Thread Vinod Koul
On Mon, Oct 19, 2015 at 04:31:05PM +0800, Yuan Yao wrote: The patch overall looks fine, but > > +static int fsl_edma_suspend_late(struct device *dev) This needs protection and will have build failure when CONFIG_PM is not defined > +{ > + struct fsl_edma_engine *fsl_edma =

Re: [PATCH v3] dmaengine: fsl-edma: add PM suspend/resume support

2015-10-26 Thread Vinod Koul
On Mon, Oct 19, 2015 at 04:31:05PM +0800, Yuan Yao wrote: The patch overall looks fine, but > > +static int fsl_edma_suspend_late(struct device *dev) This needs protection and will have build failure when CONFIG_PM is not defined > +{ > + struct fsl_edma_engine *fsl_edma =

RE: [PATCH v3] dmaengine: fsl-edma: add PM suspend/resume support

2015-10-26 Thread Yao Yuan
el.com] > Sent: Tuesday, October 27, 2015 10:01 AM > To: Yuan Yao-B46683 <yao.y...@freescale.com> > Cc: ste...@agner.ch; a...@arndb.de; dan.j.willi...@intel.com; > dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re:

[PATCH v3] dmaengine: fsl-edma: add PM suspend/resume support

2015-10-19 Thread Yuan Yao
This add power management suspend/resume support for the fsl-edma driver. eDMA acted as a basic function used by others. What it needs to do is the two steps below to support power management. In fsl_edma_suspend_late: Check whether the DMA chan is idle, if it is not idle disable DMA request.

[PATCH v3] dmaengine: fsl-edma: add PM suspend/resume support

2015-10-19 Thread Yuan Yao
This add power management suspend/resume support for the fsl-edma driver. eDMA acted as a basic function used by others. What it needs to do is the two steps below to support power management. In fsl_edma_suspend_late: Check whether the DMA chan is idle, if it is not idle disable DMA request.