Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-06-11 Thread Fengguang Wu
On Thu, Jun 11, 2015 at 05:36:00PM -0700, Christopher Li wrote: > n Sun, Apr 26, 2015 at 10:20 PM, Fengguang Wu wrote: > >> > > >> > drivers/dma/xgene-dma.c:2088:1: sparse: symbol > >> > '__UNIQUE_ID_author__COUNTER__' has multiple initializers (originally > >> > initialized at

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-06-11 Thread Christopher Li
On Sun, Apr 26, 2015 at 10:20 PM, Fengguang Wu wrote: >> > >> > drivers/dma/xgene-dma.c:2088:1: sparse: symbol >> > '__UNIQUE_ID_author__COUNTER__' has multiple initializers (originally >> > initialized at drivers/dma/xgene-dma.c:2087) >> > So, I kept only one author here. >> No that is not

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-06-11 Thread Christopher Li
On Sun, Apr 26, 2015 at 10:20 PM, Fengguang Wu fengguang...@intel.com wrote: drivers/dma/xgene-dma.c:2088:1: sparse: symbol '__UNIQUE_ID_author__COUNTER__' has multiple initializers (originally initialized at drivers/dma/xgene-dma.c:2087) So, I kept only one author here. No that is not

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-06-11 Thread Fengguang Wu
On Thu, Jun 11, 2015 at 05:36:00PM -0700, Christopher Li wrote: n Sun, Apr 26, 2015 at 10:20 PM, Fengguang Wu fengguang...@intel.com wrote: drivers/dma/xgene-dma.c:2088:1: sparse: symbol '__UNIQUE_ID_author__COUNTER__' has multiple initializers (originally initialized at

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-26 Thread Fengguang Wu
On Mon, Apr 27, 2015 at 08:43:15AM +0530, Vinod Koul wrote: > On Mon, Apr 20, 2015 at 08:38:18AM +0530, Rameshwar Sahu wrote: > > Hi Vinod, > >> >> @@ -2085,6 +2043,5 @@ module_platform_driver(xgene_dma_driver); > > >> > > >> MODULE_DESCRIPTION("APM X-Gene SoC DMA driver"); > > >>

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-26 Thread Vinod Koul
On Mon, Apr 20, 2015 at 08:38:18AM +0530, Rameshwar Sahu wrote: > Hi Vinod, >> >> @@ -2085,6 +2043,5 @@ module_platform_driver(xgene_dma_driver); > >> > >> MODULE_DESCRIPTION("APM X-Gene SoC DMA driver"); > >> MODULE_AUTHOR("Rameshwar Prasad Sahu "); > >> -MODULE_AUTHOR("Loc Ho "); > > And why

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-26 Thread Fengguang Wu
On Mon, Apr 27, 2015 at 08:43:15AM +0530, Vinod Koul wrote: On Mon, Apr 20, 2015 at 08:38:18AM +0530, Rameshwar Sahu wrote: Hi Vinod, @@ -2085,6 +2043,5 @@ module_platform_driver(xgene_dma_driver); MODULE_DESCRIPTION(APM X-Gene SoC DMA driver); MODULE_AUTHOR(Rameshwar Prasad Sahu

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-26 Thread Vinod Koul
On Mon, Apr 20, 2015 at 08:38:18AM +0530, Rameshwar Sahu wrote: Hi Vinod, @@ -2085,6 +2043,5 @@ module_platform_driver(xgene_dma_driver); MODULE_DESCRIPTION(APM X-Gene SoC DMA driver); MODULE_AUTHOR(Rameshwar Prasad Sahu rs...@apm.com); -MODULE_AUTHOR(Loc Ho l...@apm.com); And why

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-19 Thread Rameshwar Sahu
Hi Vinod, On Fri, Apr 17, 2015 at 11:59 PM, Vinod Koul wrote: > >> /* Get DMA error interrupt */ >> @@ -2076,7 +2035,6 @@ static struct platform_driver xgene_dma_driver = { >> .remove = xgene_dma_remove, >> .driver = { >> .name = "X-Gene-DMA", >> -

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-19 Thread Rameshwar Sahu
Hi Vinod, On Fri, Apr 17, 2015 at 11:59 PM, Vinod Koul vinod.k...@intel.com wrote: /* Get DMA error interrupt */ @@ -2076,7 +2035,6 @@ static struct platform_driver xgene_dma_driver = { .remove = xgene_dma_remove, .driver = { .name = X-Gene-DMA, -

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-17 Thread Vinod Koul
> /* Get DMA error interrupt */ > @@ -2076,7 +2035,6 @@ static struct platform_driver xgene_dma_driver = { > .remove = xgene_dma_remove, > .driver = { > .name = "X-Gene-DMA", > - .owner = THIS_MODULE, I have already applied a patch for this >

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-17 Thread Arnd Bergmann
On Friday 17 April 2015 14:41:02 Rameshwar Sahu wrote: > >> > >> -static void *xgene_dma_lookup_ext8(u64 *desc, int idx) > >> +static __le64 *xgene_dma_lookup_ext8(struct xgene_dma_desc_hw *desc, int > >> idx) > >> { > >> - return (idx % 2) ? (desc + idx - 1) : (desc + idx + 1); > >> +

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-17 Thread Rameshwar Sahu
Hi Arnd, On Fri, Apr 17, 2015 at 2:19 PM, Arnd Bergmann wrote: > On Friday 17 April 2015 01:01:13 Rameshwar Prasad Sahu wrote: >> v3 changes: >> * Minor changes in length setting in DMA descriptor >> >> v2 changes: >> * Code cleanup >> * Changed way of setting DMA descriptors

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-17 Thread Arnd Bergmann
On Friday 17 April 2015 01:01:13 Rameshwar Prasad Sahu wrote: > v3 changes: > * Minor changes in length setting in DMA descriptor > > v2 changes: > * Code cleanup > * Changed way of setting DMA descriptors for big-endian > > This patch fixes compilation sparse warnings like

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-17 Thread Arnd Bergmann
On Friday 17 April 2015 01:01:13 Rameshwar Prasad Sahu wrote: v3 changes: * Minor changes in length setting in DMA descriptor v2 changes: * Code cleanup * Changed way of setting DMA descriptors for big-endian This patch fixes compilation sparse warnings like incorrect

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-17 Thread Arnd Bergmann
On Friday 17 April 2015 14:41:02 Rameshwar Sahu wrote: -static void *xgene_dma_lookup_ext8(u64 *desc, int idx) +static __le64 *xgene_dma_lookup_ext8(struct xgene_dma_desc_hw *desc, int idx) { - return (idx % 2) ? (desc + idx - 1) : (desc + idx + 1); + switch (idx) { +

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-17 Thread Rameshwar Sahu
Hi Arnd, On Fri, Apr 17, 2015 at 2:19 PM, Arnd Bergmann a...@arndb.de wrote: On Friday 17 April 2015 01:01:13 Rameshwar Prasad Sahu wrote: v3 changes: * Minor changes in length setting in DMA descriptor v2 changes: * Code cleanup * Changed way of setting DMA descriptors

Re: [PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-17 Thread Vinod Koul
/* Get DMA error interrupt */ @@ -2076,7 +2035,6 @@ static struct platform_driver xgene_dma_driver = { .remove = xgene_dma_remove, .driver = { .name = X-Gene-DMA, - .owner = THIS_MODULE, I have already applied a patch for this

[PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-16 Thread Rameshwar Prasad Sahu
v3 changes: * Minor changes in length setting in DMA descriptor v2 changes: * Code cleanup * Changed way of setting DMA descriptors for big-endian This patch fixes compilation sparse warnings like incorrect type in assignment (different base types), cast to restricted

[PATCH v3] dmaengine: xgene-dma: Fix sparse wannings and coccinelle warnings

2015-04-16 Thread Rameshwar Prasad Sahu
v3 changes: * Minor changes in length setting in DMA descriptor v2 changes: * Code cleanup * Changed way of setting DMA descriptors for big-endian This patch fixes compilation sparse warnings like incorrect type in assignment (different base types), cast to restricted