Re: [PATCH v3] ksm: Assist buddy allocator to assemble 1-order pages

2018-12-10 Thread Kirill Tkhai
Andrew, please, drop this patch. It misses, that the caller (i.e. cmp_and_merge_page()) is not symmetrical for page and tree_page (there is put_page(tree_page) in the caller). We could change try_to_merge_two_pages() arguments and to pass &rmap_item, &page, &tree_rmap_item and &tree_page from the

Re: [PATCH v3] ksm: Assist buddy allocator to assemble 1-order pages

2018-11-15 Thread Kirill Tkhai
On 10.11.2018 0:08, Andrew Morton wrote: > On Fri, 19 Oct 2018 15:33:39 +0300 Kirill Tkhai wrote: > >> v3: Comment improvements. >> v2: Style improvements. >> >> try_to_merge_two_pages() merges two pages, one of them >> is a page of currently scanned mm, the second is a page >> with identical has

Re: [PATCH v3] ksm: Assist buddy allocator to assemble 1-order pages

2018-11-09 Thread Andrew Morton
On Fri, 19 Oct 2018 15:33:39 +0300 Kirill Tkhai wrote: > v3: Comment improvements. > v2: Style improvements. > > try_to_merge_two_pages() merges two pages, one of them > is a page of currently scanned mm, the second is a page > with identical hash from unstable tree. Currently, we > merge the pa

[PATCH v3] ksm: Assist buddy allocator to assemble 1-order pages

2018-10-19 Thread Kirill Tkhai
v3: Comment improvements. v2: Style improvements. try_to_merge_two_pages() merges two pages, one of them is a page of currently scanned mm, the second is a page with identical hash from unstable tree. Currently, we merge the page from unstable tree into the first one, and then free it. The idea o