Re: [PATCH v3] mm, thp: introduce generic transparent huge page allocation interfaces

2017-12-07 Thread Du, Changbin
Hi Andrew, On Thu, Dec 07, 2017 at 03:45:19PM -0800, Andrew Morton wrote: > On Thu, 7 Dec 2017 18:54:19 +0800 changbin...@intel.com wrote: > > > From: Changbin Du [snip] > -static inline void prep_transhuge_page(struct page *page) {} > > +#define

Re: [PATCH v3] mm, thp: introduce generic transparent huge page allocation interfaces

2017-12-07 Thread Du, Changbin
Hi Andrew, On Thu, Dec 07, 2017 at 03:45:19PM -0800, Andrew Morton wrote: > On Thu, 7 Dec 2017 18:54:19 +0800 changbin...@intel.com wrote: > > > From: Changbin Du [snip] > -static inline void prep_transhuge_page(struct page *page) {} > > +#define alloc_transhuge_page_vma(gfp_mask, vma, addr)

Re: [PATCH v3] mm, thp: introduce generic transparent huge page allocation interfaces

2017-12-07 Thread Andrew Morton
On Thu, 7 Dec 2017 18:54:19 +0800 changbin...@intel.com wrote: > From: Changbin Du > > This patch introduced 4 new interfaces to allocate a prepared transparent > huge page. These interfaces merge distributed two-step allocation as simple > single step. And they can

Re: [PATCH v3] mm, thp: introduce generic transparent huge page allocation interfaces

2017-12-07 Thread Andrew Morton
On Thu, 7 Dec 2017 18:54:19 +0800 changbin...@intel.com wrote: > From: Changbin Du > > This patch introduced 4 new interfaces to allocate a prepared transparent > huge page. These interfaces merge distributed two-step allocation as simple > single step. And they can avoid issue like forget to

[PATCH v3] mm, thp: introduce generic transparent huge page allocation interfaces

2017-12-07 Thread changbin . du
From: Changbin Du This patch introduced 4 new interfaces to allocate a prepared transparent huge page. These interfaces merge distributed two-step allocation as simple single step. And they can avoid issue like forget to call prep_transhuge_page() or call it on wrong page.

[PATCH v3] mm, thp: introduce generic transparent huge page allocation interfaces

2017-12-07 Thread changbin . du
From: Changbin Du This patch introduced 4 new interfaces to allocate a prepared transparent huge page. These interfaces merge distributed two-step allocation as simple single step. And they can avoid issue like forget to call prep_transhuge_page() or call it on wrong page. A real fix: 40a899e