Re: [PATCH v3] mm: cma: support sysfs

2021-03-04 Thread Minchan Kim
On Wed, Mar 03, 2021 at 10:09:57PM -0800, Andrew Morton wrote: > On Wed, 3 Mar 2021 17:38:12 -0800 Minchan Kim wrote: > > > > > #endif > > > > char name[CMA_MAX_NAME]; > > > > +#ifdef CONFIG_CMA_SYSFS > > > > + struct cma_stat *stat; > > > > +#endif > > > > }; > > > > > > Why

Re: [PATCH v3] mm: cma: support sysfs

2021-03-03 Thread Andrew Morton
On Wed, 3 Mar 2021 17:38:12 -0800 Minchan Kim wrote: > > > #endif > > > char name[CMA_MAX_NAME]; > > > +#ifdef CONFIG_CMA_SYSFS > > > + struct cma_stat *stat; > > > +#endif > > > }; > > > > Why aren't the stat fields simply placed directly into struct cma_stat? > > It have a related long

Re: [PATCH v3] mm: cma: support sysfs

2021-03-03 Thread Minchan Kim
On Wed, Mar 03, 2021 at 02:44:49PM -0800, Andrew Morton wrote: > On Wed, 3 Mar 2021 12:50:53 -0800 Minchan Kim wrote: > > > Since CMA is getting used more widely, it's more important to > > keep monitoring CMA statistics for system health since it's > > directly related to user experience. > >

Re: [PATCH v3] mm: cma: support sysfs

2021-03-03 Thread Andrew Morton
On Wed, 3 Mar 2021 12:50:53 -0800 Minchan Kim wrote: > Since CMA is getting used more widely, it's more important to > keep monitoring CMA statistics for system health since it's > directly related to user experience. > > This patch introduces sysfs statistics for CMA, in order to provide >

[PATCH v3] mm: cma: support sysfs

2021-03-03 Thread Minchan Kim
Since CMA is getting used more widely, it's more important to keep monitoring CMA statistics for system health since it's directly related to user experience. This patch introduces sysfs statistics for CMA, in order to provide some basic monitoring of the CMA allocator. * the number of CMA page

Re: [PATCH v3] mm: cma: support sysfs

2021-02-10 Thread Minchan Kim
On Wed, Feb 10, 2021 at 12:05:48AM -0800, John Hubbard wrote: > On 2/9/21 11:55 PM, Minchan Kim wrote: > > Since CMA is getting used more widely, it's more important to > > keep monitoring CMA statistics for system health since it's > > directly related to user experience. > > > > This patch

Re: [PATCH v3] mm: cma: support sysfs

2021-02-10 Thread John Hubbard
On 2/9/21 11:55 PM, Minchan Kim wrote: Since CMA is getting used more widely, it's more important to keep monitoring CMA statistics for system health since it's directly related to user experience. This patch introduces sysfs statistics for CMA, in order to provide some basic monitoring of the

Re: [PATCH v3] mm: cma: support sysfs

2021-02-10 Thread Greg KH
On Tue, Feb 09, 2021 at 11:55:09PM -0800, Minchan Kim wrote: > Since CMA is getting used more widely, it's more important to > keep monitoring CMA statistics for system health since it's > directly related to user experience. > > This patch introduces sysfs statistics for CMA, in order to provide

[PATCH v3] mm: cma: support sysfs

2021-02-09 Thread Minchan Kim
Since CMA is getting used more widely, it's more important to keep monitoring CMA statistics for system health since it's directly related to user experience. This patch introduces sysfs statistics for CMA, in order to provide some basic monitoring of the CMA allocator. * the number of CMA page