Re: [PATCH v3] phy: samsung: Use readl_poll_timeout function

2020-07-08 Thread Krzysztof Kozlowski
On Wed, Jul 08, 2020 at 01:59:46PM +0530, Anand Moon wrote: > > Still you did not mention that you convert the function to use sleeping > > primitive. You also did not mention whether it is actually allowed in > > this context and I am not sure if you investigated it. > > > OK, I am not sure how

Re: [PATCH v3] phy: samsung: Use readl_poll_timeout function

2020-07-08 Thread Anand Moon
Hi Krzysztof, On Tue, 7 Jul 2020 at 17:06, Krzysztof Kozlowski wrote: > > On Tue, Jul 07, 2020 at 09:59:08AM +, Anand Moon wrote: > > Instead of a busy waiting loop while loop using udelay > > You doubled "loop". > I will fix this in the next version. > > use readl_poll_timeout function to

Re: [PATCH v3] phy: samsung: Use readl_poll_timeout function

2020-07-07 Thread Krzysztof Kozlowski
On Tue, Jul 07, 2020 at 09:59:08AM +, Anand Moon wrote: > Instead of a busy waiting loop while loop using udelay You doubled "loop". > use readl_poll_timeout function to check the condition > is met or timeout occurs in crport_handshake function. Still you did not mention that you convert

[PATCH v3] phy: samsung: Use readl_poll_timeout function

2020-07-07 Thread Anand Moon
Instead of a busy waiting loop while loop using udelay use readl_poll_timeout function to check the condition is met or timeout occurs in crport_handshake function. Fixes: d8c80bb3b55b ("phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800") Signed-off-by: Anand Moon --- Changes v3: