Re: [PATCH v3] regmap: regmap-irq/gpio-max77620: add level-irq support

2019-01-04 Thread Matti Vaittinen
On Thu, Jan 03, 2019 at 05:20:08PM +, Charles Keepax wrote: > On Wed, Jan 02, 2019 at 09:42:51AM +0200, Matti Vaittinen wrote: > > On Mon, Dec 31, 2018 at 07:11:27PM +, Mark Brown wrote: > > > On Fri, Dec 28, 2018 at 10:05:33AM +0200, Matti Vaittinen wrote: > > > > > > > Last night - just

Re: [PATCH v3] regmap: regmap-irq/gpio-max77620: add level-irq support

2019-01-03 Thread Charles Keepax
On Wed, Jan 02, 2019 at 09:42:51AM +0200, Matti Vaittinen wrote: > On Mon, Dec 31, 2018 at 07:11:27PM +, Mark Brown wrote: > > On Fri, Dec 28, 2018 at 10:05:33AM +0200, Matti Vaittinen wrote: > > > > > Last night - just when I was about to get some sleep - it stroke me. I > > > think the

Re: [PATCH v3] regmap: regmap-irq/gpio-max77620: add level-irq support

2019-01-01 Thread Matti Vaittinen
On Mon, Dec 31, 2018 at 07:11:27PM +, Mark Brown wrote: > On Fri, Dec 28, 2018 at 10:05:33AM +0200, Matti Vaittinen wrote: > > > Last night - just when I was about to get some sleep - it stroke me. I > > think the correct thing to do would be leaving the irq_set_type to NULL > > for those IRQ

Re: [PATCH v3] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-31 Thread Mark Brown
On Fri, Dec 28, 2018 at 10:05:33AM +0200, Matti Vaittinen wrote: > Last night - just when I was about to get some sleep - it stroke me. I > think the correct thing to do would be leaving the irq_set_type to NULL > for those IRQ chips which do not support type setting. If we do that, > then the

Re: [PATCH v3] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-28 Thread Matti Vaittinen
On Thu, Dec 27, 2018 at 09:56:48AM +0200, Matti Vaittinen wrote: > Hello All, > > On Thu, Dec 27, 2018 at 09:35:31AM +0200, Matti Vaittinen wrote: > > On Wed, Dec 26, 2018 at 12:39:17PM +0100, Geert Uytterhoeven wrote: > > > Hi Matti, > > > > > > On Tue, Dec 18, 2018 at 1:00 PM Matti Vaittinen >

Re: [PATCH v3] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-26 Thread Matti Vaittinen
Hello All, On Thu, Dec 27, 2018 at 09:35:31AM +0200, Matti Vaittinen wrote: > On Wed, Dec 26, 2018 at 12:39:17PM +0100, Geert Uytterhoeven wrote: > > Hi Matti, > > > > On Tue, Dec 18, 2018 at 1:00 PM Matti Vaittinen > > wrote: > > > Add level active IRQ support to regmap-irq irqchip. Change

Re: [PATCH v3] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-26 Thread Matti Vaittinen
Hello Geert, Sorry for waiting - I just opened my computer after the holidays. On Wed, Dec 26, 2018 at 12:39:17PM +0100, Geert Uytterhoeven wrote: > Hi Matti, > > On Tue, Dec 18, 2018 at 1:00 PM Matti Vaittinen > wrote: > > Add level active IRQ support to regmap-irq irqchip. Change breaks > >

Re: [PATCH v3] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-26 Thread Geert Uytterhoeven
Hi Matti, On Tue, Dec 18, 2018 at 1:00 PM Matti Vaittinen wrote: > Add level active IRQ support to regmap-irq irqchip. Change breaks > existing regmap-irq type setting. Convert the existing drivers which Indeed it does. > use regmap-irq with trigger type setting (gpio-max77620) to work > with

Re: [PATCH v3] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-19 Thread Mark Brown
On Wed, Dec 19, 2018 at 08:48:42AM +0200, Matti Vaittinen wrote: > I forgot that the block of code the commit "regmap: regmap-irq: Remove > default irq type setting from core" removes do use the old type specifiers > whcih this patch changes. So even though this patch applies cleanly on tree >

Re: [PATCH v3] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-18 Thread Matti Vaittinen
On Tue, Dec 18, 2018 at 11:36:22PM +0800, kbuild test robot wrote: > Hi Matti, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on regmap/for-next] > [also build test ERROR on next-20181218] > [cannot apply to v4.20-rc7] > [if your patch is applied to the wrong

Re: [PATCH v3] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-18 Thread kbuild test robot
Hi Matti, Thank you for the patch! Yet something to improve: [auto build test ERROR on regmap/for-next] [also build test ERROR on next-20181218] [cannot apply to v4.20-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v3] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-18 Thread Matti Vaittinen
Add level active IRQ support to regmap-irq irqchip. Change breaks existing regmap-irq type setting. Convert the existing drivers which use regmap-irq with trigger type setting (gpio-max77620) to work with this new approach. So we do not magically support level-active IRQs on gpio-max77620 - but