Re: [PATCH v3] soc: qcom: Add SoC info driver

2016-11-16 Thread Imran Khan
On 11/15/2016 10:57 AM, Bjorn Andersson wrote: > On Mon 14 Nov 06:30 PST 2016, Imran Khan wrote: > >> On 11/8/2016 1:05 AM, Bjorn Andersson wrote: >>> On Mon 07 Nov 06:35 PST 2016, Imran Khan wrote: >>> >>> >>> >>> [..] >>> >> +static void socinfo_populate(struct soc_device_attribute

Re: [PATCH v3] soc: qcom: Add SoC info driver

2016-11-16 Thread Imran Khan
On 11/15/2016 10:57 AM, Bjorn Andersson wrote: > On Mon 14 Nov 06:30 PST 2016, Imran Khan wrote: > >> On 11/8/2016 1:05 AM, Bjorn Andersson wrote: >>> On Mon 07 Nov 06:35 PST 2016, Imran Khan wrote: >>> >>> >>> >>> [..] >>> >> +static void socinfo_populate(struct soc_device_attribute

Re: [PATCH v3] soc: qcom: Add SoC info driver

2016-11-14 Thread Bjorn Andersson
On Mon 14 Nov 06:30 PST 2016, Imran Khan wrote: > On 11/8/2016 1:05 AM, Bjorn Andersson wrote: > > On Mon 07 Nov 06:35 PST 2016, Imran Khan wrote: > > > > > > > > [..] > > > +static void socinfo_populate(struct soc_device_attribute *soc_dev_attr) > +{ > +u32 soc_version

Re: [PATCH v3] soc: qcom: Add SoC info driver

2016-11-14 Thread Bjorn Andersson
On Mon 14 Nov 06:30 PST 2016, Imran Khan wrote: > On 11/8/2016 1:05 AM, Bjorn Andersson wrote: > > On Mon 07 Nov 06:35 PST 2016, Imran Khan wrote: > > > > > > > > [..] > > > +static void socinfo_populate(struct soc_device_attribute *soc_dev_attr) > +{ > +u32 soc_version

Re: [PATCH v3] soc: qcom: Add SoC info driver

2016-11-14 Thread Imran Khan
On 11/8/2016 1:05 AM, Bjorn Andersson wrote: > On Mon 07 Nov 06:35 PST 2016, Imran Khan wrote: > > > > [..] > +static void socinfo_populate(struct soc_device_attribute *soc_dev_attr) +{ + u32 soc_version = socinfo_get_version(); + + soc_dev_attr->soc_id =

Re: [PATCH v3] soc: qcom: Add SoC info driver

2016-11-14 Thread Imran Khan
On 11/8/2016 1:05 AM, Bjorn Andersson wrote: > On Mon 07 Nov 06:35 PST 2016, Imran Khan wrote: > > > > [..] > +static void socinfo_populate(struct soc_device_attribute *soc_dev_attr) +{ + u32 soc_version = socinfo_get_version(); + + soc_dev_attr->soc_id =

Re: [PATCH v3] soc: qcom: Add SoC info driver

2016-11-07 Thread Bjorn Andersson
On Mon 07 Nov 06:35 PST 2016, Imran Khan wrote: > On 11/3/2016 12:00 AM, Bjorn Andersson wrote: > Thanks Bjorn for your review comments. I have taken into account > most of these in the subsequent patch set. For a few of the comments > I want to discuss further, so please see the same inline and

Re: [PATCH v3] soc: qcom: Add SoC info driver

2016-11-07 Thread Bjorn Andersson
On Mon 07 Nov 06:35 PST 2016, Imran Khan wrote: > On 11/3/2016 12:00 AM, Bjorn Andersson wrote: > Thanks Bjorn for your review comments. I have taken into account > most of these in the subsequent patch set. For a few of the comments > I want to discuss further, so please see the same inline and

Re: [PATCH v3] soc: qcom: Add SoC info driver

2016-11-07 Thread Imran Khan
On 11/3/2016 12:00 AM, Bjorn Andersson wrote: Thanks Bjorn for your review comments. I have taken into account most of these in the subsequent patch set. For a few of the comments I want to discuss further, so please see the same inline and let me know your feedback about the same. > On Wed 02

Re: [PATCH v3] soc: qcom: Add SoC info driver

2016-11-07 Thread Imran Khan
On 11/3/2016 12:00 AM, Bjorn Andersson wrote: Thanks Bjorn for your review comments. I have taken into account most of these in the subsequent patch set. For a few of the comments I want to discuss further, so please see the same inline and let me know your feedback about the same. > On Wed 02

Re: [PATCH v3] soc: qcom: Add SoC info driver

2016-11-02 Thread Bjorn Andersson
On Wed 02 Nov 03:06 PDT 2016, Imran Khan wrote: > The SoC info driver provides information such as Chip ID, > Chip family, serial number and other such details about > Qualcomm SoCs. > > Signed-off-by: Imran Khan [..] > diff --git a/drivers/soc/qcom/Makefile

Re: [PATCH v3] soc: qcom: Add SoC info driver

2016-11-02 Thread Bjorn Andersson
On Wed 02 Nov 03:06 PDT 2016, Imran Khan wrote: > The SoC info driver provides information such as Chip ID, > Chip family, serial number and other such details about > Qualcomm SoCs. > > Signed-off-by: Imran Khan [..] > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > index

[PATCH v3] soc: qcom: Add SoC info driver

2016-11-02 Thread Imran Khan
The SoC info driver provides information such as Chip ID, Chip family, serial number and other such details about Qualcomm SoCs. Signed-off-by: Imran Khan --- v2 --> v3: - Add support to toss soc information data into entropy pool - Since socinfo is rolled into smem

[PATCH v3] soc: qcom: Add SoC info driver

2016-11-02 Thread Imran Khan
The SoC info driver provides information such as Chip ID, Chip family, serial number and other such details about Qualcomm SoCs. Signed-off-by: Imran Khan --- v2 --> v3: - Add support to toss soc information data into entropy pool - Since socinfo is rolled into smem driver, compile the