Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Dan Carpenter
On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: > On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: > >On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: > >>This patch redefine function xhci_readl.xhci_readl function doesn't use > >>xhci_hcd argument. > >>Hence

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Sarah Sharp
On Wed, Aug 28, 2013 at 10:45:48PM +0530, Kumar Gaurav wrote: > On Wednesday 28 August 2013 10:31 PM, Sarah Sharp wrote: > >On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: > >>On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: > >>>On Mon, Aug 26, 2013 at 07:38:57AM +0530,

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Kumar Gaurav
On Wednesday 28 August 2013 10:31 PM, Sarah Sharp wrote: On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: I've started cloning linux-next and as it's not

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Sarah Sharp
On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: > On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: > >On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: > I've started cloning linux-next and as it's not applying on > linux-next, I'll try it on linux-next (once i

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Kumar Gaurav
On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: This patch redefine function xhci_readl.xhci_readl function doesn't use xhci_hcd argument. Hence there is no need of keeping it in the function arguments. Redefining this

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Dan Carpenter
On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: > This patch redefine function xhci_readl.xhci_readl function doesn't use > xhci_hcd argument. > Hence there is no need of keeping it in the function arguments. > > Redefining this function breaks other functions which calls this

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Dan Carpenter
On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: This patch redefine function xhci_readl.xhci_readl function doesn't use xhci_hcd argument. Hence there is no need of keeping it in the function arguments. Redefining this function breaks other functions which calls this

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Kumar Gaurav
On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: This patch redefine function xhci_readl.xhci_readl function doesn't use xhci_hcd argument. Hence there is no need of keeping it in the function arguments. Redefining this

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Sarah Sharp
On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: I've started cloning linux-next and as it's not applying on linux-next, I'll try it on linux-next (once i

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Kumar Gaurav
On Wednesday 28 August 2013 10:31 PM, Sarah Sharp wrote: On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: I've started cloning linux-next and as it's not

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Sarah Sharp
On Wed, Aug 28, 2013 at 10:45:48PM +0530, Kumar Gaurav wrote: On Wednesday 28 August 2013 10:31 PM, Sarah Sharp wrote: On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Dan Carpenter
On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: This patch redefine function xhci_readl.xhci_readl function doesn't use xhci_hcd argument. Hence there is no

[PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-25 Thread Kumar Gaurav
This patch redefine function xhci_readl.xhci_readl function doesn't use xhci_hcd argument. Hence there is no need of keeping it in the function arguments. Redefining this function breaks other functions which calls this function. This phatch also correct those calls in xhci driver.

[PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-25 Thread Kumar Gaurav
This patch redefine function xhci_readl.xhci_readl function doesn't use xhci_hcd argument. Hence there is no need of keeping it in the function arguments. Redefining this function breaks other functions which calls this function. This phatch also correct those calls in xhci driver.

[PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-21 Thread Kumar Gaurav
This patch redefine function xhci_readl.xhci_readl function doesn't use xhci_hcd argument. Hence there is no need of keeping it in the function arguments. Redefining this function breaks other functions which calls this function. This phatch also correct those calls in xhci driver.

[PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-21 Thread Kumar Gaurav
This patch redefine function xhci_readl.xhci_readl function doesn't use xhci_hcd argument. Hence there is no need of keeping it in the function arguments. Redefining this function breaks other functions which calls this function. This phatch also correct those calls in xhci driver.