Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-25 Thread Bjorn Helgaas
On Thu, Jun 20, 2013 at 6:51 AM, Joerg Roedel wrote: > On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: >> I pushed these with updates to >> http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/alexander-msi >> >> Anybody want to ack the iommu/irq_remapping.c

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-25 Thread Bjorn Helgaas
On Thu, Jun 20, 2013 at 6:51 AM, Joerg Roedel j...@8bytes.org wrote: On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: I pushed these with updates to http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/alexander-msi Anybody want to ack the iommu/irq_remapping.c

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-20 Thread Joerg Roedel
On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: > I pushed these with updates to > http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/alexander-msi > > Anybody want to ack the iommu/irq_remapping.c patch? If so, I can > merge that branch into -next for v3.11.

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-20 Thread Joerg Roedel
On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: I pushed these with updates to http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/alexander-msi Anybody want to ack the iommu/irq_remapping.c patch? If so, I can merge that branch into -next for v3.11. Sorry

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-06 Thread Sebastian Andrzej Siewior
On Thu, Jun 06, 2013 at 10:30:20AM +0200, Alexander Gordeev wrote: > Sebastian, Hi Alexander, > I re-read my comment few times and I admit it might be confusing. You are > right - 'multiple' is set by rounding up only. The part '...not necessarily > the closest power-of-two value...' implied an

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-06 Thread Alexander Gordeev
On Wed, Jun 05, 2013 at 10:56:38PM +0200, Sebastian Andrzej Siewior wrote: > On Mon, May 13, 2013 at 11:05:48AM +0200, Alexander Gordeev wrote: > > Note, although the existing 'msi_desc::multiple' field might seem > > redundant, in fact in does not. In general case the number of MSIs a > > PCI

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-06 Thread Alexander Gordeev
On Wed, Jun 05, 2013 at 10:56:38PM +0200, Sebastian Andrzej Siewior wrote: On Mon, May 13, 2013 at 11:05:48AM +0200, Alexander Gordeev wrote: Note, although the existing 'msi_desc::multiple' field might seem redundant, in fact in does not. In general case the number of MSIs a PCI device is

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-06 Thread Sebastian Andrzej Siewior
On Thu, Jun 06, 2013 at 10:30:20AM +0200, Alexander Gordeev wrote: Sebastian, Hi Alexander, I re-read my comment few times and I admit it might be confusing. You are right - 'multiple' is set by rounding up only. The part '...not necessarily the closest power-of-two value...' implied an

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Sebastian Andrzej Siewior
-Suresh On Wed, Jun 05, 2013 at 03:09:34PM -0600, Bjorn Helgaas wrote: > > Alexander had an example device that advertised 16 vectors, but the > driver knew that it could only generate 6. That's a case where we > can't compute 'multiple' from 'nvec' (assuming the driver supplies > 'nvec == 6').

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Bjorn Helgaas
On Wed, Jun 5, 2013 at 2:56 PM, Sebastian Andrzej Siewior wrote: > On Mon, May 13, 2013 at 11:05:48AM +0200, Alexander Gordeev wrote: >> Note, although the existing 'msi_desc::multiple' field might seem >> redundant, in fact in does not. In general case the number of MSIs a >> PCI device is

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Sebastian Andrzej Siewior
On Mon, May 13, 2013 at 11:05:48AM +0200, Alexander Gordeev wrote: > Note, although the existing 'msi_desc::multiple' field might seem > redundant, in fact in does not. In general case the number of MSIs a > PCI device is initialized with is not necessarily the closest power- > of-two value of the

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Bjorn Helgaas
On Wed, Jun 5, 2013 at 12:33 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Jun 05, 2013 at 11:18:54AM -0600, Bjorn Helgaas wrote: >> On Tue, Jun 4, 2013 at 7:14 AM, Alexander Gordeev >> wrote: >> > On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: >> >> On Wed, May 29, 2013 at 2:58

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Konrad Rzeszutek Wilk
On Wed, Jun 05, 2013 at 11:18:54AM -0600, Bjorn Helgaas wrote: > On Tue, Jun 4, 2013 at 7:14 AM, Alexander Gordeev wrote: > > On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: > >> On Wed, May 29, 2013 at 2:58 PM, Bjorn Helgaas wrote: > >> I pushed these with updates to > >>

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Bjorn Helgaas
On Tue, Jun 4, 2013 at 7:14 AM, Alexander Gordeev wrote: > On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: >> On Wed, May 29, 2013 at 2:58 PM, Bjorn Helgaas wrote: >> I pushed these with updates to >>

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Bjorn Helgaas
On Tue, Jun 4, 2013 at 7:14 AM, Alexander Gordeev agord...@redhat.com wrote: On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: On Wed, May 29, 2013 at 2:58 PM, Bjorn Helgaas bhelg...@google.com wrote: I pushed these with updates to

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Konrad Rzeszutek Wilk
On Wed, Jun 05, 2013 at 11:18:54AM -0600, Bjorn Helgaas wrote: On Tue, Jun 4, 2013 at 7:14 AM, Alexander Gordeev agord...@redhat.com wrote: On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: On Wed, May 29, 2013 at 2:58 PM, Bjorn Helgaas bhelg...@google.com wrote: I pushed these

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Bjorn Helgaas
On Wed, Jun 5, 2013 at 12:33 PM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Wed, Jun 05, 2013 at 11:18:54AM -0600, Bjorn Helgaas wrote: On Tue, Jun 4, 2013 at 7:14 AM, Alexander Gordeev agord...@redhat.com wrote: On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: On

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Sebastian Andrzej Siewior
On Mon, May 13, 2013 at 11:05:48AM +0200, Alexander Gordeev wrote: Note, although the existing 'msi_desc::multiple' field might seem redundant, in fact in does not. In general case the number of MSIs a PCI device is initialized with is not necessarily the closest power- of-two value of the

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Bjorn Helgaas
On Wed, Jun 5, 2013 at 2:56 PM, Sebastian Andrzej Siewior sebast...@breakpoint.cc wrote: On Mon, May 13, 2013 at 11:05:48AM +0200, Alexander Gordeev wrote: Note, although the existing 'msi_desc::multiple' field might seem redundant, in fact in does not. In general case the number of MSIs a PCI

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-05 Thread Sebastian Andrzej Siewior
-Suresh On Wed, Jun 05, 2013 at 03:09:34PM -0600, Bjorn Helgaas wrote: Alexander had an example device that advertised 16 vectors, but the driver knew that it could only generate 6. That's a case where we can't compute 'multiple' from 'nvec' (assuming the driver supplies 'nvec == 6'). If

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-04 Thread Alexander Gordeev
On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: > On Wed, May 29, 2013 at 2:58 PM, Bjorn Helgaas wrote: > I pushed these with updates to > http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/alexander-msi > > Anybody want to ack the iommu/irq_remapping.c patch?

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-04 Thread Alexander Gordeev
On Mon, Jun 03, 2013 at 02:46:59PM -0600, Bjorn Helgaas wrote: On Wed, May 29, 2013 at 2:58 PM, Bjorn Helgaas bhelg...@google.com wrote: I pushed these with updates to http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/alexander-msi Anybody want to ack the

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-03 Thread Bjorn Helgaas
On Wed, May 29, 2013 at 2:58 PM, Bjorn Helgaas wrote: > [-cc Suresh] > > On Wed, May 29, 2013 at 2:36 AM, Alexander Gordeev > wrote: >> On Tue, May 28, 2013 at 03:51:52PM -0600, Bjorn Helgaas wrote: >>> On Mon, May 13, 2013 at 3:05 AM, Alexander Gordeev >>> wrote: >>> >>> The subject would

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-06-03 Thread Bjorn Helgaas
On Wed, May 29, 2013 at 2:58 PM, Bjorn Helgaas bhelg...@google.com wrote: [-cc Suresh] On Wed, May 29, 2013 at 2:36 AM, Alexander Gordeev agord...@redhat.com wrote: On Tue, May 28, 2013 at 03:51:52PM -0600, Bjorn Helgaas wrote: On Mon, May 13, 2013 at 3:05 AM, Alexander Gordeev

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-05-29 Thread Bjorn Helgaas
[-cc Suresh] On Wed, May 29, 2013 at 2:36 AM, Alexander Gordeev wrote: > On Tue, May 28, 2013 at 03:51:52PM -0600, Bjorn Helgaas wrote: >> On Mon, May 13, 2013 at 3:05 AM, Alexander Gordeev >> wrote: >> >> The subject would make more sense as "Allocate *only* as many MSIs as >> requested." > >

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-05-29 Thread Alexander Gordeev
On Tue, May 28, 2013 at 03:51:52PM -0600, Bjorn Helgaas wrote: > On Mon, May 13, 2013 at 3:05 AM, Alexander Gordeev > wrote: > > The subject would make more sense as "Allocate *only* as many MSIs as > requested." 1. > > When multiple MSIs are enabled with pci_enable_msi_block(), the > >

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-05-29 Thread Alexander Gordeev
On Tue, May 28, 2013 at 03:51:52PM -0600, Bjorn Helgaas wrote: On Mon, May 13, 2013 at 3:05 AM, Alexander Gordeev agord...@redhat.com wrote: The subject would make more sense as Allocate *only* as many MSIs as requested. 1. When multiple MSIs are enabled with pci_enable_msi_block(), the

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-05-29 Thread Bjorn Helgaas
[-cc Suresh] On Wed, May 29, 2013 at 2:36 AM, Alexander Gordeev agord...@redhat.com wrote: On Tue, May 28, 2013 at 03:51:52PM -0600, Bjorn Helgaas wrote: On Mon, May 13, 2013 at 3:05 AM, Alexander Gordeev agord...@redhat.com wrote: The subject would make more sense as Allocate *only* as

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-05-28 Thread Bjorn Helgaas
On Mon, May 13, 2013 at 3:05 AM, Alexander Gordeev wrote: The subject would make more sense as "Allocate *only* as many MSIs as requested." > When multiple MSIs are enabled with pci_enable_msi_block(), the > requested number of interrupts 'nvec' is rounded up to the nearest > power-of-two

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-05-28 Thread Ingo Molnar
* Alexander Gordeev wrote: > When multiple MSIs are enabled with pci_enable_msi_block(), the > requested number of interrupts 'nvec' is rounded up to the nearest > power-of-two value. The result is then used for setting up the > number of MSI messages in the PCI device and allocation of >

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-05-28 Thread Ingo Molnar
* Alexander Gordeev agord...@redhat.com wrote: When multiple MSIs are enabled with pci_enable_msi_block(), the requested number of interrupts 'nvec' is rounded up to the nearest power-of-two value. The result is then used for setting up the number of MSI messages in the PCI device and

Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-05-28 Thread Bjorn Helgaas
On Mon, May 13, 2013 at 3:05 AM, Alexander Gordeev agord...@redhat.com wrote: The subject would make more sense as Allocate *only* as many MSIs as requested. When multiple MSIs are enabled with pci_enable_msi_block(), the requested number of interrupts 'nvec' is rounded up to the nearest

[PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-05-13 Thread Alexander Gordeev
When multiple MSIs are enabled with pci_enable_msi_block(), the requested number of interrupts 'nvec' is rounded up to the nearest power-of-two value. The result is then used for setting up the number of MSI messages in the PCI device and allocation of interrupt resources in the operating system

[PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested

2013-05-13 Thread Alexander Gordeev
When multiple MSIs are enabled with pci_enable_msi_block(), the requested number of interrupts 'nvec' is rounded up to the nearest power-of-two value. The result is then used for setting up the number of MSI messages in the PCI device and allocation of interrupt resources in the operating system