Re: [PATCH v3 0/5] Scan for an idle sibling in a single pass

2021-01-26 Thread Mel Gorman
On Mon, Jan 25, 2021 at 12:29:47PM +0800, Li, Aubrey wrote: > >>> hackbench -l 2560 -g 1 on 8 cores arm64 > >>> v5.11-rc4 : 1.355 (+/- 7.96) > >>> + sis improvement : 1.923 (+/- 25%) > >>> + the patch below : 1.332 (+/- 4.95) > >>> > >>> hackbench -l 2560 -g 256 on 8 cores arm64 > >>> v5.11-rc4 :

Re: [PATCH v3 0/5] Scan for an idle sibling in a single pass

2021-01-25 Thread Li, Aubrey
On 2021/1/25 17:04, Mel Gorman wrote: > On Mon, Jan 25, 2021 at 12:29:47PM +0800, Li, Aubrey wrote: > hackbench -l 2560 -g 1 on 8 cores arm64 > v5.11-rc4 : 1.355 (+/- 7.96) > + sis improvement : 1.923 (+/- 25%) > + the patch below : 1.332 (+/- 4.95) > > hackbench -l 2560 -g

Re: [PATCH v3 0/5] Scan for an idle sibling in a single pass

2021-01-25 Thread Mel Gorman
On Mon, Jan 25, 2021 at 07:37:55PM +0800, Li, Aubrey wrote: > > It's interesting that patch 3 would make any difference on x64 given that > > it's SMT2. The scan depth should have been similar. It's somewhat expected > > that it will not be a universal win, particularly once the utilisation > > is

Re: [PATCH v3 0/5] Scan for an idle sibling in a single pass

2021-01-24 Thread Li, Aubrey
On 2021/1/22 21:22, Vincent Guittot wrote: > On Fri, 22 Jan 2021 at 11:14, Mel Gorman wrote: >> >> On Fri, Jan 22, 2021 at 10:30:52AM +0100, Vincent Guittot wrote: >>> Hi Mel, >>> >>> On Tue, 19 Jan 2021 at 13:02, Mel Gorman >>> wrote: On Tue, Jan 19, 2021 at 12:33:04PM +0100, Vincent

Re: [PATCH v3 0/5] Scan for an idle sibling in a single pass

2021-01-22 Thread Vincent Guittot
On Fri, 22 Jan 2021 at 11:14, Mel Gorman wrote: > > On Fri, Jan 22, 2021 at 10:30:52AM +0100, Vincent Guittot wrote: > > Hi Mel, > > > > On Tue, 19 Jan 2021 at 13:02, Mel Gorman > > wrote: > > > > > > On Tue, Jan 19, 2021 at 12:33:04PM +0100, Vincent Guittot wrote: > > > > On Tue, 19 Jan 2021

Re: [PATCH v3 0/5] Scan for an idle sibling in a single pass

2021-01-22 Thread Mel Gorman
On Fri, Jan 22, 2021 at 10:30:52AM +0100, Vincent Guittot wrote: > Hi Mel, > > On Tue, 19 Jan 2021 at 13:02, Mel Gorman wrote: > > > > On Tue, Jan 19, 2021 at 12:33:04PM +0100, Vincent Guittot wrote: > > > On Tue, 19 Jan 2021 at 12:22, Mel Gorman > > > wrote: > > > > > > > > Changelog since v2

Re: [PATCH v3 0/5] Scan for an idle sibling in a single pass

2021-01-22 Thread Vincent Guittot
Hi Mel, On Tue, 19 Jan 2021 at 13:02, Mel Gorman wrote: > > On Tue, Jan 19, 2021 at 12:33:04PM +0100, Vincent Guittot wrote: > > On Tue, 19 Jan 2021 at 12:22, Mel Gorman > > wrote: > > > > > > Changelog since v2 > > > o Remove unnecessary parameters > > > o Update nr during scan only when

Re: [PATCH v3 0/5] Scan for an idle sibling in a single pass

2021-01-19 Thread Mel Gorman
On Tue, Jan 19, 2021 at 12:33:04PM +0100, Vincent Guittot wrote: > On Tue, 19 Jan 2021 at 12:22, Mel Gorman wrote: > > > > Changelog since v2 > > o Remove unnecessary parameters > > o Update nr during scan only when scanning for cpus > > Hi Mel, > > I haven't looked at your previous version

Re: [PATCH v3 0/5] Scan for an idle sibling in a single pass

2021-01-19 Thread Vincent Guittot
On Tue, 19 Jan 2021 at 12:22, Mel Gorman wrote: > > Changelog since v2 > o Remove unnecessary parameters > o Update nr during scan only when scanning for cpus Hi Mel, I haven't looked at your previous version mainly because I'm chasing a performance regression on v5.11-rcx which prevents me

[PATCH v3 0/5] Scan for an idle sibling in a single pass

2021-01-19 Thread Mel Gorman
Changelog since v2 o Remove unnecessary parameters o Update nr during scan only when scanning for cpus Changlog since v1 o Move extern declaration to header for coding style o Remove unnecessary parameter from __select_idle_cpu This series of 5 patches reposts three patches from Peter entitled