Re: [PATCH v3 0/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-12 Thread Baoquan He
On 02/11/18 at 11:11pm, Eric W. Biederman wrote: > Dou Liyang writes: > > > Hi all, > > > > One thing confused me. > > > > The disconnect_bsp_APIC() may restore the interrupt delivery mode into > > virtual wire mode. it uses the vector F as the spurious interrput, But,

Re: [PATCH v3 0/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-12 Thread Baoquan He
On 02/11/18 at 11:11pm, Eric W. Biederman wrote: > Dou Liyang writes: > > > Hi all, > > > > One thing confused me. > > > > The disconnect_bsp_APIC() may restore the interrupt delivery mode into > > virtual wire mode. it uses the vector F as the spurious interrput, But, > > IMO, using the vector

Re: [PATCH v3 0/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-12 Thread Dou Liyang
Hi Eric, At 02/12/2018 01:11 PM, Eric W. Biederman wrote: Dou Liyang writes: Hi all, One thing confused me. The disconnect_bsp_APIC() may restore the interrupt delivery mode into virtual wire mode. it uses the vector F as the spurious interrput, But, IMO, using

Re: [PATCH v3 0/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-12 Thread Dou Liyang
Hi Eric, At 02/12/2018 01:11 PM, Eric W. Biederman wrote: Dou Liyang writes: Hi all, One thing confused me. The disconnect_bsp_APIC() may restore the interrupt delivery mode into virtual wire mode. it uses the vector F as the spurious interrput, But, IMO, using the vector

Re: [PATCH v3 0/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-11 Thread Eric W. Biederman
Dou Liyang writes: > Hi all, > > One thing confused me. > > The disconnect_bsp_APIC() may restore the interrupt delivery mode into > virtual wire mode. it uses the vector F as the spurious interrput, But, > IMO, using the vector 0xFF(SPURIOUS_APIC_VECTOR) may more

Re: [PATCH v3 0/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-11 Thread Eric W. Biederman
Dou Liyang writes: > Hi all, > > One thing confused me. > > The disconnect_bsp_APIC() may restore the interrupt delivery mode into > virtual wire mode. it uses the vector F as the spurious interrput, But, > IMO, using the vector 0xFF(SPURIOUS_APIC_VECTOR) may more suitable and > will give us

Re: [PATCH v3 0/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-11 Thread Dou Liyang
Hi all, One thing confused me. The disconnect_bsp_APIC() may restore the interrupt delivery mode into virtual wire mode. it uses the vector F as the spurious interrput, But, IMO, using the vector 0xFF(SPURIOUS_APIC_VECTOR) may more suitable and will give us more detail. Why the

Re: [PATCH v3 0/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-11 Thread Dou Liyang
Hi all, One thing confused me. The disconnect_bsp_APIC() may restore the interrupt delivery mode into virtual wire mode. it uses the vector F as the spurious interrput, But, IMO, using the vector 0xFF(SPURIOUS_APIC_VECTOR) may more suitable and will give us more detail. Why the

[PATCH v3 0/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-09 Thread Baoquan He
A regression bug was introduced in below commit. commit 522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC") It caused the action to fail which we try to restore boot irq mode in reboot and kexec/kdump. Details can be seen in patch 0002. Warning can always be seen

[PATCH v3 0/5] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

2018-02-09 Thread Baoquan He
A regression bug was introduced in below commit. commit 522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC") It caused the action to fail which we try to restore boot irq mode in reboot and kexec/kdump. Details can be seen in patch 0002. Warning can always be seen