Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-16 Thread Hal Rosenstock
On 4/15/2015 4:33 PM, ira.weiny wrote: > On Wed, Apr 15, 2015 at 02:36:13PM -0400, Hal Rosenstock wrote: >> On 4/13/2015 8:22 AM, Michael Wang wrote: >>> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h >>> index 65994a1..d54f91e 100644 >>> --- a/include/rdma/ib_verbs.h >>> +++

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-16 Thread Michael Wang
Hi, Hal On 04/15/2015 08:36 PM, Hal Rosenstock wrote: > On 4/13/2015 8:22 AM, Michael Wang wrote: [snip] >> __attribute_const__ enum rdma_transport_type >> @@ -1501,6 +1504,8 @@ struct ib_device { >> int(*query_port)(struct ib_device *device, >>

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-16 Thread Michael Wang
Hi, Hal On 04/15/2015 08:36 PM, Hal Rosenstock wrote: On 4/13/2015 8:22 AM, Michael Wang wrote: [snip] __attribute_const__ enum rdma_transport_type @@ -1501,6 +1504,8 @@ struct ib_device { int(*query_port)(struct ib_device *device,

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-16 Thread Hal Rosenstock
On 4/15/2015 4:33 PM, ira.weiny wrote: On Wed, Apr 15, 2015 at 02:36:13PM -0400, Hal Rosenstock wrote: On 4/13/2015 8:22 AM, Michael Wang wrote: diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 65994a1..d54f91e 100644 --- a/include/rdma/ib_verbs.h +++

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-15 Thread ira.weiny
On Wed, Apr 15, 2015 at 01:29:31PM -0600, Hefty, Sean wrote: > > libibverbs also exposes transport at the device level. Isn't a change to > > make transport per port rather than per device needed there as well to > > be consistent with these proposed kernel changes ? If so, would the > >

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-15 Thread ira.weiny
On Wed, Apr 15, 2015 at 02:36:13PM -0400, Hal Rosenstock wrote: > On 4/13/2015 8:22 AM, Michael Wang wrote: > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > > index 65994a1..d54f91e 100644 > > --- a/include/rdma/ib_verbs.h > > +++ b/include/rdma/ib_verbs.h > > @@ -75,10 +75,13

RE: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-15 Thread Hefty, Sean
> libibverbs also exposes transport at the device level. Isn't a change to > make transport per port rather than per device needed there as well to > be consistent with these proposed kernel changes ? If so, would the > additional IBoE transport be exposed ? We also need to worry about > backward

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-15 Thread Hal Rosenstock
On 4/13/2015 8:22 AM, Michael Wang wrote: > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > index 65994a1..d54f91e 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -75,10 +75,13 @@ enum rdma_node_type { > }; > > enum rdma_transport_type { > + /*

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-15 Thread Hal Rosenstock
On 4/13/2015 8:22 AM, Michael Wang wrote: diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 65994a1..d54f91e 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -75,10 +75,13 @@ enum rdma_node_type { }; enum rdma_transport_type { + /* legacy

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-15 Thread ira.weiny
On Wed, Apr 15, 2015 at 02:36:13PM -0400, Hal Rosenstock wrote: On 4/13/2015 8:22 AM, Michael Wang wrote: diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 65994a1..d54f91e 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -75,10 +75,13 @@ enum

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-15 Thread ira.weiny
On Wed, Apr 15, 2015 at 01:29:31PM -0600, Hefty, Sean wrote: libibverbs also exposes transport at the device level. Isn't a change to make transport per port rather than per device needed there as well to be consistent with these proposed kernel changes ? If so, would the additional IBoE

RE: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-15 Thread Hefty, Sean
libibverbs also exposes transport at the device level. Isn't a change to make transport per port rather than per device needed there as well to be consistent with these proposed kernel changes ? If so, would the additional IBoE transport be exposed ? We also need to worry about backward

[PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-13 Thread Michael Wang
Add new callback query_transport() and implement for each HW. Mapping List: node-type link-layer old-transport new-transport nes RNICETH IWARP IWARP amso1100RNICETH IWARP IWARP

[PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-13 Thread Michael Wang
Add new callback query_transport() and implement for each HW. Mapping List: node-type link-layer old-transport new-transport nes RNICETH IWARP IWARP amso1100RNICETH IWARP IWARP