Re: [PATCH v3 02/12] RISC-V: Filter ISA and MMU values in cpuinfo

2018-09-10 Thread Atish Patra
On 9/10/18 4:24 AM, Christoph Hellwig wrote: On Thu, Sep 06, 2018 at 01:05:25AM -0700, Atish Patra wrote: +#elif defined(CONFIG_64BIT) + if ((strcmp(mmu_type, "riscv,sv39") != 0) + && (strcmp(mmu_type, "riscv,sv48") != 0)) + return; This should be: if

Re: [PATCH v3 02/12] RISC-V: Filter ISA and MMU values in cpuinfo

2018-09-10 Thread Christoph Hellwig
On Thu, Sep 06, 2018 at 01:05:25AM -0700, Atish Patra wrote: > +#elif defined(CONFIG_64BIT) > + if ((strcmp(mmu_type, "riscv,sv39") != 0) > + && (strcmp(mmu_type, "riscv,sv48") != 0)) > + return; This should be: if (strcmp(mmu_type, "riscv,sv39") != 0 &&

[PATCH v3 02/12] RISC-V: Filter ISA and MMU values in cpuinfo

2018-09-06 Thread Atish Patra
From: Palmer Dabbelt We shouldn't be directly passing device tree values to userspace, both because there could be mistakes in device trees and because the kernel doesn't support arbitrary ISAs. Signed-off-by: Palmer Dabbelt [Atish: checkpatch fix and code comment formatting update]