Re: [PATCH v3 02/13] i2c: rk3x: add support for rv1108

2017-08-12 Thread Wolfram Sang
On Fri, Aug 11, 2017 at 11:39:13AM +0800, Andy Yan wrote: > Support for the i2c controller on rv1108 soc. > > Signed-off-by: Andy Yan > Reviewed-by: Heiko Stuebner Applied to for-next, thanks! signature.asc Description: PGP signature

Re: [PATCH v3 02/13] i2c: rk3x: add support for rv1108

2017-08-12 Thread Wolfram Sang
On Fri, Aug 11, 2017 at 11:39:13AM +0800, Andy Yan wrote: > Support for the i2c controller on rv1108 soc. > > Signed-off-by: Andy Yan > Reviewed-by: Heiko Stuebner Applied to for-next, thanks! signature.asc Description: PGP signature

Re: [PATCH v3 02/13] i2c: rk3x: add support for rv1108

2017-08-12 Thread Wolfram Sang
> Actually, there is one I2C controller(I2C2) has a different feature with > all the other rockchip soc.The I2C2 is not used on my current board. But I > plan to add this feature later。 So I give RV1108 a new compatible string > here。 Makes sense. Thanks! signature.asc Description: PGP

Re: [PATCH v3 02/13] i2c: rk3x: add support for rv1108

2017-08-12 Thread Wolfram Sang
> Actually, there is one I2C controller(I2C2) has a different feature with > all the other rockchip soc.The I2C2 is not used on my current board. But I > plan to add this feature later。 So I give RV1108 a new compatible string > here。 Makes sense. Thanks! signature.asc Description: PGP

Re: [PATCH v3 02/13] i2c: rk3x: add support for rv1108

2017-08-12 Thread Wolfram Sang
Hi, > +static const struct rk3x_i2c_soc_data rv1108_soc_data = { > + .grf_offset = -1, > + .calc_timings = rk3x_i2c_v1_calc_timings, > +}; > + I don't care super much, but why don't you reuse rk3399_soc_data()? Or even use the rk3399 compatible as fallback value? Kind regards,

Re: [PATCH v3 02/13] i2c: rk3x: add support for rv1108

2017-08-12 Thread Wolfram Sang
Hi, > +static const struct rk3x_i2c_soc_data rv1108_soc_data = { > + .grf_offset = -1, > + .calc_timings = rk3x_i2c_v1_calc_timings, > +}; > + I don't care super much, but why don't you reuse rk3399_soc_data()? Or even use the rk3399 compatible as fallback value? Kind regards,

[PATCH v3 02/13] i2c: rk3x: add support for rv1108

2017-08-10 Thread Andy Yan
Support for the i2c controller on rv1108 soc. Signed-off-by: Andy Yan Reviewed-by: Heiko Stuebner --- Changes in v3: None Changes in v2: None drivers/i2c/busses/i2c-rk3x.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v3 02/13] i2c: rk3x: add support for rv1108

2017-08-10 Thread Andy Yan
Support for the i2c controller on rv1108 soc. Signed-off-by: Andy Yan Reviewed-by: Heiko Stuebner --- Changes in v3: None Changes in v2: None drivers/i2c/busses/i2c-rk3x.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/i2c/busses/i2c-rk3x.c