Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On Sat, Dec 16, 2017 at 12:31:34PM -0600, Timur Tabi wrote: > On 12/16/17 11:49 AM, Nicolin Chen wrote: > >I never said that I don't agree with Timur. Every change here is > >to simplify things. As long as Timur or any reviewer feels one of > >new comments is harder to understand, I am totally

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On Sat, Dec 16, 2017 at 12:31:34PM -0600, Timur Tabi wrote: > On 12/16/17 11:49 AM, Nicolin Chen wrote: > >I never said that I don't agree with Timur. Every change here is > >to simplify things. As long as Timur or any reviewer feels one of > >new comments is harder to understand, I am totally

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

First of all, thanks a lot for the review. And I will send a v4 after I refine these comments. But please please don't think in the way like "you can touch it unless it's untrue." I never said anything or anyone is wrong here. As the other patches that shortens variable names, this patch just

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

First of all, thanks a lot for the review. And I will send a v4 after I refine these comments. But please please don't think in the way like "you can touch it unless it's untrue." I never said anything or anyone is wrong here. As the other patches that shortens variable names, this patch just

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/16/17 11:49 AM, Nicolin Chen wrote: I never said that I don't agree with Timur. Every change here is to simplify things. As long as Timur or any reviewer feels one of new comments is harder to understand, I am totally fine to rework. I respect everyone's opinion, but I hope everyone can

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/16/17 11:49 AM, Nicolin Chen wrote: I never said that I don't agree with Timur. Every change here is to simplify things. As long as Timur or any reviewer feels one of new comments is harder to understand, I am totally fine to rework. I respect everyone's opinion, but I hope everyone can

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On Sat, Dec 16, 2017 at 09:30:14AM -0800, Caleb Crome wrote: > Having come to work on this driver with very little knowledge about > kernel programming, and i.MX, I have to agree with Timur. It's an > amazingly complex driver (with support of so many variants). By > eliminating verbose

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On Sat, Dec 16, 2017 at 09:30:14AM -0800, Caleb Crome wrote: > Having come to work on this driver with very little knowledge about > kernel programming, and i.MX, I have to agree with Timur. It's an > amazingly complex driver (with support of so many variants). By > eliminating verbose

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/16/17 11:30 AM, Caleb Crome wrote: Having come to work on this driver with very little knowledge about kernel programming, and i.MX, I have to agree with Timur. It's an amazingly complex driver (with support of so many variants). By eliminating verbose commentary, it's also wiping away a

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/16/17 11:30 AM, Caleb Crome wrote: Having come to work on this driver with very little knowledge about kernel programming, and i.MX, I have to agree with Timur. It's an amazingly complex driver (with support of so many variants). By eliminating verbose commentary, it's also wiping away a

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

Hi, On Sat, Dec 16, 2017 at 10:27:06AM -0600, Timur Tabi wrote: > On 12/16/17 12:10 AM, Nicolin Chen wrote: > >Hi, > > > >I am outside so can't use mutt. Sorry for that. > > > >This comment is going to be replaced in the 2nd set anyway because the > >whole function will be replaced. > > So

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

Hi, On Sat, Dec 16, 2017 at 10:27:06AM -0600, Timur Tabi wrote: > On 12/16/17 12:10 AM, Nicolin Chen wrote: > >Hi, > > > >I am outside so can't use mutt. Sorry for that. > > > >This comment is going to be replaced in the 2nd set anyway because the > >whole function will be replaced. > > So

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On Sat, Dec 16, 2017 at 9:15 AM, Timur Tabi wrote: > > On 12/13/17 5:18 PM, Nicolin Chen wrote: > >> - /* Used when using fsl-ssi as sound-card. This is only used by ppc >> and >> -* should be replaced with simple-sound-card. */ >> struct platform_device

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On Sat, Dec 16, 2017 at 9:15 AM, Timur Tabi wrote: > > On 12/13/17 5:18 PM, Nicolin Chen wrote: > >> - /* Used when using fsl-ssi as sound-card. This is only used by ppc >> and >> -* should be replaced with simple-sound-card. */ >> struct platform_device *pdev; > > > Is

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/13/17 5:18 PM, Nicolin Chen wrote: - /* Used when using fsl-ssi as sound-card. This is only used by ppc and -* should be replaced with simple-sound-card. */ struct platform_device *pdev; Is this comment no longer true? + * 1) SSI in earlier SoCS has crtical bits

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/13/17 5:18 PM, Nicolin Chen wrote: - /* Used when using fsl-ssi as sound-card. This is only used by ppc and -* should be replaced with simple-sound-card. */ struct platform_device *pdev; Is this comment no longer true? + * 1) SSI in earlier SoCS has crtical bits

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/16/17 12:10 AM, Nicolin Chen wrote: Hi, I am outside so can't use mutt. Sorry for that. This comment is going to be replaced in the 2nd set anyway because the whole function will be replaced. So you're asking me to review comment changes that will soon be deleted? Can you send out a

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/16/17 12:10 AM, Nicolin Chen wrote: Hi, I am outside so can't use mutt. Sorry for that. This comment is going to be replaced in the 2nd set anyway because the whole function will be replaced. So you're asking me to review comment changes that will soon be deleted? Can you send out a

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/13/17 5:18 PM, Nicolin Chen wrote: -* We are running on a SoC which does not support online SSI -* reconfiguration, so we have to enable all necessary flags at once -* even if we do not use them later (capture and playback configuration) +* Online

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/13/17 5:18 PM, Nicolin Chen wrote: -* We are running on a SoC which does not support online SSI -* reconfiguration, so we have to enable all necessary flags at once -* even if we do not use them later (capture and playback configuration) +* Online

[PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

This patch refines the comments by: 1) Removing all out-of-date comments 2) Removing all not-so-useful comments 3) Unifying the styles of all comments 4) Simplifying over-descriptive comments 5) Adding comments to improve code readablity 6) Moving all register related comments to fsl_ssi.h 7)

[PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

This patch refines the comments by: 1) Removing all out-of-date comments 2) Removing all not-so-useful comments 3) Unifying the styles of all comments 4) Simplifying over-descriptive comments 5) Adding comments to improve code readablity 6) Moving all register related comments to fsl_ssi.h 7)