Re: [PATCH v3 07/10] regulator: mt6358: Add support for MT6358 regulator

2019-05-06 Thread Nicolas Boichat
On Fri, May 3, 2019 at 6:34 PM Hsin-Hsiung Wang wrote: > > The MT6358 is a regulator found on boards based on MediaTek MT8183 and > probably other SoCs. It is a so called pmic and connects as a slave to > SoC using SPI, wrapped inside the pmic-wrapper. > > Signed-off-by: Hsin-Hsiung Wang > --- >

Re: [PATCH v3 07/10] regulator: mt6358: Add support for MT6358 regulator

2019-05-06 Thread Mark Brown
On Fri, May 03, 2019 at 05:31:14PM +0800, Hsin-Hsiung Wang wrote: A few fairly minor things but mostly this looks good. > +static const u32 vcama1_voltages[] = { > + 180, 250, 270, > + 280, 290, 300, > +}; > +static const u32 vcama2_voltages[] = { > +

[PATCH v3 07/10] regulator: mt6358: Add support for MT6358 regulator

2019-05-03 Thread Hsin-Hsiung Wang
The MT6358 is a regulator found on boards based on MediaTek MT8183 and probably other SoCs. It is a so called pmic and connects as a slave to SoC using SPI, wrapped inside the pmic-wrapper. Signed-off-by: Hsin-Hsiung Wang --- drivers/regulator/Kconfig | 9 +