Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-22 Thread Alex Shi
On 01/23/2013 09:47 AM, Mike Galbraith wrote: > On Wed, 2013-01-23 at 08:36 +0800, Alex Shi wrote: >> On 01/22/2013 05:52 PM, Mike Galbraith wrote: >>> On Tue, 2013-01-22 at 15:50 +0800, Alex Shi wrote: >>> Thanks for your suggestions and example, Mike! I just can't understand the your

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-22 Thread Mike Galbraith
On Wed, 2013-01-23 at 08:36 +0800, Alex Shi wrote: > On 01/22/2013 05:52 PM, Mike Galbraith wrote: > > On Tue, 2013-01-22 at 15:50 +0800, Alex Shi wrote: > > > >> Thanks for your suggestions and example, Mike! > >> I just can't understand the your last words here, Sorry. what the > >> detailed

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-22 Thread Alex Shi
On 01/22/2013 05:52 PM, Mike Galbraith wrote: > On Tue, 2013-01-22 at 15:50 +0800, Alex Shi wrote: > >> Thanks for your suggestions and example, Mike! >> I just can't understand the your last words here, Sorry. what the >> detailed concern of you on 'both performance profiles with either >>

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-22 Thread Mike Galbraith
On Tue, 2013-01-22 at 15:50 +0800, Alex Shi wrote: > Thanks for your suggestions and example, Mike! > I just can't understand the your last words here, Sorry. what the > detailed concern of you on 'both performance profiles with either > metric'? Could you like to give your preferred solutions?

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-22 Thread Mike Galbraith
On Tue, 2013-01-22 at 15:50 +0800, Alex Shi wrote: Thanks for your suggestions and example, Mike! I just can't understand the your last words here, Sorry. what the detailed concern of you on 'both performance profiles with either metric'? Could you like to give your preferred solutions? Hm..

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-22 Thread Alex Shi
On 01/22/2013 05:52 PM, Mike Galbraith wrote: On Tue, 2013-01-22 at 15:50 +0800, Alex Shi wrote: Thanks for your suggestions and example, Mike! I just can't understand the your last words here, Sorry. what the detailed concern of you on 'both performance profiles with either metric'? Could

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-22 Thread Mike Galbraith
On Wed, 2013-01-23 at 08:36 +0800, Alex Shi wrote: On 01/22/2013 05:52 PM, Mike Galbraith wrote: On Tue, 2013-01-22 at 15:50 +0800, Alex Shi wrote: Thanks for your suggestions and example, Mike! I just can't understand the your last words here, Sorry. what the detailed concern of you

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-22 Thread Alex Shi
On 01/23/2013 09:47 AM, Mike Galbraith wrote: On Wed, 2013-01-23 at 08:36 +0800, Alex Shi wrote: On 01/22/2013 05:52 PM, Mike Galbraith wrote: On Tue, 2013-01-22 at 15:50 +0800, Alex Shi wrote: Thanks for your suggestions and example, Mike! I just can't understand the your last words here,

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-21 Thread Alex Shi
On 01/22/2013 02:55 PM, Mike Galbraith wrote: > On Tue, 2013-01-22 at 11:20 +0800, Alex Shi wrote: >> >> I just looked into the aim9 benchmark, in this case it forks 2000 tasks, >> after all tasks ready, aim9 give a signal than all tasks burst waking up >> and run until all

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-21 Thread Mike Galbraith
On Tue, 2013-01-22 at 11:20 +0800, Alex Shi wrote: > > I just looked into the aim9 benchmark, in this case it forks 2000 tasks, > after all tasks ready, aim9 give a signal than all tasks burst waking up > and run until all finished. > Since each of tasks are finished very

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-21 Thread Alex Shi
I just looked into the aim9 benchmark, in this case it forks 2000 tasks, after all tasks ready, aim9 give a signal than all tasks burst waking up and run until all finished. Since each of tasks are finished very quickly, a imbalanced empty cpu may goes to sleep till a

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-21 Thread Alex Shi
On 01/11/2013 02:31 PM, Alex Shi wrote: > On 01/07/2013 02:31 AM, Linus Torvalds wrote: >> On Sat, Jan 5, 2013 at 11:54 PM, Alex Shi wrote: >>> >>> I just looked into the aim9 benchmark, in this case it forks 2000 tasks, >>> after all tasks ready, aim9 give a signal than all tasks burst waking up

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-21 Thread Alex Shi
On 01/11/2013 02:31 PM, Alex Shi wrote: On 01/07/2013 02:31 AM, Linus Torvalds wrote: On Sat, Jan 5, 2013 at 11:54 PM, Alex Shi alex@intel.com wrote: I just looked into the aim9 benchmark, in this case it forks 2000 tasks, after all tasks ready, aim9 give a signal than all tasks burst

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-21 Thread Alex Shi
I just looked into the aim9 benchmark, in this case it forks 2000 tasks, after all tasks ready, aim9 give a signal than all tasks burst waking up and run until all finished. Since each of tasks are finished very quickly, a imbalanced empty cpu may goes to sleep till a regular balancing give

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-21 Thread Mike Galbraith
On Tue, 2013-01-22 at 11:20 +0800, Alex Shi wrote: I just looked into the aim9 benchmark, in this case it forks 2000 tasks, after all tasks ready, aim9 give a signal than all tasks burst waking up and run until all finished. Since each of tasks are finished very quickly, a imbalanced

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-21 Thread Alex Shi
On 01/22/2013 02:55 PM, Mike Galbraith wrote: On Tue, 2013-01-22 at 11:20 +0800, Alex Shi wrote: I just looked into the aim9 benchmark, in this case it forks 2000 tasks, after all tasks ready, aim9 give a signal than all tasks burst waking up and run until all finished. Since each of tasks

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-10 Thread Alex Shi
On 01/07/2013 02:31 AM, Linus Torvalds wrote: > On Sat, Jan 5, 2013 at 11:54 PM, Alex Shi wrote: >> >> I just looked into the aim9 benchmark, in this case it forks 2000 tasks, >> after all tasks ready, aim9 give a signal than all tasks burst waking up >> and run until all finished. >> Since each

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-10 Thread Alex Shi
On 01/07/2013 02:31 AM, Linus Torvalds wrote: On Sat, Jan 5, 2013 at 11:54 PM, Alex Shi alex@intel.com wrote: I just looked into the aim9 benchmark, in this case it forks 2000 tasks, after all tasks ready, aim9 give a signal than all tasks burst waking up and run until all finished.

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-08 Thread Alex Shi
On 01/07/2013 02:31 AM, Linus Torvalds wrote: > On Sat, Jan 5, 2013 at 11:54 PM, Alex Shi wrote: >> >> I just looked into the aim9 benchmark, in this case it forks 2000 tasks, >> after all tasks ready, aim9 give a signal than all tasks burst waking up >> and run until all finished. >> Since each

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-08 Thread Alex Shi
On 01/07/2013 02:31 AM, Linus Torvalds wrote: On Sat, Jan 5, 2013 at 11:54 PM, Alex Shi alex@intel.com wrote: I just looked into the aim9 benchmark, in this case it forks 2000 tasks, after all tasks ready, aim9 give a signal than all tasks burst waking up and run until all finished.

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-06 Thread Preeti U Murthy
Hi everyone, On 01/07/2013 12:01 AM, Linus Torvalds wrote: > On Sat, Jan 5, 2013 at 11:54 PM, Alex Shi wrote: >> >> I just looked into the aim9 benchmark, in this case it forks 2000 tasks, >> after all tasks ready, aim9 give a signal than all tasks burst waking up >> and run until all finished.

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-06 Thread Linus Torvalds
On Sat, Jan 5, 2013 at 11:54 PM, Alex Shi wrote: > > I just looked into the aim9 benchmark, in this case it forks 2000 tasks, > after all tasks ready, aim9 give a signal than all tasks burst waking up > and run until all finished. > Since each of tasks are finished very quickly, a imbalanced

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-06 Thread Linus Torvalds
On Sat, Jan 5, 2013 at 11:54 PM, Alex Shi alex@intel.com wrote: I just looked into the aim9 benchmark, in this case it forks 2000 tasks, after all tasks ready, aim9 give a signal than all tasks burst waking up and run until all finished. Since each of tasks are finished very quickly, a

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-06 Thread Preeti U Murthy
Hi everyone, On 01/07/2013 12:01 AM, Linus Torvalds wrote: On Sat, Jan 5, 2013 at 11:54 PM, Alex Shi alex@intel.com wrote: I just looked into the aim9 benchmark, in this case it forks 2000 tasks, after all tasks ready, aim9 give a signal than all tasks burst waking up and run until all

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-05 Thread Alex Shi
>> static unsigned long weighted_cpuload(const int cpu) >> { >> -return cpu_rq(cpu)->load.weight; >> +return (unsigned long)cpu_rq(cpu)->cfs.runnable_load_avg; > > Above line change cause aim9 multitask benchmark drop about 10% > performance on many x86 machines. Profile just show

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-05 Thread Alex Shi
On 01/05/2013 04:37 PM, Alex Shi wrote: > They are the base values in load balance, update them with rq runnable > load average, then the load balance will consider runnable load avg > naturally. > > Signed-off-by: Alex Shi > --- > kernel/sched/core.c | 8 > kernel/sched/fair.c | 4

[PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-05 Thread Alex Shi
They are the base values in load balance, update them with rq runnable load average, then the load balance will consider runnable load avg naturally. Signed-off-by: Alex Shi --- kernel/sched/core.c | 8 kernel/sched/fair.c | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-)

[PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-05 Thread Alex Shi
They are the base values in load balance, update them with rq runnable load average, then the load balance will consider runnable load avg naturally. Signed-off-by: Alex Shi alex@intel.com --- kernel/sched/core.c | 8 kernel/sched/fair.c | 4 ++-- 2 files changed, 10 insertions(+),

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-05 Thread Alex Shi
On 01/05/2013 04:37 PM, Alex Shi wrote: They are the base values in load balance, update them with rq runnable load average, then the load balance will consider runnable load avg naturally. Signed-off-by: Alex Shi alex@intel.com --- kernel/sched/core.c | 8

Re: [PATCH v3 09/22] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-01-05 Thread Alex Shi
static unsigned long weighted_cpuload(const int cpu) { -return cpu_rq(cpu)-load.weight; +return (unsigned long)cpu_rq(cpu)-cfs.runnable_load_avg; Above line change cause aim9 multitask benchmark drop about 10% performance on many x86 machines. Profile just show there are more