Re: [PATCH v3 1/1] Staging: android/ion: declare function static

[Joseph Wright]

On Tue, Jul 18, 2017 at 08:58:22AM +0200, Greg KH wrote:
> On Sat, Jul 15, 2017 at 11:43:05AM +, Joseph Wright wrote:
> > Declare private function static to fix sparse warning:
> > 
> > ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
> > was not declared. Should it be static?
> > 
> > Signed-off-by: Joseph Wright 
> > ---
> > Changes in v3:
> >   - Make subject clearer
> > 
> >  drivers/staging/android/ion/ion_cma_heap.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Sorry, does not apply to my tree as I think someone else already did
> this before you did :(

Okay, thanks anyway.

Joseph

Re: [PATCH v3 1/1] Staging: android/ion: declare function static

[Joseph Wright]

On Tue, Jul 18, 2017 at 08:58:22AM +0200, Greg KH wrote:
> On Sat, Jul 15, 2017 at 11:43:05AM +, Joseph Wright wrote:
> > Declare private function static to fix sparse warning:
> > 
> > ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
> > was not declared. Should it be static?
> > 
> > Signed-off-by: Joseph Wright 
> > ---
> > Changes in v3:
> >   - Make subject clearer
> > 
> >  drivers/staging/android/ion/ion_cma_heap.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Sorry, does not apply to my tree as I think someone else already did
> this before you did :(

Okay, thanks anyway.

Joseph

Re: [PATCH v3 1/1] Staging: android/ion: declare function static

[Greg KH]

On Sat, Jul 15, 2017 at 11:43:05AM +, Joseph Wright wrote:
> Declare private function static to fix sparse warning:
> 
> ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
>   was not declared. Should it be static?
> 
> Signed-off-by: Joseph Wright 
> ---
> Changes in v3:
>   - Make subject clearer
> 
>  drivers/staging/android/ion/ion_cma_heap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Sorry, does not apply to my tree as I think someone else already did
this before you did :(

Re: [PATCH v3 1/1] Staging: android/ion: declare function static

[Greg KH]

On Sat, Jul 15, 2017 at 11:43:05AM +, Joseph Wright wrote:
> Declare private function static to fix sparse warning:
> 
> ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
>   was not declared. Should it be static?
> 
> Signed-off-by: Joseph Wright 
> ---
> Changes in v3:
>   - Make subject clearer
> 
>  drivers/staging/android/ion/ion_cma_heap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Sorry, does not apply to my tree as I think someone else already did
this before you did :(

[PATCH v3 1/1] Staging: android/ion: declare function static

[Joseph Wright]

Declare private function static to fix sparse warning:

ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
was not declared. Should it be static?

Signed-off-by: Joseph Wright 
---
Changes in v3:
  - Make subject clearer

 drivers/staging/android/ion/ion_cma_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion_cma_heap.c 
b/drivers/staging/android/ion/ion_cma_heap.c
index a0949bc..c6db9b7 100644
--- a/drivers/staging/android/ion/ion_cma_heap.c
+++ b/drivers/staging/android/ion/ion_cma_heap.c
@@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma 
*cma)
return _heap->heap;
 }
 
-int __ion_add_cma_heaps(struct cma *cma, void *data)
+static int __ion_add_cma_heaps(struct cma *cma, void *data)
 {
struct ion_heap *heap;
 
-- 
2.9.3

[PATCH v3 1/1] Staging: android/ion: declare function static

[Joseph Wright]

Declare private function static to fix sparse warning:

ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
was not declared. Should it be static?

Signed-off-by: Joseph Wright 
---
Changes in v3:
  - Make subject clearer

 drivers/staging/android/ion/ion_cma_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion_cma_heap.c 
b/drivers/staging/android/ion/ion_cma_heap.c
index a0949bc..c6db9b7 100644
--- a/drivers/staging/android/ion/ion_cma_heap.c
+++ b/drivers/staging/android/ion/ion_cma_heap.c
@@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma 
*cma)
return _heap->heap;
 }
 
-int __ion_add_cma_heaps(struct cma *cma, void *data)
+static int __ion_add_cma_heaps(struct cma *cma, void *data)
 {
struct ion_heap *heap;
 
-- 
2.9.3