Re: [PATCH v3 1/2] tracing: support "bool" type in synthetic trace events

2020-10-13 Thread David Rientjes
On Fri, 9 Oct 2020, Axel Rasmussen wrote: > It's common [1] to define tracepoint fields as "bool" when they contain > a true / false value. Currently, defining a synthetic event with a > "bool" field yields EINVAL. It's possible to work around this by using > e.g. u8 (assuming sizeof(bool) is 1,

Re: [PATCH v3 1/2] tracing: support "bool" type in synthetic trace events

2020-10-12 Thread Axel Rasmussen
On Mon, Oct 12, 2020 at 7:46 AM Steven Rostedt wrote: > > On Mon, 12 Oct 2020 09:26:13 -0500 > Tom Zanussi wrote: > > > Hi Steve, > > > > Looks ok to me. > > > > Acked-by: Tom Zanussi > > Great! > > I'll pull this patch into my tree. It doesn't look like patch 2/2 is > dependent on this and

Re: [PATCH v3 1/2] tracing: support "bool" type in synthetic trace events

2020-10-12 Thread Steven Rostedt
On Mon, 12 Oct 2020 09:26:13 -0500 Tom Zanussi wrote: > Hi Steve, > > Looks ok to me. > > Acked-by: Tom Zanussi Great! I'll pull this patch into my tree. It doesn't look like patch 2/2 is dependent on this and these two can go through different trees. Is everyone OK if I take this patch

Re: [PATCH v3 1/2] tracing: support "bool" type in synthetic trace events

2020-10-12 Thread Tom Zanussi
Hi Steve, Looks ok to me. Acked-by: Tom Zanussi Thanks, Tom On Mon, 2020-10-12 at 10:15 -0400, Steven Rostedt wrote: > Tom, > > Can you ack this patch for me? > > -- Steve > > > On Fri, 9 Oct 2020 15:05:23 -0700 > Axel Rasmussen wrote: > > > It's common [1] to define tracepoint

Re: [PATCH v3 1/2] tracing: support "bool" type in synthetic trace events

2020-10-12 Thread Steven Rostedt
Tom, Can you ack this patch for me? -- Steve On Fri, 9 Oct 2020 15:05:23 -0700 Axel Rasmussen wrote: > It's common [1] to define tracepoint fields as "bool" when they contain > a true / false value. Currently, defining a synthetic event with a > "bool" field yields EINVAL. It's possible

[PATCH v3 1/2] tracing: support "bool" type in synthetic trace events

2020-10-09 Thread Axel Rasmussen
It's common [1] to define tracepoint fields as "bool" when they contain a true / false value. Currently, defining a synthetic event with a "bool" field yields EINVAL. It's possible to work around this by using e.g. u8 (assuming sizeof(bool) is 1, and bool is unsigned; if either of these properties