Re: [PATCH v3 1/2] ubi: provide a way to skip CRC checks

2018-07-02 Thread Artem Bityutskiy
On Mon, 2018-07-02 at 09:51 +0200, Boris Brezillon wrote: > Well, I thought checking the CRC just after updating the volume made > sense, just to make sure things were written correctly on the medium. > Let's add a comment explaining why we keep the check here, unless you > see a strong reason to g

Re: [PATCH v3 1/2] ubi: provide a way to skip CRC checks

2018-07-02 Thread Richard Weinberger
Am Montag, 2. Juli 2018, 09:51:21 CEST schrieb Boris Brezillon: > Hi Artem, > > On Mon, 02 Jul 2018 10:30:25 +0300 > Artem Bityutskiy wrote: > > > Hi, > > > > On Thu, 2018-06-28 at 09:40 +0200, Quentin Schulz wrote: > > > diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c > > > index

Re: [PATCH v3 1/2] ubi: provide a way to skip CRC checks

2018-07-02 Thread Boris Brezillon
Hi Artem, On Mon, 02 Jul 2018 10:30:25 +0300 Artem Bityutskiy wrote: > Hi, > > On Thu, 2018-06-28 at 09:40 +0200, Quentin Schulz wrote: > > diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c > > index d4b2e87..e9e9ecb 100644 > > --- a/drivers/mtd/ubi/kapi.c > > +++ b/drivers/mtd/ubi/k

Re: [PATCH v3 1/2] ubi: provide a way to skip CRC checks

2018-07-02 Thread Artem Bityutskiy
On Mon, 2018-07-02 at 09:43 +0200, Richard Weinberger wrote: > Artem, > > Am Montag, 2. Juli 2018, 09:30:25 CEST schrieb Artem Bityutskiy: > > Hi, > > > > On Thu, 2018-06-28 at 09:40 +0200, Quentin Schulz wrote: > > > diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c > > > index d4b2e8

Re: [PATCH v3 1/2] ubi: provide a way to skip CRC checks

2018-07-02 Thread Richard Weinberger
Artem, Am Montag, 2. Juli 2018, 09:30:25 CEST schrieb Artem Bityutskiy: > Hi, > > On Thu, 2018-06-28 at 09:40 +0200, Quentin Schulz wrote: > > diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c > > index d4b2e87..e9e9ecb 100644 > > --- a/drivers/mtd/ubi/kapi.c > > +++ b/drivers/mtd/ubi/

Re: [PATCH v3 1/2] ubi: provide a way to skip CRC checks

2018-07-02 Thread Artem Bityutskiy
Hi, On Thu, 2018-06-28 at 09:40 +0200, Quentin Schulz wrote: > diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c > index d4b2e87..e9e9ecb 100644 > --- a/drivers/mtd/ubi/kapi.c > +++ b/drivers/mtd/ubi/kapi.c > @@ -202,7 +202,7 @@ struct ubi_volume_desc *ubi_open_volume(int ubi_num, int

Re: [PATCH v3 1/2] ubi: provide a way to skip CRC checks

2018-07-01 Thread Richard Weinberger
Am Donnerstag, 28. Juni 2018, 09:40:52 CEST schrieb Quentin Schulz: > Some users of static UBI volumes implement their own integrity check, > thus making the volume CRC check done at open time useless. For > instance, this is the case when one use the ubiblock + dm-verity + > squashfs combination,

[PATCH v3 1/2] ubi: provide a way to skip CRC checks

2018-06-28 Thread Quentin Schulz
Some users of static UBI volumes implement their own integrity check, thus making the volume CRC check done at open time useless. For instance, this is the case when one use the ubiblock + dm-verity + squashfs combination, where dm-verity already checks integrity of the block device but this time a