Re: [PATCH v3 1/3] Input: gpio-keys - add support for wakeup event action

2018-03-05 Thread JeffyChen
Hi Dmitry, Thanks for your review. On 03/06/2018 08:30 AM, Dmitry Torokhov wrote: >+ switch (button->wakeup_event_action) { >+ case EV_ACT_ASSERTED: >+ bdata->wakeup_trigger_type = active_low ? >+ IRQF_TRIGGER_FALLING :

Re: [PATCH v3 1/3] Input: gpio-keys - add support for wakeup event action

2018-03-05 Thread JeffyChen
Hi Dmitry, Thanks for your review. On 03/06/2018 08:30 AM, Dmitry Torokhov wrote: >+ switch (button->wakeup_event_action) { >+ case EV_ACT_ASSERTED: >+ bdata->wakeup_trigger_type = active_low ? >+ IRQF_TRIGGER_FALLING :

Re: [PATCH v3 1/3] Input: gpio-keys - add support for wakeup event action

2018-03-05 Thread Dmitry Torokhov
Hi Jeffy, On Fri, Mar 02, 2018 at 11:51:00AM +0800, Jeffy Chen wrote: > Add support for specifying event actions to trigger wakeup when using > the gpio-keys input device as a wakeup source. > > This would allow the device to configure when to wakeup the system. For > example a gpio-keys input

Re: [PATCH v3 1/3] Input: gpio-keys - add support for wakeup event action

2018-03-05 Thread Dmitry Torokhov
Hi Jeffy, On Fri, Mar 02, 2018 at 11:51:00AM +0800, Jeffy Chen wrote: > Add support for specifying event actions to trigger wakeup when using > the gpio-keys input device as a wakeup source. > > This would allow the device to configure when to wakeup the system. For > example a gpio-keys input

Re: [PATCH v3 1/3] Input: gpio-keys - add support for wakeup event action

2018-03-02 Thread Brian Norris
Hi Jeffy, On Fri, Mar 02, 2018 at 11:51:00AM +0800, Jeffy Chen wrote: > Add support for specifying event actions to trigger wakeup when using > the gpio-keys input device as a wakeup source. > > This would allow the device to configure when to wakeup the system. For > example a gpio-keys input

Re: [PATCH v3 1/3] Input: gpio-keys - add support for wakeup event action

2018-03-02 Thread Brian Norris
Hi Jeffy, On Fri, Mar 02, 2018 at 11:51:00AM +0800, Jeffy Chen wrote: > Add support for specifying event actions to trigger wakeup when using > the gpio-keys input device as a wakeup source. > > This would allow the device to configure when to wakeup the system. For > example a gpio-keys input

[PATCH v3 1/3] Input: gpio-keys - add support for wakeup event action

2018-03-01 Thread Jeffy Chen
Add support for specifying event actions to trigger wakeup when using the gpio-keys input device as a wakeup source. This would allow the device to configure when to wakeup the system. For example a gpio-keys input device for pen insert, may only want to wakeup the system when ejecting the pen.

[PATCH v3 1/3] Input: gpio-keys - add support for wakeup event action

2018-03-01 Thread Jeffy Chen
Add support for specifying event actions to trigger wakeup when using the gpio-keys input device as a wakeup source. This would allow the device to configure when to wakeup the system. For example a gpio-keys input device for pen insert, may only want to wakeup the system when ejecting the pen.