Re: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

[Ingi Kim]

Hi Jacek,

Oh, I see. I'll add.
Thanks for the review.

On 2015년 10월 26일 19:11, Jacek Anaszewski wrote:
> Hi Ingi,
> 
> On 10/23/2015 07:48 AM, Ingi Kim wrote:
>> This patch adds the device tree bindings for RT5033 flash LEDs.
>>
>> Signed-off-by: Ingi Kim 
>> Acked-by: Rob Herring 
>> ---
>>   .../devicetree/bindings/leds/leds-rt5033.txt   | 38 
>> ++
>>   1 file changed, 38 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt 
>> b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
>> new file mode 100644
>> index 000..2ef7bdc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
>> @@ -0,0 +1,38 @@
>> +* Richtek Technology Corporation - RT5033 Flash LED Driver
>> +
>> +The RT5033 Flash LED Circuit is designed for one or two LEDs driving
> 
> These bindings don't say how to handle two LEDs case.
> 
>> +for torch and strobe applications, it provides an I2C software command
>> +to trigger the torch and strobe operation.
>> +
>> +Required properties:
>> +- compatible : Must be "richtek,rt5033-led".
>> +
>> +A discrete LED element connected to the device must be represented by a 
>> child
>> +node - see Documentation/devicetree/bindings/leds/common.txt.
>> +
>> +Required properties of the LED child node:
>> +  See Documentation/devicetree/bindings/leds/common.txt
>> +- led-max-microamp : Minimum Threshold for Timer protection
>> +  is defined internally (Maximum 200mA).
>> +- flash-max-microamp : Flash LED maximum current
>> +- flash-max-timeout-us : Flash LED maximum timeout
>> +
>> +Optional properties of the LED child node:
>> +- label : see Documentation/devicetree/bindings/leds/common.txt
>> +
>> +Example:
>> +
>> +rt5033 {
>> +compatible = "richtek,rt5033";
>> +
>> +led {
>> +compatible = "richtek,rt5033-led";
>> +
>> +flash-led {
>> +label = "rt5033-flash";
>> +led-max-microamp = <20>;
>> +flash-max-microamp = <80>;
>> +flash-max-timeout-us = <1216000>;
>> +};
>> +};
>> +}
>>
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

[Ingi Kim]

Hi Jacek,

Oh, I see. I'll add.
Thanks for the review.

On 2015년 10월 26일 19:11, Jacek Anaszewski wrote:
> Hi Ingi,
> 
> On 10/23/2015 07:48 AM, Ingi Kim wrote:
>> This patch adds the device tree bindings for RT5033 flash LEDs.
>>
>> Signed-off-by: Ingi Kim 
>> Acked-by: Rob Herring 
>> ---
>>   .../devicetree/bindings/leds/leds-rt5033.txt   | 38 
>> ++
>>   1 file changed, 38 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt 
>> b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
>> new file mode 100644
>> index 000..2ef7bdc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
>> @@ -0,0 +1,38 @@
>> +* Richtek Technology Corporation - RT5033 Flash LED Driver
>> +
>> +The RT5033 Flash LED Circuit is designed for one or two LEDs driving
> 
> These bindings don't say how to handle two LEDs case.
> 
>> +for torch and strobe applications, it provides an I2C software command
>> +to trigger the torch and strobe operation.
>> +
>> +Required properties:
>> +- compatible : Must be "richtek,rt5033-led".
>> +
>> +A discrete LED element connected to the device must be represented by a 
>> child
>> +node - see Documentation/devicetree/bindings/leds/common.txt.
>> +
>> +Required properties of the LED child node:
>> +  See Documentation/devicetree/bindings/leds/common.txt
>> +- led-max-microamp : Minimum Threshold for Timer protection
>> +  is defined internally (Maximum 200mA).
>> +- flash-max-microamp : Flash LED maximum current
>> +- flash-max-timeout-us : Flash LED maximum timeout
>> +
>> +Optional properties of the LED child node:
>> +- label : see Documentation/devicetree/bindings/leds/common.txt
>> +
>> +Example:
>> +
>> +rt5033 {
>> +compatible = "richtek,rt5033";
>> +
>> +led {
>> +compatible = "richtek,rt5033-led";
>> +
>> +flash-led {
>> +label = "rt5033-flash";
>> +led-max-microamp = <20>;
>> +flash-max-microamp = <80>;
>> +flash-max-timeout-us = <1216000>;
>> +};
>> +};
>> +}
>>
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

[Jacek Anaszewski]

Hi Ingi,

On 10/23/2015 07:48 AM, Ingi Kim wrote:

This patch adds the device tree bindings for RT5033 flash LEDs.

Signed-off-by: Ingi Kim 
Acked-by: Rob Herring 
---
  .../devicetree/bindings/leds/leds-rt5033.txt   | 38 ++
  1 file changed, 38 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt

diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt 
b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
new file mode 100644
index 000..2ef7bdc
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
@@ -0,0 +1,38 @@
+* Richtek Technology Corporation - RT5033 Flash LED Driver
+
+The RT5033 Flash LED Circuit is designed for one or two LEDs driving


These bindings don't say how to handle two LEDs case.


+for torch and strobe applications, it provides an I2C software command
+to trigger the torch and strobe operation.
+
+Required properties:
+- compatible : Must be "richtek,rt5033-led".
+
+A discrete LED element connected to the device must be represented by a child
+node - see Documentation/devicetree/bindings/leds/common.txt.
+
+Required properties of the LED child node:
+  See Documentation/devicetree/bindings/leds/common.txt
+- led-max-microamp : Minimum Threshold for Timer protection
+  is defined internally (Maximum 200mA).
+- flash-max-microamp : Flash LED maximum current
+- flash-max-timeout-us : Flash LED maximum timeout
+
+Optional properties of the LED child node:
+- label : see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+
+rt5033 {
+   compatible = "richtek,rt5033";
+
+   led {
+   compatible = "richtek,rt5033-led";
+
+   flash-led {
+   label = "rt5033-flash";
+   led-max-microamp = <20>;
+   flash-max-microamp = <80>;
+   flash-max-timeout-us = <1216000>;
+   };
+   };
+}




--
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

[Jacek Anaszewski]

Hi Ingi,

On 10/23/2015 07:48 AM, Ingi Kim wrote:

This patch adds the device tree bindings for RT5033 flash LEDs.

Signed-off-by: Ingi Kim 
Acked-by: Rob Herring 
---
  .../devicetree/bindings/leds/leds-rt5033.txt   | 38 ++
  1 file changed, 38 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt

diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt 
b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
new file mode 100644
index 000..2ef7bdc
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
@@ -0,0 +1,38 @@
+* Richtek Technology Corporation - RT5033 Flash LED Driver
+
+The RT5033 Flash LED Circuit is designed for one or two LEDs driving


These bindings don't say how to handle two LEDs case.


+for torch and strobe applications, it provides an I2C software command
+to trigger the torch and strobe operation.
+
+Required properties:
+- compatible : Must be "richtek,rt5033-led".
+
+A discrete LED element connected to the device must be represented by a child
+node - see Documentation/devicetree/bindings/leds/common.txt.
+
+Required properties of the LED child node:
+  See Documentation/devicetree/bindings/leds/common.txt
+- led-max-microamp : Minimum Threshold for Timer protection
+  is defined internally (Maximum 200mA).
+- flash-max-microamp : Flash LED maximum current
+- flash-max-timeout-us : Flash LED maximum timeout
+
+Optional properties of the LED child node:
+- label : see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+
+rt5033 {
+   compatible = "richtek,rt5033";
+
+   led {
+   compatible = "richtek,rt5033-led";
+
+   flash-led {
+   label = "rt5033-flash";
+   led-max-microamp = <20>;
+   flash-max-microamp = <80>;
+   flash-max-timeout-us = <1216000>;
+   };
+   };
+}




--
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

[Ingi Kim]

This patch adds the device tree bindings for RT5033 flash LEDs.

Signed-off-by: Ingi Kim 
Acked-by: Rob Herring 
---
 .../devicetree/bindings/leds/leds-rt5033.txt   | 38 ++
 1 file changed, 38 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt

diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt 
b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
new file mode 100644
index 000..2ef7bdc
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
@@ -0,0 +1,38 @@
+* Richtek Technology Corporation - RT5033 Flash LED Driver
+
+The RT5033 Flash LED Circuit is designed for one or two LEDs driving
+for torch and strobe applications, it provides an I2C software command
+to trigger the torch and strobe operation.
+
+Required properties:
+- compatible : Must be "richtek,rt5033-led".
+
+A discrete LED element connected to the device must be represented by a child
+node - see Documentation/devicetree/bindings/leds/common.txt.
+
+Required properties of the LED child node:
+  See Documentation/devicetree/bindings/leds/common.txt
+- led-max-microamp : Minimum Threshold for Timer protection
+  is defined internally (Maximum 200mA).
+- flash-max-microamp : Flash LED maximum current
+- flash-max-timeout-us : Flash LED maximum timeout
+
+Optional properties of the LED child node:
+- label : see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+
+rt5033 {
+   compatible = "richtek,rt5033";
+
+   led {
+   compatible = "richtek,rt5033-led";
+
+   flash-led {
+   label = "rt5033-flash";
+   led-max-microamp = <20>;
+   flash-max-microamp = <80>;
+   flash-max-timeout-us = <1216000>;
+   };
+   };
+}
-- 
2.0.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

[Ingi Kim]

This patch adds the device tree bindings for RT5033 flash LEDs.

Signed-off-by: Ingi Kim 
Acked-by: Rob Herring 
---
 .../devicetree/bindings/leds/leds-rt5033.txt   | 38 ++
 1 file changed, 38 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt

diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt 
b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
new file mode 100644
index 000..2ef7bdc
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
@@ -0,0 +1,38 @@
+* Richtek Technology Corporation - RT5033 Flash LED Driver
+
+The RT5033 Flash LED Circuit is designed for one or two LEDs driving
+for torch and strobe applications, it provides an I2C software command
+to trigger the torch and strobe operation.
+
+Required properties:
+- compatible : Must be "richtek,rt5033-led".
+
+A discrete LED element connected to the device must be represented by a child
+node - see Documentation/devicetree/bindings/leds/common.txt.
+
+Required properties of the LED child node:
+  See Documentation/devicetree/bindings/leds/common.txt
+- led-max-microamp : Minimum Threshold for Timer protection
+  is defined internally (Maximum 200mA).
+- flash-max-microamp : Flash LED maximum current
+- flash-max-timeout-us : Flash LED maximum timeout
+
+Optional properties of the LED child node:
+- label : see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+
+rt5033 {
+   compatible = "richtek,rt5033";
+
+   led {
+   compatible = "richtek,rt5033-led";
+
+   flash-led {
+   label = "rt5033-flash";
+   led-max-microamp = <20>;
+   flash-max-microamp = <80>;
+   flash-max-timeout-us = <1216000>;
+   };
+   };
+}
-- 
2.0.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/