On Thu, Nov 28, 2013 at 10:54:25PM +0530, Ramkumar Ramachandra wrote:
> Jiri Olsa wrote:
> > these colors are not consistent with colors in baseline,
> > moreover all negative values are shown as red
> >
> > - please check get_percent_color function (used for baseline),
> > it checks the
On Thu, Nov 28, 2013 at 10:54:25PM +0530, Ramkumar Ramachandra wrote:
Jiri Olsa wrote:
these colors are not consistent with colors in baseline,
moreover all negative values are shown as red
- please check get_percent_color function (used for baseline),
it checks the percentage against
Jiri Olsa wrote:
> these colors are not consistent with colors in baseline,
> moreover all negative values are shown as red
>
> - please check get_percent_color function (used for baseline),
> it checks the percentage against following values:
>
> #define MIN_GREEN 0.5
> #define
On Wed, Nov 27, 2013 at 04:32:31PM +0530, Ramkumar Ramachandra wrote:
> Color the numbers in the Delta column either green or red depending on
> whether the number is positive or negative.
>
> Cc: Jiri Olsa
> Cc: Namhyung Kim
> Cc: Arnaldo Carvalho de Melo
> Signed-off-by: Ramkumar Ramachandra
On Wed, Nov 27, 2013 at 04:32:31PM +0530, Ramkumar Ramachandra wrote:
Color the numbers in the Delta column either green or red depending on
whether the number is positive or negative.
Cc: Jiri Olsa jo...@redhat.com
Cc: Namhyung Kim namhy...@kernel.org
Cc: Arnaldo Carvalho de Melo
Jiri Olsa wrote:
these colors are not consistent with colors in baseline,
moreover all negative values are shown as red
- please check get_percent_color function (used for baseline),
it checks the percentage against following values:
#define MIN_GREEN 0.5
#define MIN_RED
Color the numbers in the Delta column either green or red depending on
whether the number is positive or negative.
Cc: Jiri Olsa
Cc: Namhyung Kim
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin-diff.c | 37 -
1 file
Color the numbers in the Delta column either green or red depending on
whether the number is positive or negative.
Cc: Jiri Olsa jo...@redhat.com
Cc: Namhyung Kim namhy...@kernel.org
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
8 matches
Mail list logo