Re: [linux-sunxi] Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Maxime Ripard
Hi, On Fri, Mar 07, 2014 at 12:18:58PM +0100, Wolfram Sang wrote: > > > > Since RESET_CONTROLLER is not required for those platforms, it really > > > should be optional - and I think the real fix is for the reset controller > > > support to provide stub functions. > > > > Philipp Zabel

Re: [linux-sunxi] Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Wolfram Sang
> > Since RESET_CONTROLLER is not required for those platforms, it really > > should be optional - and I think the real fix is for the reset controller > > support to provide stub functions. > > Philipp Zabel suggested that adding a _optional variant that provides stubs > and doesn't depend on

Re: [linux-sunxi] Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Chen-Yu Tsai
On Fri, Mar 7, 2014 at 6:34 PM, Russell King - ARM Linux wrote: > On Fri, Mar 07, 2014 at 11:07:51AM +0100, Maxime Ripard wrote: >> Hi Russell, >> >> On Fri, Mar 07, 2014 at 09:52:23AM +, Russell King - ARM Linux wrote: >> > On Tue, Mar 04, 2014 at 05:28:37PM +0100, Maxime Ripard wrote: >> >

Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Wolfram Sang
> Since RESET_CONTROLLER is not required for those platforms, it really > should be optional - and I think the real fix is for the reset controller > support to provide stub functions. I agree; and I assumed it already does. Will resend a patch posted earlier [1] to fix the issue. And still

Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Russell King - ARM Linux
On Fri, Mar 07, 2014 at 11:07:51AM +0100, Maxime Ripard wrote: > Hi Russell, > > On Fri, Mar 07, 2014 at 09:52:23AM +, Russell King - ARM Linux wrote: > > On Tue, Mar 04, 2014 at 05:28:37PM +0100, Maxime Ripard wrote: > > > The Allwinner A31 SoC using that IP has a reset controller

Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Maxime Ripard
Hi Russell, On Fri, Mar 07, 2014 at 09:52:23AM +, Russell King - ARM Linux wrote: > On Tue, Mar 04, 2014 at 05:28:37PM +0100, Maxime Ripard wrote: > > The Allwinner A31 SoC using that IP has a reset controller maintaining > > it reset unless told otherwise. > > > > Add some optional reset

Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Russell King - ARM Linux
On Tue, Mar 04, 2014 at 05:28:37PM +0100, Maxime Ripard wrote: > The Allwinner A31 SoC using that IP has a reset controller maintaining > it reset unless told otherwise. > > Add some optional reset support to the driver. > > Signed-off-by: Maxime Ripard > Reviewed-by: Gregory CLEMENT >

Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Russell King - ARM Linux
On Tue, Mar 04, 2014 at 05:28:37PM +0100, Maxime Ripard wrote: The Allwinner A31 SoC using that IP has a reset controller maintaining it reset unless told otherwise. Add some optional reset support to the driver. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by:

Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Maxime Ripard
Hi Russell, On Fri, Mar 07, 2014 at 09:52:23AM +, Russell King - ARM Linux wrote: On Tue, Mar 04, 2014 at 05:28:37PM +0100, Maxime Ripard wrote: The Allwinner A31 SoC using that IP has a reset controller maintaining it reset unless told otherwise. Add some optional reset support to

Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Russell King - ARM Linux
On Fri, Mar 07, 2014 at 11:07:51AM +0100, Maxime Ripard wrote: Hi Russell, On Fri, Mar 07, 2014 at 09:52:23AM +, Russell King - ARM Linux wrote: On Tue, Mar 04, 2014 at 05:28:37PM +0100, Maxime Ripard wrote: The Allwinner A31 SoC using that IP has a reset controller maintaining it

Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Wolfram Sang
Since RESET_CONTROLLER is not required for those platforms, it really should be optional - and I think the real fix is for the reset controller support to provide stub functions. I agree; and I assumed it already does. Will resend a patch posted earlier [1] to fix the issue. And still

Re: [linux-sunxi] Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Chen-Yu Tsai
On Fri, Mar 7, 2014 at 6:34 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Mar 07, 2014 at 11:07:51AM +0100, Maxime Ripard wrote: Hi Russell, On Fri, Mar 07, 2014 at 09:52:23AM +, Russell King - ARM Linux wrote: On Tue, Mar 04, 2014 at 05:28:37PM +0100, Maxime Ripard

Re: [linux-sunxi] Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Wolfram Sang
Since RESET_CONTROLLER is not required for those platforms, it really should be optional - and I think the real fix is for the reset controller support to provide stub functions. Philipp Zabel suggested that adding a _optional variant that provides stubs and doesn't depend on

Re: [linux-sunxi] Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-07 Thread Maxime Ripard
Hi, On Fri, Mar 07, 2014 at 12:18:58PM +0100, Wolfram Sang wrote: Since RESET_CONTROLLER is not required for those platforms, it really should be optional - and I think the real fix is for the reset controller support to provide stub functions. Philipp Zabel suggested that adding

Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-05 Thread Wolfram Sang
On Tue, Mar 04, 2014 at 05:28:37PM +0100, Maxime Ripard wrote: > The Allwinner A31 SoC using that IP has a reset controller maintaining > it reset unless told otherwise. > > Add some optional reset support to the driver. > > Signed-off-by: Maxime Ripard > Reviewed-by: Gregory CLEMENT >

Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-05 Thread Wolfram Sang
On Tue, Mar 04, 2014 at 05:28:37PM +0100, Maxime Ripard wrote: The Allwinner A31 SoC using that IP has a reset controller maintaining it reset unless told otherwise. Add some optional reset support to the driver. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by:

[PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-04 Thread Maxime Ripard
The Allwinner A31 SoC using that IP has a reset controller maintaining it reset unless told otherwise. Add some optional reset support to the driver. Signed-off-by: Maxime Ripard Reviewed-by: Gregory CLEMENT Tested-by: Gregory CLEMENT --- .../devicetree/bindings/i2c/i2c-mv64xxx.txt |

[PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call

2014-03-04 Thread Maxime Ripard
The Allwinner A31 SoC using that IP has a reset controller maintaining it reset unless told otherwise. Add some optional reset support to the driver. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Gregory CLEMENT gregory.clem...@free-electrons.com Tested-by: Gregory