Re: [PATCH v3 1/6] arm64: dts: imx8mq: Add NOC node

2021-01-06 Thread Shawn Guo 
On Thu, Dec 10, 2020 at 11:09:01AM +0100, Martin Kepplinger wrote:
> From: Leonard Crestez 
> 
> Add initial support for dynamic frequency scaling of the main NOC
> on imx8mq.
> 
> Make DDRC the parent of the NOC (using passive governor) so that the
> main NOC is automatically scaled together with DDRC by default.
> 
> Support for proactive scaling via interconnect will come on top.
> 
> Signed-off-by: Leonard Crestez 
> Signed-off-by: Martin Kepplinger 
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi 
> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index a841a023e8e0..9c9d68a14e69 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -1158,6 +1158,28 @@
>   };
>   };
>  
> + noc: interconnect@3270 {
> + compatible = "fsl,imx8mq-noc", "fsl,imx8m-noc";
> + reg = <0x3270 0x10>;
> + clocks = < IMX8MQ_CLK_NOC>;
> + fsl,ddrc = <>;
> + operating-points-v2 = <_opp_table>;
> +
> + noc_opp_table: opp-table {
> + compatible = "operating-points-v2";
> +
> + opp-133M {
> + opp-hz = /bits/ 64 <1>;
> + };

Please have a newline between nodes.

Shawn

> + opp-400M {
> + opp-hz = /bits/ 64 <4>;
> + };
> + opp-800M {
> + opp-hz = /bits/ 64 <8>;
> + };
> + };
> + };
> +
>   bus@32c0 { /* AIPS4 */
>   compatible = "fsl,aips-bus", "simple-bus";
>   reg = <0x32c0 0x40>;
> -- 
> 2.20.1
>

Re: [PATCH v3 1/6] arm64: dts: imx8mq: Add NOC node

2021-01-04 Thread Georgi Djakov 

On 12/10/20 12:09, Martin Kepplinger wrote:

From: Leonard Crestez 

Add initial support for dynamic frequency scaling of the main NOC
on imx8mq.

Make DDRC the parent of the NOC (using passive governor) so that the
main NOC is automatically scaled together with DDRC by default.

Support for proactive scaling via interconnect will come on top.

Signed-off-by: Leonard Crestez 
Signed-off-by: Martin Kepplinger 


Acked-by: Georgi Djakov 


---
  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++
  1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi 
b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index a841a023e8e0..9c9d68a14e69 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1158,6 +1158,28 @@
};
};
  
+		noc: interconnect@3270 {

+   compatible = "fsl,imx8mq-noc", "fsl,imx8m-noc";
+   reg = <0x3270 0x10>;
+   clocks = < IMX8MQ_CLK_NOC>;
+   fsl,ddrc = <>;
+   operating-points-v2 = <_opp_table>;
+
+   noc_opp_table: opp-table {
+   compatible = "operating-points-v2";
+
+   opp-133M {
+   opp-hz = /bits/ 64 <1>;
+   };
+   opp-400M {
+   opp-hz = /bits/ 64 <4>;
+   };
+   opp-800M {
+   opp-hz = /bits/ 64 <8>;
+   };
+   };
+   };
+
bus@32c0 { /* AIPS4 */
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x32c0 0x40>;

[PATCH v3 1/6] arm64: dts: imx8mq: Add NOC node

2020-12-10 Thread Martin Kepplinger 
From: Leonard Crestez 

Add initial support for dynamic frequency scaling of the main NOC
on imx8mq.

Make DDRC the parent of the NOC (using passive governor) so that the
main NOC is automatically scaled together with DDRC by default.

Support for proactive scaling via interconnect will come on top.

Signed-off-by: Leonard Crestez 
Signed-off-by: Martin Kepplinger 
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi 
b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index a841a023e8e0..9c9d68a14e69 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1158,6 +1158,28 @@
};
};
 
+   noc: interconnect@3270 {
+   compatible = "fsl,imx8mq-noc", "fsl,imx8m-noc";
+   reg = <0x3270 0x10>;
+   clocks = < IMX8MQ_CLK_NOC>;
+   fsl,ddrc = <>;
+   operating-points-v2 = <_opp_table>;
+
+   noc_opp_table: opp-table {
+   compatible = "operating-points-v2";
+
+   opp-133M {
+   opp-hz = /bits/ 64 <1>;
+   };
+   opp-400M {
+   opp-hz = /bits/ 64 <4>;
+   };
+   opp-800M {
+   opp-hz = /bits/ 64 <8>;
+   };
+   };
+   };
+
bus@32c0 { /* AIPS4 */
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x32c0 0x40>;
-- 
2.20.1