Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-17 Thread Andrew Morton
On Tue, 17 Nov 2020 19:31:18 -0700 Nathan Chancellor wrote: > On Tue, Nov 17, 2020 at 10:46:29AM -0800, Nick Desaulniers wrote: > > On Mon, Nov 16, 2020 at 7:04 PM John Hubbard wrote: > > > > > > Hi, > > > > > > I just ran into this and it's a real pain to figure out, because even > > > with

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-17 Thread Nathan Chancellor
On Tue, Nov 17, 2020 at 10:46:29AM -0800, Nick Desaulniers wrote: > On Mon, Nov 16, 2020 at 7:04 PM John Hubbard wrote: > > > > Hi, > > > > I just ran into this and it's a real pain to figure out, because even > > with the very latest Fedora 33 on my test machine, which provides clang > > version

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-17 Thread Nick Desaulniers
On Mon, Nov 16, 2020 at 7:04 PM John Hubbard wrote: > > Hi, > > I just ran into this and it's a real pain to figure out, because even > with the very latest Fedora 33 on my test machine, which provides clang > version 11.0.0: Hi John, Thanks for the report. The patch was picked up by AKPM and

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-16 Thread John Hubbard
Hi, I just ran into this and it's a real pain to figure out, because even with the very latest Fedora 33 on my test machine, which provides clang version 11.0.0: $ clang --version clang version 11.0.0 (Fedora 11.0.0-2.fc33) Target: x86_64-unknown-linux-gnu ...the bpftrace program still chokes

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-03 Thread Jarkko Sakkinen
On Wed, Nov 04, 2020 at 03:34:49AM +0200, Jarkko Sakkinen wrote: > Shouldn't "#ifndef" be before the whole version check? Otherwise, > LGTM. Please CC me once there is a properly formed patch to try out. (to my kernel org address). /Jarkko

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-03 Thread Jarkko Sakkinen
On Tue, Nov 03, 2020 at 05:18:38PM -0800, Nick Desaulniers wrote: > On Tue, Nov 3, 2020 at 4:38 PM Jarkko Sakkinen wrote: > > > > On Tue, Nov 03, 2020 at 10:48:27AM -0800, Nick Desaulniers wrote: > > > On Mon, Nov 2, 2020 at 8:55 PM Jarkko Sakkinen wrote: > > > > > > > > On Wed, Sep 02, 2020 at

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-03 Thread Nick Desaulniers
On Tue, Nov 3, 2020 at 4:38 PM Jarkko Sakkinen wrote: > > On Tue, Nov 03, 2020 at 10:48:27AM -0800, Nick Desaulniers wrote: > > On Mon, Nov 2, 2020 at 8:55 PM Jarkko Sakkinen wrote: > > > > > > On Wed, Sep 02, 2020 at 03:59:05PM -0700, Nick Desaulniers wrote: > > > > +#define CLANG_VERSION

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-03 Thread Jarkko Sakkinen
On Tue, Nov 03, 2020 at 10:48:27AM -0800, Nick Desaulniers wrote: > On Mon, Nov 2, 2020 at 8:55 PM Jarkko Sakkinen wrote: > > > > On Wed, Sep 02, 2020 at 03:59:05PM -0700, Nick Desaulniers wrote: > > > +#define CLANG_VERSION (__clang_major__ * 1 \ > > > + +

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-03 Thread Nick Desaulniers
On Mon, Nov 2, 2020 at 8:55 PM Jarkko Sakkinen wrote: > > On Wed, Sep 02, 2020 at 03:59:05PM -0700, Nick Desaulniers wrote: > > +#define CLANG_VERSION (__clang_major__ * 1 \ > > + + __clang_minor__ * 100\ > > + + __clang_patchlevel__) > > + > > +#if

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-03 Thread Jarkko Sakkinen
On Mon, Nov 02, 2020 at 11:38:14PM -0700, Nathan Chancellor wrote: > On Tue, Nov 03, 2020 at 06:55:21AM +0200, Jarkko Sakkinen wrote: > > On Wed, Sep 02, 2020 at 03:59:05PM -0700, Nick Desaulniers wrote: > > > During Plumbers 2020, we voted to just support the latest release of > > > Clang for

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-02 Thread Nathan Chancellor
On Tue, Nov 03, 2020 at 06:55:21AM +0200, Jarkko Sakkinen wrote: > On Wed, Sep 02, 2020 at 03:59:05PM -0700, Nick Desaulniers wrote: > > During Plumbers 2020, we voted to just support the latest release of > > Clang for now. Add a compile time check for this. > > > > We plan to remove

Re: [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-11-02 Thread Jarkko Sakkinen
On Wed, Sep 02, 2020 at 03:59:05PM -0700, Nick Desaulniers wrote: > During Plumbers 2020, we voted to just support the latest release of > Clang for now. Add a compile time check for this. > > We plan to remove workarounds for older versions now, which will break > in subtle and not so subtle

[PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1

2020-09-02 Thread Nick Desaulniers
During Plumbers 2020, we voted to just support the latest release of Clang for now. Add a compile time check for this. We plan to remove workarounds for older versions now, which will break in subtle and not so subtle ways. Suggested-by: Sedat Dilek Suggested-by: Nathan Chancellor